133351 - Bookmarks cannot be moved by drag in sidebar

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Gilles Durys]

2002032503 win98 trunk
2002032500 linux cvs trunk

Pick a bookmark in the sidebar.
Move it by dragging it.

Expected result: bookmark is moved.

Actual result: bookmark is not moved and insertion line stays shown.

This is working in the bookmark management window, not in the sidebar.
2002031503 win98 build is ok
2002031608 win 98 build is not ok.

Comment 1

[Pierre Chanial]

*** This bug has been marked as a duplicate of 128461 ***

Comment 2

[Gilles Durys]

I'm not sure this is a dup.
I have no problems in the manage bookmark window nor have I problem to delete or
edit bookmark in both the sidebar and the bookmark manage window.

Comment 3

[Peter Trudelle]

reopening, this is not a dup of 128461

Comment 4

[Peter Trudelle]

nsbeta1+ per Nav triage team, ->1.0, nav2

Comment 5

[Pierre Chanial]

This issue has already been reported in bug 131547 and has been duped against
bug 128461.
Anyway, this bug has been plussed, I will dupe 132547 against this one.

Comment 6

[Pierre Chanial]

*** Bug 131547 has been marked as a duplicate of this bug. ***

Comment 7

[selmer (gone)]

Please update this bug with an [adt1] - [adt3] impact rating (or take it off the
list if it doesn't even rate adt3.)  Thanks!

Comment 8

[Peter Trudelle]

converting nav2->adt2

Comment 9

[Chris Lyon]

*** Bug 138175 has been marked as a duplicate of this bug. ***

Comment 10

[Adrian Ulrich]

*** Bug 139419 has been marked as a duplicate of this bug. ***

Comment 11

[guanxi]

confirming on RC1 (2002041711) / Win2K, including the fact that it's a problem
in the sidebar but not the bookmark management window.

Comment 12

[117 Cooca]

*** Bug 139501 has been marked as a duplicate of this bug. ***

Comment 13

[Pierre Chanial]

*** Bug 139951 has been marked as a duplicate of this bug. ***

Comment 14

[Kris Kelvin]

confirming on RC1 (2002042406) / Win98, 
problem occurs in sidebar but not the bookmark management window

Comment 15

[Jay Farrell]

Confirming I see this on OpenVMS build from 20020419

Comment 16

[Andreas]

Also, IF it works, in many cases the Link is not added where the position bar is
shown, but somewhere completely different. This is also in the sidebar only.

Comment 17

[Jan Varga [:janv]]

I wonder why it works even in sidebar when I temporally (while in a drag session
) hover with mouse to other window (onDragExit and onDragEnter is called).
This might be a widget DND issue.

Comment 18

[Jan Varga [:janv]]

taking, patch coming

Comment 19

[Jan Varga [:janv]]

Attachment: proposed fix

I think this regressed after the nsContentAreaDragDrop rewrite.
nsContentAreadDragDrop is listening to drag events and since sidebar is part of
the document which this nsContentAreaDragDrop listens to, it was overriding
canDrop value.
So this patch prevents default dragOver event in nsTreeBodyFrame::OnDragOver

Comment 20

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 82422 [details] [diff] [review]
proposed fix

looks good. r=pink

Comment 21

[jag (Peter Annema)]

Comment on attachment 82422 [details] [diff] [review]
proposed fix

sr=jag

Comment 22

[Jan Varga [:janv]]

landed on the trunk

Comment 23

[Asa Dotzler [:asa]]

Comment on attachment 82422 [details] [diff] [review]
proposed fix

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 24

[Jan Varga [:janv]]

checked in on the branch

Comment 25

[Jay Farrell]

I still see this problem on OpenVMS build 20020513 (rc2)

Comment 26

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2003.02.19 comm trunk on linux rh8.0.