Get mochitests running on linux64-qr builds in automation

RESOLVED FIXED in Firefox 59



Graphics: WebRender
a year ago
2 months ago


(Reporter: kats, Assigned: kats)


(Depends on: 1 bug, Blocks: 2 bugs)

54 Branch
Dependency tree / graph

Firefox Tracking Flags

(firefox54 affected, firefox56 unaffected, firefox57 unaffected, firefox59 fixed)


(Whiteboard: [wr-reserve] [gfx-noted])

MozReview Requests


Submitter Diff Changes Open Issues Last Updated
Error loading review requests:


(1 attachment)

The biggest problem right now is that mochitests run on Ubuntu 12.04 machines, which have this:
  OpenGL version new 2.1 Mesa 9.2.1

which causes this:
  Failed to compile shader: "debug_font"
  0:1(10): error: GLSL 1.50 is not supported. Supported versions are: 1.10, 1.20, 1.30, and 1.00 ES
  thread '<unnamed>' panicked at '-- Shader compile failed - exiting --', /home/worker/workspace/build/src/gfx/webrender/src/
  note: Run with `RUST_BACKTRACE=1` for a backtrace.
  Redirecting call to abort() to mozalloc_abort

The reftests run on Ubuntu 16.04 which uses OpenGL version new 3.3 (Core Profile) Mesa 11.2.0 and doesn't have this problem. Therefore we either need to make webrender compatible with the older GLSL or we need to get mochitests running on 16.04 in automation (which is bug 1290183).
:jrmuizel says that we don't plan on having webrender support OpenGL 2.1 in the short term, so if we want mochitest coverage for webrender we need to get those tests migrated to ubuntu 16.04 images.
what specific mochitests do you need on 16.04?  all of them, or mochitest-webgl?
Eventually we'll want all of them for full test coverage with webrender. The graphics-related ones like webgl are probably better to get first.
with the exception of one test, we would be ready for mochitest-gl as per the patch in bug 1319801.

Possibly we can prioritize getting the blocking bugs filed so then others can work on fixing them in the coming months and when ready we can do the final push to get tests all running on 16.04.
Note that even after moving to 16.04 there are failures with webrender which we will need to investigate. See for examples.
oh, most of those are the same as non webrender- I would be at least 80% of those failures need to be resolved already.
Depends on: 1335473
Depends on: 1335906
Depends on: 1339136
Depends on: 1339167
Depends on: 1341745
Depends on: 1342966
No longer depends on: 1341745
Depends on: 1343223


9 months ago
Depends on: 1365377


9 months ago
Depends on: 1364499


9 months ago
Depends on: 1340667


9 months ago
Depends on: 1365385
With bug 1319782 fixed, we should be able to run mochitest-plain on linux64-qr with WR enabled.
Not a lot of failures, that's good to see. I might spend some more time on this after I have APZ enabled and cleaned up.
Here's a new one, now that APZ is enabled by default:

More failures than last time, in the e10s variants. Not really surprising.


8 months ago
Depends on: 1375497

Looking better than before, I think. For the non-e10s mochitests:
- dom/events/test/test_bug1013412.html is a buggy test. I have a local patch which replaces the synthesizeWheel with sendWheelAndPaint which fixes it
- dom/security/test/mixedcontentblocker/test_frameNavigation.html I'm not able to reproduce locally. Needs investigation
- editor/libeditor/tests/test_bug586662.html is a pre-existing intermittent, tracked in bug 1376382
- layout/base/tests/test_transformed_scrolling_repaints.html - needs to disabled for WR
- layout/base/tests/test_transformed_scrolling_repaints_3.html - ditto
- layout/style/test/test_animations_omta.html - probably needs fixing, not sure what's wrong here


7 months ago
Depends on: 1380680


7 months ago
Depends on: 1380683
Blocks: 1365250


5 months ago
Priority: P3 → P2
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
status-firefox56: --- → unaffected
status-firefox57: --- → unaffected


5 months ago
Depends on: 1398223


4 months ago
No longer depends on: 1340667


4 months ago
Depends on: 1411238


3 months ago
Priority: P2 → P3
Whiteboard: [wr-mvp] [gfx-noted] → [wr-reserve] [gfx-noted]
We've been using this bug as specific to linux, so let's make that explicit. I'll file new bugs for the other platforms.
Blocks: 1424752
No longer blocks: 1365250
Summary: Get mochitests running on QR builds in automation → Get mochitests running on linux64-qr builds in automation
Latest try push:

There's actually not too many failures I'm going to see if I can mark them skip-if=webrender and turn this on. We can track the skipped mochitests as sub-bugs under the meta bug 1424752.


2 months ago
Depends on: 1424782

Still a lot of low-frequency intermittents. I'm wondering if we should try to make webrender's behaviour more deterministic first. I bet a lot of these failures are due to the invalidation notification issues we have.

Also a lot of the failures seem to already have intermittent bugs on file, but they seem to happen more frequently with WR enabled. Probably timing differences tickling existing race conditions.
Hopefully last one:

I'll try to get this landed and then if there's still frequent-ish intermittents showing up after landing we can continue disabling tests until it stabilizes.
The M-e10s-13 debug failure seems to just jump from the disabled test to the one next to it so I'll probably need to get to the bottom of that first.


2 months ago
Depends on: 1154206


2 months ago
Assignee: nobody → bugmail
Comment hidden (mozreview-request)

Comment 24

2 months ago
Comment on attachment 8936793 [details]
Bug 1334189 - Enable mochitest-plain for linux64-qr.
Attachment #8936793 - Flags: review?(jmuizelaar) → review+

Comment 25

2 months ago
Pushed by
Enable mochitest-plain for linux64-qr. r=jrmuizel

Comment 26

2 months ago
Last Resolved: 2 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.