137014 - Add "Print Frame" to the frame flyout of the browser context menu.

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, enhancement)

Description

[sairuh (rarely reading bugmail)]

iirc, samir said that the backend exists for printing frames (correct me if i'm
worng here). filing this since (1) this is part of marlon's UI spec and (2) i
don't think there's a way to print frames on Mac, and this would be a door to
that feature.

Comment 1

[sairuh (rarely reading bugmail)]

nominating to workaround the current Mac limitation.

Comment 2

[dcone (gone)]

There always had been a way to print frames on OS9.. and I just landed a way to
print frames on OSX.

Comment 3

[Peter Trudelle]

nsbeta1- per Nav triage team

Comment 4

[Joel Huberman]

I would like to comment that failure of Mozilla (version 1.1a for Mac OS X) to
print the full contents of a frame (it prints only what's visible on screen--not
the remaining contents that can be viewed only by scrolling) is the first
serious problem I've encountered in the month or so that I've been using Mozilla
as my preferred browser. I hope this can be fixed. Keep up the good work.

Comment 5

[sairuh (rarely reading bugmail)]

could this go in for buffy?

Comment 6

[Samir Gehani]

Nav triage team: nsbeta1-

Comment 7

[Jesse Ruderman]

*** Bug 157784 has been marked as a duplicate of this bug. ***

Comment 8

[Jason Barnabe (np)]

*** Bug 222537 has been marked as a duplicate of this bug. ***

Comment 9

[Michael Billimoria]

This there currently a status on this bug? It seems to have orignally been
submitted over a year ago and I'd really like to see this feature.

Comment 10

[Michael Billimoria]

As per bug 222537 (which was a duplicate of this bug)...

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5;
MultiZilla v1.5.0.3g) Gecko/20031007
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5;
MultiZilla v1.5.0.3g) Gecko/20031007

When you right click on any web page or frame within a web page you should be
given the option to print the page (or frame). Perhaps this could even be
incorporated to be able to print just a single image when you right click on it.

Reproducible: Always

Steps to Reproduce:
1. Right Click on any web page or frame
2. Print page or Print Frame option is not available
3.



Expected Results:  
Print page or frame option should be available

Comment 11

[Blake Ross]

Reassigning obsolete bugs to their respective Seamonkey owners (i.e. nobody). 
If you want this fixed for Firefox, change the Product and Component accordingly
and reassign back to me.

Comment 12

[Erik Fabert]

*** Bug 265949 has been marked as a duplicate of this bug. ***

Comment 13

[Worcester12345]

How close is this to Bugzilla Bug 204519 "Add Print option to main context menu"?

Comment 14

[Worcester12345]

This is sorely missing when coming over from IE.

Comment 15

[Robert Kaiser]

A feature addition like that doesn't block a release...

Comment 16

[James Napolitano]

The Firefox equivalent to this bug, bug 185239, has recently been fixed.  We may be able to port over the fix.

Comment 17

[Serge Gautherie (:sgautherie)]

Filter "spam" on "guifeatures-nobody-20080610".

Comment 19

[Philip Chee]

Firefox Bug 185239 fixed the backend code, so all we need to do is to implement the front end UI code.

The bits we need from Firefox are:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-context.inc?rev=2ed02bff1f4d&mark=257-260#257
http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.dtd?rev=2ed02bff1f4d&mark=449-450#449
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/nsContextMenu.js?rev=2237382fc721&mark=1400-1402#1400

The corresponding points in SeaMonkey are:
http://mxr.mozilla.org/comm-central/source/suite/common/contentAreaContextOverlay.xul?rev=17e63702fc69&mark=286-286#286
http://mxr.mozilla.org/comm-central/source/suite/locales/en-US/chrome/common/contentAreaCommands.dtd
(There is no good place to add these entities so you can put them at the end)
http://mxr.mozilla.org/comm-central/source/suite/common/nsContextMenu.js?rev=fbd7b407ecb1&mark=775-775#771

Comment 20

[Melisa Cecilia [:ukimiawz]]

Hi, can I work on this bug?

I have pulled the latest source from comm-central - http://hg.mozilla.org/comm-central/
And I tried to build SeaMonkey following this page - https://developer.mozilla.org/en-US/docs/Simple_SeaMonkey_build

But I got this error 
https://drive.google.com/file/d/0B2Q6A5W2hBz9cEdkNjhSN01JM1E/view?usp=sharing

I'm on windows so I used mozmake to build it.

Comment 21

[Melisa Cecilia [:ukimiawz]]

Sorry, I manage to solve my last error, but now the build still failed with this
https://drive.google.com/file/d/0B2Q6A5W2hBz9YWE4aC13d0s3Njg/view?usp=sharing

Comment 22

[Melisa Cecilia [:ukimiawz]]

Hi again, so I finally managed to build SeaMonkey (thanks to Arai in IRC)
So, if it's ok to take this bug, I'll move the bits from Firefox, test it and create a patch for review.
Thanks!

Comment 23

[Melisa Cecilia [:ukimiawz]]

Attachment: 1111100.patch

Hi,
I moved bits from FireFox to add print frame in sea monkey

Comment 24

[Melisa Cecilia [:ukimiawz]]

Attachment: 137014.patch

Sorry, I uploaded a wrong file before

So this is the right patch, moved bits from FireFox to SeaMonkey to add print frame menu in context menu

Comment 25

[Philip Chee]

Hi Melisa Cecilia! Thank you for your patch. Looks very good.

Comment 26

[Melisa Cecilia [:ukimiawz]]

Hi, should I commit the patch or wait for review?

Comment 27

[Philip Chee]

Hi Sorry about the delay I will attach a review shortly

Comment 28

[Philip Chee]

Comment on attachment 8572457 [details] [diff] [review]
137014.patch

Looking very good except for a few small nits:

> -                oncommand="gContextMenu.showMetadata();"/>
> +                oncommand="gContextMenu.showMetadata();"/>      
You seem to have added some trailng spaces in the above line. Please remove them.

In Firefox the context-printframe is inside the frame sub-menu:
http://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/browser-context.inc?rev=63da271edfa5&mark=345-350#345
And has a <menuseparator> before and after.

Can you move the menu item to here:
http://mxr.mozilla.org/comm-central/source/suite/common/contentAreaContextOverlay.xul?rev=9cf4459806ca&mark=313-313,319-319,#309
between "context-saveframe" and "context-viewframesource"

> +  printFrame: function CM_printFrame() {
We don't decorate functions and methods these days so this should be:
printFrame: function() { ... }

Comment 29

[Melisa Cecilia [:ukimiawz]]

Attachment: 137014.patch

Hi, this is my updated patch.
Hopefully I did what is expected :)
Please inform me if I need to update it

Comment 30

[Philip Chee]

Comment on attachment 8581482 [details] [diff] [review]
137014.patch

Very nice! Good work! A few very minor points:

> Bug 137014 - Move bits from FireFox to SeaMonkey to add Print Frame on context menu.
We are not moving but copying. We should say what this patch does. e.g.
  Add "Print Frame" to the frame flyout of the browser context menu
I'll fix this for you when I check this in.

> r=Philip Chee
Normally avoid adding r= to the patch comment before you actually get a r+ . In this case you might want to use something like:
  r?Foobar

Comment 31

[Philip Chee]

Adding a "checkin-needed" keyword so I won't forget!

Comment 32

[Philip Chee]

I pushed this to comm-central on 15 April but totally forgot to update the bug. Bad Phil, no biscuit
https://hg.mozilla.org/comm-central/rev/375bf886e8e6