141438 - [gmake builds] Entry point not found [Mid@nsAString@@QBEIAAV1@||@Z]- impComm4xMail.dll

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P3)

Description

[Henrik Gemal]

when installing on top of a zip build you get into problems with the file:
impComm4xMail.dll
located in the componenets directory.

?Mid@nsAstring bla bla could not be located...

Dan: could we just add "impComm4xMail.dll" to the list of files to be deleted 
by the installer?

Comment 1

[Henrik Gemal]

*** Bug 141465 has been marked as a duplicate of this bug. ***

Comment 2

[Justin Turner Arthur]

Bug 141465 was marked as a duplicate of this bug however the file that problems
are occuring are different in bug 141465 than this bug. Bug 141465 refers to an
error reported concerning xpcom.dll

Comment 3

[Henrik Gemal]

*** Bug 141465 has been marked as a duplicate of this bug. ***

Comment 4

[Daniel Veditz [:dveditz]]

Entry "poing"? no wonder I couldn't find this one :-)

Comment 5

[R.K.Aa.]

according to bug 141759, both these files are outdated:

impComm4xMail.dll
msgMapi.dll

Comment 6

[R.K.Aa.]

*** Bug 140361 has been marked as a duplicate of this bug. ***

Comment 7

[David A. Cobb]

umm.  I hate to be argumentative, but I don't have a file "impComm4xMail.dll" on
my computer.  AND, to repeat a comment from Bug#140361, this is after a clean
install.

Comment 8

[Leonard Norrgård]

Attachment: The image of the error dialog for the error on xpcom.dll

Me too.  Have got these for a couple of days now... [image of error dialog
attached]

Comment 9

[Nahor]

I got it too. Systematic error when doing "Help | About plugin" on xpcom.dll. I
delete the other dll (impComm4xMail.dll) and I don't have the error anymore.

Comment 10

[R.K.Aa.]

*** Bug 142678 has been marked as a duplicate of this bug. ***

Comment 11

[R.K.Aa.]

*** Bug 142719 has been marked as a duplicate of this bug. ***

Comment 12

[R.K.Aa.]

*** Bug 142720 has been marked as a duplicate of this bug. ***

Comment 13

[R.K.Aa.]

*** Bug 142785 has been marked as a duplicate of this bug. ***

Comment 14

[R.K.Aa.]

*** Bug 142799 has been marked as a duplicate of this bug. ***

Comment 15

[Matthias Versen [:Matti]]

*** Bug 142921 has been marked as a duplicate of this bug. ***

Comment 16

[Geoff King]

deleting impcom4xmail.dll solved the problem for me. 

Comment 17

[Matthias Versen [:Matti]]

*** Bug 143087 has been marked as a duplicate of this bug. ***

Comment 18

[Henrik Gemal]

*** Bug 143435 has been marked as a duplicate of this bug. ***

Comment 19

[Grace Bush]

Curt,
Similar message to bug you just fixed for 6.2 upgrades

Comment 20

[Alec Flett]

actually, isn't impComm4xMail part of the commercial (i.e. Netscape) build? are
you maybe installing this on top of a netscape build? that won't work.

Comment 21

[Matthias Versen [:Matti]]

*** Bug 143417 has been marked as a duplicate of this bug. ***

Comment 22

[Matthias Versen [:Matti]]

*** Bug 144412 has been marked as a duplicate of this bug. ***

Comment 23

[Jonathan Heysek]

installed lastest build (5/15/2002 @ 12:49:00 PM) and get the same error.

Comment 24

[David A. Cobb]

Same bug, new Name:
Build 2002-05-16-08/Win2000pro on first launch after clean install:
XPCOM:EventReceiver:Mozilla.exe Entry point
?AppendFromReadable@nsAString@@IAEXABV1@@Z in xpcom.dll

Warning dialog comes up twice during program loading.

Comment 25

[Daniel Veditz [:dveditz]]

It's *not* the same bug if it's got a different name. By "clean install" do you
mean into a virgin directory? If so even more evidence it's not the same
problem. Please file a separate bug.

"Build 2002-05-16-08/Win2000pro" which build is that "-trunk" or "-1.0.0"? You
cut off perhaps the most important part of the build ID.

Comment 26

[David A. Cobb]

OK, see Bug#145407.  But they sure look like first cousins.

Comment 27

[Henrik Gemal]

Dan: I'm not really sure about the impComm4xMail.dll file.

It's inside the mail.xpi file for Mozilla 1.0 builds but not in the trunk 
build. Couldn't it be removed all together from the build?

http://lxr.mozilla.org/seamonkey/search?string=impComm4xMail
seems to say that it isn't needed...

I really like to get rid of this bug...

Comment 28

[Henrik Gemal]

Attachment: patch to fix entry point

Comment 29

[(not reading, please use [e-mail] instead)]

I'm not sure we can get rid of that dll yet.  srilatha would know for sure.

that's the module that allows you to import 4.x local folders.

Comment 30

[Srilatha Moturi]

Seth is right. We cannot remove impComm4xMail.dll.

Comment 31

[Daniel Veditz [:dveditz]]

It appears not to be on the trunk. We're talking about making the *trunk*
installer delete the file if found, presumably when someone upgrades from the
branch.

Or is the file just not yet added to the trunk? In that case what's the ETA

Comment 32

[Srilatha Moturi]

It is supposed to be on the trunk too. and I see that it is missing in the trunk
builds. I dont see any changes made to the packages file.
http://lxr.mozilla.org/seamonkey/source/xpinstall/packager/packages-win#365

Comment 33

[Srilatha Moturi]

The problem is with the gmake build. In the gmake build the dll is named as 
imp4Mail.dll. The dll is getting the SHORT_LIBNAME not the LIBRARY_NAME
LIBRARY_NAME    = impComm4xMail
SHORT_LIBNAME   = imp4Mail
http://lxr.mozilla.org/seamonkey/source/mailnews/import/comm4x/src/Makefile.in#4
5
mkaply, can we rename SHORT_LIBNAME to be the same as LIBRARY_NAME?
This was added to fix bug 134742.
If we cannot rename the SHORT_LIBNAME then we need to change the makefile.win 
and the packages files so that the dll name is imp4Mail.

Comment 34

[Mike Kaply [:mkaply]]

The Win32 gmake build should not be using SHORT_LIBNAME.

Windows has no requirement that DLLS be 8.3, whereas OS/2 does.

The fix is to remove USE_SHORT_LIBNAME from configure.in for Windows.

Comment 35

[timeless]

ok

Comment 36

[Srilatha Moturi]

Attachment: patch to create dll with name impComm4xMail

Since SHORT_LIBNAME is being define in sevaral files, I think it is better not
to touch configure.in. Instead do not define SHORT_LIBNAME for WINNT in the
import/comm4x makefile

Comment 37

[Mike Kaply [:mkaply]]

Using SHORT_LIBNAME for the Window gmake build is VERY bad.

This means that 20 or so DLLs will have different names between the Windows 
gmake build and the Windows nmake build.

Comment 38

[hacker formerly known as [e-mail]]

And not using SHORT_LIBNAME is equally as bad as there are a number of libraries
that *do* use the 8.3 filename on win32.  Since that 8.3 name is already listed
in the Makefile.ins for OS/2, we set USE_SHORT_LIBNAME for win32 gmake builds
and make ifdef expections where necessary.  I believe we have discussed this before.

Comment 39

[Mike Kaply [:mkaply]]

Duh. (light goes off above mike kaply's head)

Totally agree with the change. Sorry for the confusion.

Comment 40

[Srilatha Moturi]

Chris, can you review the last patch.

Comment 41

[hacker formerly known as [e-mail]]

Comment on attachment 84793 [details] [diff] [review]
patch to create dll with name impComm4xMail

r=cls

Comment 42

[(not reading, please use [e-mail] instead)]

Comment on attachment 84237 [details] [diff] [review]
patch to fix entry point

this first patch is incorrect, we can't delete impComm4xMail.dll

Comment 43

[(not reading, please use [e-mail] instead)]

Comment on attachment 84793 [details] [diff] [review]
patch to create dll with name impComm4xMail

sr=sspitzer

but before you check in, please add to the Makefile.in refering back to this
bug.

# don't define SHORT_LIBNAME on WINNT
# see bug 141438

Comment 44

[(not reading, please use [e-mail] instead)]

on a related note:

do we still support both nmake and gmake builds?
is the eventual plan to only support one (gmake)?

Comment 45

[Srilatha Moturi]

Fix checked in.

Comment 46

[(not reading, please use [e-mail] instead)]

do we want this on the 1.0 branch (after mozilla ships) as well?

or is 1.0 (and netscape 7.0) built with nmake?

Comment 47

[hacker formerly known as [e-mail]]

I think that 1.0 branch builds are being done with nmake but we still want this
on the branch.

Comment 48

[hacker formerly known as [e-mail]]

http://mpt.phrasewise.com/2002/06/07

Comment 49

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 84793 [details] [diff] [review]
patch to create dll with name impComm4xMail

Please land this on the 1.0.1 branch.  Once there, replace the
"mozilla1.0.1+" keyword with the "fixed1.0.1" keyword.

Comment 50

[Grace Bush]

verified code fix