1435134 - The autoscrolling icon and dropdown menus are misplaced after setting browser.tabs.drawInTitlebar back to false without restarting Nightly.

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect)

Description

[Darkspirit]

Debian Testing x64 (KDE, Radeon RX480)

Mozregression:
1. Customize > Enable titlebar.
2. First tab: Click on the select box: Options should appear below it (and not on it).
3. Second tab: Do a middleclick to activate autoscrolling: The autoscrolling icon should appear where my cursor was (and not 1cm above it).

mozregression --good 2018-01-30 --bad 2018-02-01 --pref browser.tabs.drawInTitlebar:true general.autoScroll:true startup.homepage_welcome_url:"https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_option|https://www.mozilla.org/en-US/"
> 11:27.92 INFO: Last good revision: 5a46db143897c53211818c722f15c510dd708c6c
> 11:27.92 INFO: First bad revision: 7d2121c8e0dd75cc48d8021ba55565889da8aac7
> 11:27.92 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5a46db143897c53211818c722f15c510dd708c6c&tochange=7d2121c8e0dd75cc48d8021ba55565889da8aac7

> 4fbda7310828	Martin Stransky — Bug 1417933 - enable CSD titlebar rendering mode as Bug 1424974 regression is fixed, r=jhorak

(I can confirm that my bug 1423810 is fixed.)

Comment 1

[Darkspirit]

Still reproducible.

mozregression --launch 2018-03-07 --pref browser.tabs.drawInTitlebar:true general.autoScroll:true startup.homepage_welcome_url:"https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_option|https://www.mozilla.org/en-US/"

Comment 2

[Martin Stránský [:stransky] (ni? me)]

I'm unable to reproduce, Fedora 27/gnome-shell. Maybe KDE specific?

Comment 3

[Darkspirit]

Attachment: 2018-03-08_13-33-50.mp4

> Maybe KDE specific?
Might be.

It's not restricted to autoscroll.

Comment 4

[Darkspirit]

> It's not restricted to autoscroll.

> 2. First tab: Click on the select box: Options should appear below it (and not on it).
is reproducible with
mozregression --launch 2018-03-07 --pref browser.tabs.drawInTitlebar:true general.autoScroll:false startup.homepage_welcome_url:"https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_option|https://www.mozilla.org/en-US/"

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72144da2637d
Don't play until we've reached metadata. r=bryce

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/72144da2637d

Comment 7

[Martin Stránský [:stransky] (ni? me)]

(In reply to Pulsebot from comment #5)
> Pushed by [e-mail]:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/72144da2637d
> Don't play until we've reached metadata. r=bryce

I believe you resolved wrong bug here ;)

Comment 8

[Natalia Csoregi [:nataliaCs]]

(In reply to Martin Stránský [:stransky] from comment #7)
> (In reply to Pulsebot from comment #5)
> > Pushed by [e-mail]:
> > https://hg.mozilla.org/integration/mozilla-inbound/rev/72144da2637d
> > Don't play until we've reached metadata. r=bryce
> 
> I believe you resolved wrong bug here ;)

As it was merged to central, bugherder marked it as fixed (there was no leave-open tag to it)

Comment 9

[Richard Marti (:Paenglab)]

This bug here has no patch that could land. The check-in had the wrong bug # in the commit message. It should have Bug 1435133.

Comment 10

[Darkspirit]

Dropdown, STR from comment 0:

mozregression --find-fix --bad 2018-04-01 --good 2018-05-01 --pref browser.tabs.drawInTitlebar:true general.autoScroll:true startup.homepage_welcome_url:'https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_option'
> 8:02.54 INFO: First good revision: 9c70604962648780c82ae1a4773b0f249b26863f
> 8:02.54 INFO: Last bad revision: c5afc8caa902b5c213e5c1520c482037f5546e38
> 8:02.54 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c5afc8caa902b5c213e5c1520c482037f5546e38&tochange=9c70604962648780c82ae1a4773b0f249b26863f

> 9c7060496264	Martin Stransky — Bug 1457194 - Label mShell toplevel window so property_notify_event_cb callback can find its way home, r=jhorak
> 921741097e18	Martin Stransky — Bug 1457194 - [Gtk+\CSD] Don't estimate window offset for Gtk+ < 3.20, r=jhorak


Autoscroll icon:

Fixed some of them: bug 1441665, bug 1456898, bug 1457691, bug 1457691, bug 1457763, bug 1457309

Comment 11

[Darkspirit]

*Fixed by some of them