1479309 - Don't load shield-content-frame.js until needed

Status: RESOLVED FIXED

(Firefox :: Normandy Client, enhancement)

Description

[Kris Maglione [:kmag]]

shield-content-frame.js is only needed in content processes when an event received from a shield page. It's only ever really needed when about:studies has been loaded in a process, but the quickest path to getting rid of it it is just loading it when we get a "ShieldPageEvent" event in a frame script.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1479309: Don't load shield-content-frame.js until needed.

Review commit: https://reviewboard.mozilla.org/r/260166/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260166/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8995828 [details]
Bug 1479309: Don't load shield-content-frame.js until needed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260166/diff/1-2/

Comment 3

[Michael Cooper [:mythmon]]

Comment on attachment 8995828 [details]
Bug 1479309: Don't load shield-content-frame.js until needed.

https://reviewboard.mozilla.org/r/260166/#review267386

Thanks!

Also, since this is blocking the memshrink bug, I'm curious if you've profiled how much memory these changes save? If you haven't already profiled it, don't worry about. I'm sure the the changes are worth it, I'm just curious.

Comment 4

[Kris Maglione [:kmag]]

(In reply to Michael Cooper [:mythmon] from comment #3)
> Also, since this is blocking the memshrink bug, I'm curious if you've
> profiled how much memory these changes save? If you haven't already profiled
> it, don't worry about. I'm sure the the changes are worth it, I'm just
> curious.

See whiteboard. According to dominator tree analysis, this frame script uses about 7K in a process with a single tab (more for processes with multiple tabs). In practice, actual savings tend to be slightly more than that tool reports, though.

Comment 5

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d46e1fe31214d36d1e11218deb44423baee2c26
Bug 1479309: Don't load shield-content-frame.js until needed. r=mythmon

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2d46e1fe3121

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/fe6020e5c9d9
Backed out 12 changesets (bug 1479309, bug 1479312, bug 1479313, bug 1479310, bug 1479235, bug 1479945, bug 1479241, bug 1479318) for causing a big performance regression on OS X. a=backout

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out for causing a big performance regression on OS X and as request by igoldan. 

https://hg.mozilla.org/mozilla-central/rev/fe6020e5c9d901a40fa2e7ea2f1ab2a36bf6d856

Comment 9

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a396e7027858121f002ff1544fd28fabe5996685
Bug 1479309: Don't load shield-content-frame.js until needed. r=mythmon

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a396e7027858