1484449 - TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/pref-window/test-font-chooser.js

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/pref-window/test-font-chooser.js | test-font-chooser.js::test_font_name_displayed
TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/pref-window/test-font-chooser.js | test-font-chooser.js::test_font_name_not_present

We've tried to fix this in bug 1399443, bug 1415082, bug 1462920, bug 1460721 and bug 1474862 and it still fails :-(

Comment 1

[:aceman]

I think this is due to Lightning.

While observing the test run, it selects paneDisplay correctly, but then for some reason it switches the pref pane back to paneGeneral. Thus the test can't click the Advanced button it needs to proceed.

The test passes on Linux with Lightning compiled out.

This could be related to bug 1482351, if Lightning does something after the preferences tab was opened and the correct pane is already selected.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1484449-disable-test.patch

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1ccaa358deb4
temporarily disable failing test test-font-chooser.js on Linux. rs=bustage-fix DONTBUILD

Comment 4

[Geoff Lankow (:darktrojan)]

Looks like I caused this with bug 1481941. I think I can use what I'm doing in bug 1482351 to stop this test failing without causing bug 1481941 again.

Comment 5

[Geoff Lankow (:darktrojan)]

Things would probably work a lot better if the preferences tab didn't have two panes selected at once, which it does with or without Lightning enabled.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1484449-pref-tab-startup-1.diff

We are selecting one pane, and as it completes, selecting another. Result: two panes selected where only one should be possible.

I've also removed the code that checks window.arguments for the pane to select, since it isn't used any more.

Comment 7

[:aceman]

Comment on attachment 9002395 [details] [diff] [review]
1484449-pref-tab-startup-1.diff

Review of attachment 9002395 [details] [diff] [review]:
-----------------------------------------------------------------

Nice. I noticed that sometimes 2 labels of pref panes were highlighted. So remnants of the conversion from window to a tab.
Thanks for the cleanup.

Comment 8

[:aceman]

Attachment: 1484449.patch hide Today pane

I also noticed the mozmill tests run in a small TB window (like 800x600) and then the today pane obscures the Advanced button the font test is trying to click. It still magically works (somehow tests can click invisible elements) but is a potential source of problems in future.
I suggest to hide the pane for this test.

Try run with both patches:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7589d55859326bcdf8875011cda89224f0611d2b

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/823b867a58f0
Prevent two panes from being selected at preference tab start-up; remove left-over bits of preference window code. r=aceman

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bbaa786d8616
hide Today pane for font preferences tests. r=darktrojan

Comment 11

[ISHIKAWA, Chiaki (back from day job exhibition event.)]

Attachment: This test got stuck with No active window error and eventually fail.

This bug still occurs locally (full debug build of 64-bit TB under linux) and the error can also be seen
in the tryserver, e.g., Z7 failure of linux64 debug build:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1efef0618b93807f236e72ddfab797b19023b6d1&selectedJob=256145948

I checked the operation locally by running the single test
make mozmill-one SOLO_TEST=pref-window/test-font-chooser.js

and found that there is a strange situation of "No active window" error after the attached image is drawn on the screen. No active window error gets printed many times and then the screen got stuck with the image uploaded here.

Comment 12

[ISHIKAWA, Chiaki (back from day job exhibition event.)]

Attachment: The local log that was recorded when the previously uploaded screen was captured.

(I am not familiar with markup yet.)

I looked at the log from |make mozmill| executed locally and found a few things. I put my comments in the log which is being uploaded. But here are a few things I noticed.
(0) Basically, the test gets stuck with many warnings of the following form, and eventually times out and results in an error.

[22753, Main Thread] WARNING: No active window: file /NREF-COMM-CENTRAL/mozilla/js/xpconnect/src/XPCJSContext.cpp, line 662

(1) SetSpec() is called with unrecognized URI spec. I am not sure if this is relevant.

        {debug} SetSpec failed : aSpec=branding/brand.ftl
        {debug} SetSpec failed : aSpec=messenger/preferences/preferences.ftl
        {debug} SetSpec failed : aSpec=messenger/preferences/fonts.ftl
        {debug} SetSpec failed : aSpec=messenger/preferences/languages.ftl

     See. Bug 1539997
    NS_ERROR_MALFORMED_URI errors seen during |make mozmill| test of FULL DEBUG version of TB
    (The check was removed in M-C for no apparent reason. Very bad.)

(2) TB detects a couple of errors but failed to report that to web console due to an internal error.

Prior to the repeated "No active window" warnings, I see a couple of errors of the following form.

[22753, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /NREF-COMM-CENTRAL/mozilla/dom/base/nsContentUtils.cpp, line 3719
````        <=== This may be a serious problem.
        This NS_ENSURE_SUCCESS() comes from |nsresult nsContentUtils::ReportToConsole()|
        and suggests that TB wanted to report an error to console, but failed due to
        its failure to obtain the localized string bundle or something.
        So, if this error is printed  to the console AND
        if the test is rewritten to open the web console from devtool to show the errors
        then we may know the cause of the failure of the test in more detail.
(Provided this string bundle issue or whatever is solved first. There are two such failed calls in the log. The error may explain why TB test is failing. )

TIA