1490428 - When searching for e-mail address in Gloda, using keyboard to highlight a recommendation and pressing enter does not search for the highlighted item (full address) but the entered partial address

Status: VERIFIED FIXED

(Thunderbird :: Search, defect)

Description

[Aaron]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180621121604

Steps to reproduce:

type start of an email address in the search bar.  I get some suggestions that include the full email address I am searching for.  I use the arrow keys to move down to the suggested email address I want (it is now highlighted in a blue).  I press the ENTER key to select the suggested email address and the search results window pops up but it only searches for the partial email that I had typed in the box.  iT does not search for the full email address that was highlighted blue.   If I click my mouse cursor on the suggested name it will search for the full email address.  


Actual results:

search results tab shows search for the partial email address that i had started typing in the box before the suggestion were listed.


Expected results:

it should have searched for the full email address that was highlighted in blue when I pressed enter key.

Comment 1

[Wayne Mery (:wsmwk)]

It worked differently in version 52?

Comment 2

[Jorg K (CEST = GMT+2)]

Wayne, do this: Using Gloda search, enter an incomplete address. Use the arrow keys to navigate to a suggested address, hit enter. Gloda will now only search for the entered incomplete address, not the full address of the item.

Looks like a regression from the various auto-complete changes we did. And yes, it works correctly in TB 52.

Alice, can you please find the regression for us on Daily.

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=5620690a17267e56e1407ae64294624747701ea1&tochange=91311b1d6aa3bddd427858cb7f8c149a81c71a92
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2c000486eac466da6623e4d7f7f1fd4e318f60e8&tochange=b03d9c87bbf6b9b73883758ce494dd971368b5c9

Suspect:
c0b4ca69376c	Masayuki Nakano — Bug 1434837 - Make autocomplete and satchel listen to keypress event at the system event group r=mak

Comment 4

[Jorg K (CEST = GMT+2)]

Thanks Alice, much appreciated as always!!

Marco and Masayuki-san, where from here? You might be familiar with TB's Gloda search (Ctrl+K) which uses keyboard navigation or clicking. Apparently when using keyboard navigation something has changed in what is accepted.

Alice is almost always right, so how does your change relate to what we're doing? Is there perhaps an option we can set to bring back the old behaviour?

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to Jorg K (GMT+2) from comment #4)

...
Marco and Masayuki-san, where from here? You might be familiar with TB's
Gloda search (Ctrl+K) which uses keyboard navigation or clicking. Apparently
when using keyboard navigation something has changed in what is accepted.

Alice is almost always right, so how does your change relate to what we're
doing? Is there perhaps an option we can set to bring back the old behaviour?

Comment 9

[Jorg K (CEST = GMT+2)]

Seems to work in TB 68. Can someone confirm?

Comment 10

[Kristina Novotna]

(In reply to Jorg K (GMT+2) from comment #9)

Seems to work in TB 68. Can someone confirm?

I tried it in TB68 and it didn't work. Did you select contact by arrow keys and pressing Enter? See the pictures:
https://www.celdy.com/wp-content/uploads/2019/09/Bug1.png
https://www.celdy.com/wp-content/uploads/2019/09/Bug2.png

Comment 11

[Jorg K (CEST = GMT+2)]

Yes, I typed "Bugzilla" into the Ctrl+K searchbox. Three matches came up, I navigated with the arrow keys and then hit enter, which displayed the results. Do you use any add-ons? Can you start with add-ons disabled, see Help menu.

Comment 12

[Kristina Novotna]

(In reply to Jorg K (GMT+2) from comment #11)

Yes, I typed "Bugzilla" into the Ctrl+K searchbox. Three matches came up, I navigated with the arrow keys and then hit enter, which displayed the results. Do you use any add-ons? Can you start with add-ons disabled, see Help menu.

I restarted TB in safe mode with disabled add-ons and it is still happening. TB 68.0, ID 20190826194726, Windows_NT 10.0, Language ["cs"]

Comment 13

[Jorg K (CEST = GMT+2)]

Ben, can you give this a shot.

Comment 14

[Wayne Mery (:wsmwk)]

This does not work consistently

Comment 15

[Jorg K (CEST = GMT+2)]

I'll take another look.

Comment 16

[Boris Kotov]

+1
macOS Mojave
Thunderbird 60.9

Comment 17

[Jorg K (CEST = GMT+2)]

This is actually not the only regression from bug 1434837 (see comment #3). We also fixed bug 1499410 and the messy ESR 60 follow-up in bug 1536374.

The fix is here https://hg.mozilla.org/comm-central/rev/d3daa2594870 changing ontextentered and onkeypress handlers.

Note that for Gloda, those don't exist, not even in ESR 60:
https://dxr.mozilla.org/comm-esr60/source/mail/base/content/specialTabs.xul#54
https://searchfox.org/comm-central/rev/bcf328da9b27554e1f11d5ebf4d6de0c02e5544d/mail/base/content/messenger.xul#716

Sigh, sadly the summary didn't spell out the issue: Navigation and hitting enter works, but when using enter, Gloda returns all matches based on the partial e-mail address entered and not the full address in the suggestion.

Comment 18

[Jorg K (CEST = GMT+2)]

Attachment: 1490428-use-system-group.patch - WIP: not working

OK, so according to bug 1499410 comment #14 we should add {mozSystemGroup: true} to the event listeners ... if only I could find them. I added it in a few places bug that code isn't run since the debug doesn't come out. I guess searchWidgets.js isn't for Gloda anyway. Alex, you've been messing with auto-complete, can you take a look, please. (And you asked to help with regressions. Sadly this is broken since TB 60.)

Is onkeypress still the go? Then we could add it to
https://searchfox.org/comm-central/rev/bcf328da9b27554e1f11d5ebf4d6de0c02e5544d/mail/base/content/messenger.xul#716
to set the search term.

I'm just puzzled that "click" works as expected and "keypress" with enter doesn't. Somewhere there must be a click handler set.

Comment 19

[Jorg K (CEST = GMT+2)]

Attachment: 1490428-use-system-group2.patch

Finally found it. One line. Broken since TB 60 :-(

First reviewer wins. Read bug 1499410 comment #14.

Comment 20

[:aceman]

Comment on attachment 9091315 [details] [diff] [review]
1490428-use-system-group2.patch

Review of attachment 9091315 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, works for me.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1317ce452497
Fix Gloda auto-complete not using suggestion but search string. r=aceman

Comment 22

[Jorg K (CEST = GMT+2)]

TB 70 beta 1:
https://hg.mozilla.org/releases/comm-beta/rev/cdff1c55462feef23806196850ecd15cdda083c0

Comment 23

[Jorg K (CEST = GMT+2)]

Working in the beta.

Comment 24

[Jorg K (CEST = GMT+2)]

TB 68.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/9b09e80788f8f15fb077aa705b218388d461dce6

Comment 25

[Boris Kotov]

I am using 72.0b3 (64-Bit) and this fix is not included, although it was included earlier, please could somebody verify?

Comment 26

[Jorg K (CEST = GMT+2)]

Yes, that broke again :-( - I'll file a new bug.

Comment 27

[Boris Kotov]

Thanks!

Comment 28

[Jorg K (CEST = GMT+2)]

Bug 1608700.