When searching for e-mail address in Gloda, using keyboard to highlight a recommendation and pressing enter does not search for the highlighted item (full address) but the entered partial address
Categories
(Thunderbird :: Search, defect)
Tracking
(thunderbird_esr6869+ fixed, thunderbird70 fixed, thunderbird71 fixed)
People
(Reporter: azuercher, Assigned: jorgk-bmo)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
1.02 KB,
patch
|
aceman
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 8•5 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #4)
...
Marco and Masayuki-san, where from here? You might be familiar with TB's
Gloda search (Ctrl+K) which uses keyboard navigation or clicking. Apparently
when using keyboard navigation something has changed in what is accepted.Alice is almost always right, so how does your change relate to what we're
doing? Is there perhaps an option we can set to bring back the old behaviour?
Assignee | ||
Comment 9•5 years ago
|
||
Seems to work in TB 68. Can someone confirm?
Comment 10•5 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #9)
Seems to work in TB 68. Can someone confirm?
I tried it in TB68 and it didn't work. Did you select contact by arrow keys and pressing Enter? See the pictures:
https://www.celdy.com/wp-content/uploads/2019/09/Bug1.png
https://www.celdy.com/wp-content/uploads/2019/09/Bug2.png
Assignee | ||
Comment 11•5 years ago
|
||
Yes, I typed "Bugzilla" into the Ctrl+K searchbox. Three matches came up, I navigated with the arrow keys and then hit enter, which displayed the results. Do you use any add-ons? Can you start with add-ons disabled, see Help menu.
Comment 12•5 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #11)
Yes, I typed "Bugzilla" into the Ctrl+K searchbox. Three matches came up, I navigated with the arrow keys and then hit enter, which displayed the results. Do you use any add-ons? Can you start with add-ons disabled, see Help menu.
I restarted TB in safe mode with disabled add-ons and it is still happening. TB 68.0, ID 20190826194726, Windows_NT 10.0, Language ["cs"]
Comment 14•5 years ago
|
||
This does not work consistently
Assignee | ||
Comment 15•5 years ago
|
||
I'll take another look.
Comment 16•5 years ago
|
||
+1
macOS Mojave
Thunderbird 60.9
Assignee | ||
Comment 17•5 years ago
|
||
This is actually not the only regression from bug 1434837 (see comment #3). We also fixed bug 1499410 and the messy ESR 60 follow-up in bug 1536374.
The fix is here https://hg.mozilla.org/comm-central/rev/d3daa2594870 changing ontextentered and onkeypress handlers.
Note that for Gloda, those don't exist, not even in ESR 60:
https://dxr.mozilla.org/comm-esr60/source/mail/base/content/specialTabs.xul#54
https://searchfox.org/comm-central/rev/bcf328da9b27554e1f11d5ebf4d6de0c02e5544d/mail/base/content/messenger.xul#716
Sigh, sadly the summary didn't spell out the issue: Navigation and hitting enter works, but when using enter, Gloda returns all matches based on the partial e-mail address entered and not the full address in the suggestion.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 18•5 years ago
|
||
OK, so according to bug 1499410 comment #14 we should add {mozSystemGroup: true}
to the event listeners ... if only I could find them. I added it in a few places bug that code isn't run since the debug doesn't come out. I guess searchWidgets.js isn't for Gloda anyway. Alex, you've been messing with auto-complete, can you take a look, please. (And you asked to help with regressions. Sadly this is broken since TB 60.)
Is onkeypress
still the go? Then we could add it to
https://searchfox.org/comm-central/rev/bcf328da9b27554e1f11d5ebf4d6de0c02e5544d/mail/base/content/messenger.xul#716
to set the search term.
I'm just puzzled that "click" works as expected and "keypress" with enter doesn't. Somewhere there must be a click handler set.
Assignee | ||
Comment 19•5 years ago
|
||
Finally found it. One line. Broken since TB 60 :-(
First reviewer wins. Read bug 1499410 comment #14.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 20•5 years ago
|
||
Comment 21•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1317ce452497
Fix Gloda auto-complete not using suggestion but search string. r=aceman
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 22•5 years ago
|
||
TB 70 beta 1:
https://hg.mozilla.org/releases/comm-beta/rev/cdff1c55462feef23806196850ecd15cdda083c0
Assignee | ||
Comment 24•5 years ago
|
||
TB 68.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/9b09e80788f8f15fb077aa705b218388d461dce6
Comment 25•5 years ago
|
||
I am using 72.0b3 (64-Bit) and this fix is not included, although it was included earlier, please could somebody verify?
Assignee | ||
Comment 26•5 years ago
|
||
Yes, that broke again :-( - I'll file a new bug.
Comment 27•5 years ago
|
||
Thanks!
Assignee | ||
Comment 28•5 years ago
|
||
Description
•