1501991 - Add a sub-panel for Trackers in the control center

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Johann Hofmann [:johannh]]

See https://mozilla.invisionapp.com/share/RHORBWDNX4W#/screens

The "Trackers" section should be updated to allow the user to expand a detailed overview of which trackers were allowed/blocked.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1501991 - Add a sub-panel for Trackers in the control center. r=Ehsan,ewright,Jamie

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f73e25fa0d8c
Add a sub-panel for Trackers in the control center. r=Jamie,Ehsan

Comment 3

[Raul Gurzau (:RaulG)]

Backed out changeset f73e25fa0d8c (bug 1501991) for multiple failures e.g browser_storage_dynamic_windows.js on a CLOSED TREE

Backout link: https://hg.mozilla.org/integration/autoland/rev/112ed7029b78bdeaec3a6a9956cb44460ff7caa1

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=classified&revision=f73e25fa0d8c70b2d5451e922b20d319f2f931a3

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=212181009&repo=autoland&lineNumber=4861

Log snippet: 

[task 2018-11-16T11:24:23.454Z] 11:24:23     INFO - TEST-PASS | devtools/server/tests/browser/browser_storage_dynamic_windows.js | cookies contains data. - 
[task 2018-11-16T11:24:23.455Z] 11:24:23     INFO - Buffered messages finished
[task 2018-11-16T11:24:23.456Z] 11:24:23     INFO - TEST-UNEXPECTED-FAIL | devtools/server/tests/browser/browser_storage_dynamic_windows.js | cookies data is the correct length. - Got 1, expected 2
[task 2018-11-16T11:24:23.457Z] 11:24:23     INFO - Stack trace:
[task 2018-11-16T11:24:23.458Z] 11:24:23     INFO - chrome://mochikit/content/browser-test.js:test_is:1303
[task 2018-11-16T11:24:23.458Z] 11:24:23     INFO - chrome://mochitests/content/browser/devtools/server/tests/browser/browser_storage_dynamic_windows.js:validateStorage:176
[task 2018-11-16T11:24:23.459Z] 11:24:23     INFO - chrome://mochitests/content/browser/devtools/server/tests/browser/browser_storage_dynamic_windows.js:testAddIframe:136
[task 2018-11-16T11:24:23.460Z] 11:24:23     INFO - chrome://mochitests/content/browser/devtools/server/tests/browser/browser_storage_dynamic_windows.js:testStores:102
[task 2018-11-16T11:24:23.461Z] 11:24:23     INFO - chrome://mochitests/content/browser/devtools/server/tests/browser/browser_storage_dynamic_windows.js:null:87
[task 2018-11-16T11:24:23.462Z] 11:24:23     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
[task 2018-11-16T11:24:23.462Z] 11:24:23     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
[task 2018-11-16T11:24:23.463Z] 11:24:23     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:982
[task 2018-11-16T11:24:23.464Z] 11:24:23     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2018-11-16T11:24:23.465Z] 11:24:23     INFO - TEST-PASS | devtools/server/tests/browser/browser_storage_dynamic_windows.js | cookies data contains the key https://sectest1.example.org. - 
[task 2018-11-16T11:24:23.467Z] 11:24:23     INFO - TEST-PASS | devtools/server/tests/browser/browser_storage_dynamic_windows.js | cookies[https://sectest1.example.org] contains "cs2{9d414cc5-8319-0a04-0586-c0a6ae01670a}.example.org{9d414cc5-8319-0a04-0586-c0a6ae01670a}/". - 
[task 2018-11-16T11:24:23.468Z] 11:24:23     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-11-16T11:24:23.470Z] 11:24:23     INFO - TEST-UNEXPECTED-FAIL | devtools/server/tests/browser/browser_storage_dynamic_windows.js | cookies[https://sectest1.example.org] contains "sc1{9d414cc5-8319-0a04-0586-c0a6ae01670a}sectest1.example.org{9d414cc5-8319-0a04-0586-c0a6ae01670a}/browser/devtools/server/tests/browser/". - 
[task 2018-11-16T11:24:23.471Z] 11:24:23     INFO - Stack trace:
[task 2018-11-16T11:24:23.472Z] 11:24:23     INFO - chrome://mochikit/content/browser-test.js:test_ok:1292
[task 2018-11-16T11:24:23.473Z] 11:24:23     INFO - chrome://mochitests/content/browser/devtools/server/tests/browser/browser_storage_dynamic_windows.js:validateStorage:182
[task 2018-11-16T11:24:23.474Z] 11:24:23     INFO - chrome://mochitests/content/browser/devtools/server/tests/browser/browser_storage_dynamic_windows.js:testAddIframe:136
[task 2018-11-16T11:24:23.476Z] 11:24:23     INFO - chrome://mochitests/content/browser/devtools/server/tests/browser/browser_storage_dynamic_windows.js:testStores:102
[task 2018-11-16T11:24:23.478Z] 11:24:23     INFO - chrome://mochitests/content/browser/devtools/server/tests/browser/browser_storage_dynamic_windows.js:null:87
[task 2018-11-16T11:24:23.480Z] 11:24:23     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
[task 2018-11-16T11:24:23.480Z] 11:24:23     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
[task 2018-11-16T11:24:23.481Z] 11:24:23     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:982
[task 2018-11-16T11:24:23.482Z] 11:24:23     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2018-11-16T11:24:23.482Z] 11:24:23     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-11-16T11:24:23.483Z] 11:24:23     INFO - TEST-UNEXPECTED-FAIL | devtools/server/tests/browser/browser_storage_dynamic_windows.js | cookies data contains the key http://sectest1.example.org. - 
[task 2018-11-16T11:24:23.484Z] 11:24:23     INFO - Stack trace:
[task 2018-11-16T11:24:23.485Z] 11:24:23     INFO - chrome://mochikit/content/browser-test.js:test_ok:1292
[task 2018-11-16T11:24:23.486Z] 11:24:23     INFO - chrome://mochitests/content/browser/devtools/server/tests/browser/browser_storage_dynamic_windows.js:validateStorage:179
[task 2018-11-16T11:24:23.486Z] 11:24:23     INFO - chrome://mochitests/content/browser/devtools/server/tests/browser/browser_storage_dynamic_windows.js:testAddIframe:136
[task 2018-11-16T11:24:23.487Z] 11:24:23     INFO - chrome://mochitests/content/browser/devtools/server/tests/browser/browser_storage_dynamic_windows.js:testStores:102
[task 2018-11-16T11:24:23.487Z] 11:24:23     INFO - chrome://mochitests/content/browser/devtools/server/tests/browser/browser_storage_dynamic_windows.js:null:87
[task 2018-11-16T11:24:23.488Z] 11:24:23     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
[task 2018-11-16T11:24:23.489Z] 11:24:23     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
[task 2018-11-16T11:24:23.490Z] 11:24:23     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:982
[task 2018-11-16T11:24:23.490Z] 11:24:23     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2018-11-16T11:24:23.491Z] 11:24:23     INFO - Not taking screenshot here: see the one that was previously logged

Comment 4

[Johann Hofmann [:johannh]]

I don't understand. All these failures make no sense to me, I can't reproduce a single one of them locally. I had a green try run before checkin and I just ran a complete try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d20a5c1da309dcd4f4c1ccd1bc5fd027155c52d

It's as green as it can get. I don't think the patch is at fault here. I'm going to try and check in again.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb21007e7da0
Add a sub-panel for Trackers in the control center. r=Jamie,Ehsan

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b51cc7acba5
Backed out changeset eb21007e7da0 for geckoview failures on several tests.

Comment 7

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=geckoview&fromchange=3a993e60513ec57eecb4be86c14f9d2303dfc04b&tochange=2b51cc7acba5fdac3642d3972e489d297bc608c2&selectedJob=212335396

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=212335396&repo=autoland&lineNumber=2927

Backout link: https://hg.mozilla.org/integration/autoland/rev/2b51cc7acba5fdac3642d3972e489d297bc608c2

[task 2018-11-16T23:58:31.525Z] 23:58:31     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS_CODE: -2
[task 2018-11-16T23:58:31.526Z] 23:58:31  WARNING -  TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.NavigationDelegateTest.safebrowsingHarmful | status -2
[task 2018-11-16T23:58:31.526Z] 23:58:31     INFO -  TEST-INFO took 8929ms
[task 2018-11-16T23:58:31.592Z] 23:58:31     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
[task 2018-11-16T23:58:31.593Z] 23:58:31     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: current=95
[task 2018-11-16T23:58:31.593Z] 23:58:31     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: class=org.mozilla.geckoview.test.NavigationDelegateTest
[task 2018-11-16T23:58:31.594Z] 23:58:31     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: stream=
[task 2018-11-16T23:58:31.594Z] 23:58:31     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: numtests=181
[task 2018-11-16T23:58:31.595Z] 23:58:31     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: test=safebrowsingMalware
[task 2018-11-16T23:58:31.595Z] 23:58:31     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS_CODE: 1

I don't see a direct connection here but by looking at these tests they started permafailing after this patch landed. The weird thing is that I checked the try push and they were green and these tests were successful.

Comment 8

[Cosmin Sabou [:CosminS]]

Here is an example of a browser chrome failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux64-asan%2Fopt-mochitest-browser-chrome-e10s-15%2Cm-e10s%28bc15%29&fromchange=563e860bea95f6696ac5a90c0e7b35b7874a4184&selectedJob=212339917

Comment 9

[Johann Hofmann [:johannh]]

Might be there's an issue with the binary files and phabricator/lando, I thought it was only on Windows and fixed, but let me try to re-land via inbound...

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b5f41cdab35
Add a sub-panel for Trackers in the control center. r=Ehsan,Jamie

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8b5f41cdab35

Comment 12

[Johann Hofmann [:johannh]]

Mark, can you take a look at this? Landing this patch via Lando caused all sorts of test failures because it contained binary files. Landing on inbound worked fine. My impression was that this should be fixed.

Thanks!

Comment 13

[Mark Côté [:mcote]]

Thanks, I reopened bug 1486026 and we'll investigate there.  Sorry for the inconvenience!

Comment 14

[David Olah]

Verified on Windows 10, Ubuntu 18, Mac OS, on Nightly 65.0a1 (2018-11-27).