1531596 - [Context Menu] Bookmarked or Save to Pocket story loses Remove Bookmark or Archive/Delete From Pocket on browser restart

Status: NEW

(Firefox :: Pocket, enhancement, P2)

Description

[Punam Dahiya [:pdahiya]]

This issue exists in default activity stream and can be replicated with steps below:

1. Hide Highlights section from about:preferences
2. Bookmark a story
3. Context Menu option changes to Remove Bookmark
4. Restart browser

Context Menu option of the previously bookmarked user story changes back to 'Bookmark'.

Comment 1

[Punam Dahiya [:pdahiya]]

With bug 1527500, we are bringing bookmark menu option for pocket new tab. Existing implementation has similar issue as in original description of this bug
a) On restart of browser, Remove bookmark state is lost for previously bookmarked stories
b) Attempt to re-bookmark, previously bookmarked story doesn't change 'Bookmark' to 'Remove Bookmark' state.

Following up with Marco from places team for fix of b), findings are Firefox bookmarking system allows for duplicate bookmarks and doesn't prevent nor notify about that. It's the caller's responsibility to handle that case.

https://gist.github.com/punamdahiya/a78acea2b3095f91e447fbbdd3b806a9 shows suggested fix for b)

While implementing rebookmark support, we should ensure a story shows up in highlights once we bring in Highlights section in pocket new tab.

As discussed here https://github.com/mozilla/activity-stream/pull/4863#discussion_r269760416, changing the scope of this bug to discuss with design and look into best approach to fix bookmark on browser restart.

Comment 2

[Wolasi :wolasi]

Given the effort required to fix this, and the fact that the same issue exists on the original New Tab, let's move this to v69.

Comment 3

[Punam Dahiya [:pdahiya]]

In DS New Tab, with highlights section implemented with bug https://bugzilla.mozilla.org/show_bug.cgi?id=1536285, one fix of this issue is to move bookmarked story to highlight on opening new tab, refresh or browser restart as done in AS. See https://bugzilla.mozilla.org/show_bug.cgi?id=1559552#c2

Comment 4

[Florencia Di Ciocco, NI to vbalducci]

Attachment: Highlight.mp4

Hi, I found the same behaviour when saving to pocket on Nightly 73 on ubuntu 18.04.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Change the status for beta to have the same as nightly and release.
For more information, please visit auto_nag documentation.