Closed Bug 1541799 Opened 7 months ago Closed 7 months ago

Use :root instead of #main-window in browser/themes/shared/controlcenter/panel.inc.css

Categories

(Firefox :: Theme, task, P3)

task

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: dao, Assigned: aqadri, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1292878 +++

:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.

In browser/themes/shared/controlcenter/panel.inc.css there are currently two selectors that should use :root instead of #main-window.

Hi Dão, Can I please take this?

Sure!

Assignee: nobody → asra.qadri

(In reply to Dão Gottwald [::dao] from comment #2)

Sure!

Thanks :)

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99396e1af85f
Use :root instead of #main-window in browser/themes/shared/controlcenter/panel.inc.css r=dao
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Type: defect → task
See Also: → 1542187
See Also: → 1543043
See Also: → 1544680
See Also: → 1554609
See Also: → 1561552
You need to log in before you can comment on or make changes to this bug.