1541799 - Use :root instead of #main-window in browser/themes/shared/controlcenter/panel.inc.css

Status: RESOLVED FIXED

(Firefox :: Theme, task, P3)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1292878 +++

:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.

In browser/themes/shared/controlcenter/panel.inc.css there are currently two selectors that should use :root instead of #main-window.

Comment 1

[Asra Q [:aqadri]]

Hi Dão, Can I please take this?

Comment 2

[Dão Gottwald [:dao]]

Sure!

Comment 3

[Asra Q [:aqadri]]

(In reply to Dão Gottwald [::dao] from comment #2)

Sure!

Thanks :)

Comment 4

[Asra Q [:aqadri]]

Attachment: Bug 1541799: Use :root instead of #main-window in browser/themes/shared/controlcenter/panel.inc.css r=dao

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99396e1af85f
Use :root instead of #main-window in browser/themes/shared/controlcenter/panel.inc.css r=dao

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/99396e1af85f