Closed Bug 1543043 Opened 6 years ago Closed 6 years ago

Use :root instead of #main-window in customizeMode.inc.css

Categories

(Firefox :: Theme, task, P3)

Product:
Firefox
Component:
Theme
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: dao, Assigned: arpitbharti73, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(1 file)

Bug 1543043 - Changed #main-window to :root
47 bytes, text/x-phabricator-request
Details | Review

+++ This bug was initially created as a clone of Bug #1542187 +++

:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.

In browser/themes/shared/customizableui/customizeMode.inc.css there's currently one selector that should use :root instead of #main-window.

Type: defect → task
Assignee: nobody → arpitbharti73
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/adc32d869e58 Changed #main-window to :root r=dao

https://hg.mozilla.org/mozilla-central/rev/adc32d869e58

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
See Also: → 1544680
See Also: → 1554609
See Also: → 1561552
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: