1554609 - Use :root instead of #main-window in panelUI.inc.css

Status: RESOLVED FIXED

(Firefox :: Theme, task, P3)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1544680 +++

:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.

In browser/themes/shared/customizableui/panelUI.inc.css there is currently one selector that should use :root instead of #main-window.

Comment 1

[Ali Abdoli]

Hi, Can I fix this?

Comment 2

[Dão Gottwald [:dao]]

(In reply to Ali Abdoli from comment #1)

Hi, Can I fix this?

Sure! Do you have the source code? Have you built Firefox yet? Let me know if you have questions.

Comment 3

[Ali Abdoli]

Yes! I have built Firefox, and I believe fixed the issue. I am uncertain as to the steps to create a pull request. Do you have a link I can look at?

Comment 4

[Dão Gottwald [:dao]]

(In reply to Ali Abdoli from comment #3)

Yes! I have built Firefox, and I believe fixed the issue. I am uncertain as to the steps to create a pull request. Do you have a link I can look at?

Here you are:

https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#setting-up-arcanist

https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#submitting-patches

Comment 5

[Ali Abdoli]

Attachment: Bug 1554609 - Change #main-window to :root

:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.
Changed #main-window to :root in browser/themes/shared/customizableui/panelUI.inc.css

Comment 6

[Dão Gottwald [:dao]]

It looks like this patch doesn't have proper author information so I can't land it via Lando. Did you use the phabricator web UI to submit the patch? Or did you not set your email in your .hgrc file? See: https://wiki.mozilla.org/Phabricator/FAQ#Lando_says_.22This_diff_does_not_have_the_proper_author_information_uploaded_to_Phabricator.22.2C_but_I_see_an_author_on_Phabricator._What.27s_wrong.3F

Comment 7

[paulflaherty5]

i would like more infromation please can you clarify so i can help fix the issue

Comment 8

[paulflaherty5]

ok

Comment 9

[Dão Gottwald [:dao]]

How exactly did you submit the patch to phabricator?

Comment 10

[Ali Abdoli]

I used arc diff. I think the email was wrong but should be fixed now.

Comment 11

[Dão Gottwald [:dao]]

Still doesn't seem to work. Instead of updating the previous patch, can you submit a completely new one?

Comment 12

[Ali Abdoli]

Attachment: Bug 1554609 - Change #main-window to :root

:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.
Changed #main-window to :root in browser/themes/shared/customizableui/panelUI.inc.css

Comment 13

[Dão Gottwald [:dao]]

Still broken :(

Comment 14

[Ali Abdoli]

Alright I have finally fixed it. had to run "hg ci --amend --user "fName lName <[e-mail]>""

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef089446cb86
Change #main-window to :root r=dao

Comment 16

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/ef089446cb86