Closed Bug 1554609 Opened 3 years ago Closed 3 years ago

Use :root instead of #main-window in panelUI.inc.css

Categories

(Firefox :: Theme, task, P3)

task

Tracking

()

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: dao, Assigned: xXAligatorXx, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1544680 +++

:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.

In browser/themes/shared/customizableui/panelUI.inc.css there is currently one selector that should use :root instead of #main-window.

Hi, Can I fix this?

(In reply to Ali Abdoli from comment #1)

Hi, Can I fix this?

Sure! Do you have the source code? Have you built Firefox yet? Let me know if you have questions.

Yes! I have built Firefox, and I believe fixed the issue. I am uncertain as to the steps to create a pull request. Do you have a link I can look at?

(In reply to Ali Abdoli from comment #3)

Yes! I have built Firefox, and I believe fixed the issue. I am uncertain as to the steps to create a pull request. Do you have a link I can look at?

Here you are:

https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#setting-up-arcanist

https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#submitting-patches

:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.
Changed #main-window to :root in browser/themes/shared/customizableui/panelUI.inc.css

Attachment #9072910 - Attachment description: Change #main-window to :root → Bug 1554609 - Change #main-window to :root

It looks like this patch doesn't have proper author information so I can't land it via Lando. Did you use the phabricator web UI to submit the patch? Or did you not set your email in your .hgrc file? See: https://wiki.mozilla.org/Phabricator/FAQ#Lando_says_.22This_diff_does_not_have_the_proper_author_information_uploaded_to_Phabricator.22.2C_but_I_see_an_author_on_Phabricator._What.27s_wrong.3F

i would like more infromation please can you clarify so i can help fix the issue

Flags: needinfo?(dao+bmo)

ok

How exactly did you submit the patch to phabricator?

Flags: needinfo?(dao+bmo)

I used arc diff. I think the email was wrong but should be fixed now.

Still doesn't seem to work. Instead of updating the previous patch, can you submit a completely new one?

:root is potentially cheaper than #main-window, because IDs aren't actually guaranteed to be unique, so ID selectors are treated just like class selectors under the hood.
Changed #main-window to :root in browser/themes/shared/customizableui/panelUI.inc.css

Attachment #9072924 - Attachment description: Change #main-window to :root → Bug 1554609 - Change #main-window to :root

Still broken :(

Alright I have finally fixed it. had to run "hg ci --amend --user "fName lName <email@email.com>""

Assignee: nobody → xXAligatorXx
Attachment #9072910 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Blocks: 1561552
No longer blocks: 1561552
See Also: → 1561552
You need to log in before you can comment on or make changes to this bug.