1560520 - Text animation is choppy with webrender enabled because of texture cache polution

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Timea Cernea [:tbabos][inactive]]

Affected versions
Nightly 69.0a1 (2019-06-20)

Affected platforms
Windows 10 - Intel graphics card - Webrender ON

Steps to reproduce

• Launch Firefox
• Go to https://developer.microsoft.com/en-us/microsoft-edge/testdrive/demos/variable-fonts/
• Scroll down to the "A single font" animated text

Expected result
The text animation should be smooth as on Firefox with webrender disabled

Actual Result
Text animation is choppy, not as smooth with webrender enabled, check the recording: https://streamable.com/ig5oh

Comment 1

[Mayank Bansal]

Profile: https://perfht.ml/2FlHUE8

Comment 2

[Jeff Muizelaar [:jrmuizel]]

It looks like this might be a texture upload problem. The profile is a bit difficult to interpret.

Timea, do you only see this problem on Intel?

Comment 3

[Timea Cernea [:tbabos][inactive]]

Yes, this is reproducible on Intel graphics cards:

• Intel(R) HD Graphics 4600
• Intel(R) UHD Graphics 620

Will check it on AMD and NVIDIA cards too.

Comment 4

[Timea Cernea [:tbabos][inactive]]

Also reproducible on:

• AMD RX 550
• Nvidia Ge Force GT 730 - the animation is not loaded at all

Not reproducible on:

• Nvidia GeForce GT 1030

Comment 5

[Peter Magyari (Desktop QA)]

This issue is also reproducible on Firefox 68.0b13 (20190624133534) with AMD R7 360 and AMD Rx 550

Comment 6

[Jeff Muizelaar [:jrmuizel]]

(In reply to Timea Babos from comment #4)

Also reproducible on:

• AMD RX 550
• Nvidia Ge Force GT 730 - the animation is not loaded at all

Can you file a separate bug for the animation not loading on the GT 730?

Comment 7

[Timea Cernea [:tbabos][inactive]]

Yes, my colleague with that NVIDIA card submitted Bug 1561914.

Comment 8

[Miko Mynttinen]

This is also choppy on MBP with external 4K monitor. The profile shows that composites are taking between 30-40ms: https://perfht.ml/2IRTSrm.

Comment 9

[Jessie [:jbonisteel] pls NI]

Hey Lee - could you take a look at this bug please?

Comment 10

[Lee Salzman [:lsalzman]]

The example shows an animated variation font, which means we have no choice but to re-rasterize the font every time the variation values change, since it is essentially a different ScaledFont we're working with every frame, same as Gecko would see. The glyphs in question are also extremely big, both of which are working against this.

Dzmitry, is there anything obvious we could do to make the upload suck less here?

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Turning on the texture cache debugging makes what I think is the problem more obvious. We're basically just blowing up the texture cache a whole bunch.

Comment 12

[Dzmitry Malyshau [:kvark]]

For bulk upload speed on Windows, I don't think there are any immediate plans to make it better. For upload on macs, swizzling would help - bug 1548339

For Jeff's observation (if it's not about swizzling at all) - sounds like we should tweak the eviction policy for re-rasterized glyphs.

Comment 13

[Lee Salzman [:lsalzman]]

Attachment: Bug 1560520 - limit the size of WebRender's glyph cache. r?kvark

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca1ff794e472
limit the size of WebRender's glyph cache. r=kvark

Comment 15

[Cristina Coroiu [:ccoroiu]]

Backed out changeset ca1ff794e472 (bug 1560520) for build bustage and wrench

Backout: https://hg.mozilla.org/integration/autoland/rev/6b0dafb0fb9d408a6367ecf2c44799a9464e77ba

Failure push; https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ca1ff794e472f28f0f65cd93af158957c112dc62

Failure logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=256975344&repo=autoland&lineNumber=1079

https://treeherder.mozilla.org/logviewer.html#?job_id=256975280&repo=autoland

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2f7f31d6781
limit the size of WebRender's glyph cache. r=kvark

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for wrench bustage: https://hg.mozilla.org/integration/autoland/rev/b2f7f31d6781e963027db2a9443ada00143f0774

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7596163c881a
limit the size of WebRender's glyph cache. r=kvark

Comment 19

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66e163051112
Backed out changeset b2f7f31d6781 for wrench bustage. CLOSED TREE

Comment 20

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7596163c881a

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider uplifting to Beta for Fx69?

Comment 22

[Lee Salzman [:lsalzman]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #21)

Is this something we should consider uplifting to Beta for Fx69?

Yes. Just want to let it simmer on nightly a couple of days before we uplift.

Comment 23

[Lee Salzman [:lsalzman]]

Comment on attachment 9077928 [details]
Bug 1560520 - limit the size of WebRender's glyph cache. r?kvark

Beta/Release Uplift Approval Request

• User impact if declined: Jank when using pages with animated text or lots of different fonts.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Lowers memory usage of WR glyph cache to be more in line with the non-WR path, but should not otherwise change semantics of how text is rendered.
• String changes made/needed:

Comment 24

[Timea Cernea [:tbabos][inactive]]

Verified - fixed on latest Nightly 70.0a1 (2019-07-22) (64-bit) on Windows 10 with the following cards:

• AMD RX550
• Intel Intel(R) HD Graphics 4600
• GeForce GT 730

Waiting for uplift to Beta.

Comment 25

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9077928 [details]
Bug 1560520 - limit the size of WebRender's glyph cache. r?kvark

Fixes a WR memory usage regression which can cause jank when using pages with animated text or lots of different fonts. Verified by QA on Nightly. Approved for 69.0b8.

Comment 26

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/472132eeee82

Comment 27

[Timea Cernea [:tbabos][inactive]]

Verified - fixed on latest Beta 69.0b8 (64-bit) on Windows 10 with the following cards:

AMD RX550
Intel Intel(R) HD Graphics 4600
GeForce GT 730

Comment 28

[Timea Cernea [:tbabos][inactive]]

Hey Jeff,

We could reproduce this issue again on latest Nightly, Beta and Release on Windows with Intel, AMD and Nvidia cards. (force enbled webrender)
Now it affects all the font animations, here is a reduced testcase where it is clearly visible: https://codepen.io/MSEdgeDev/pen/mxeOGW

Disabling WebRender will solve the issue.
Should we submit a new issue or re-open this one?

Comment 29

[Jeff Muizelaar [:jrmuizel]]

Please open a new bug and ideally find a regression window for when things got worse again.

Comment 30

[Timea Cernea [:tbabos][inactive]]

Submitted Bug 1596460 with additional info. Thanks!

Comment 31

[Markus Stange [:mstange]]

Attachment: testcase

The original URL is gone, but luckily the demos were open sourced on github, so there's a copy at https://github.com/MicrosoftEdge/Demos/blob/master/variable-fonts/index.html . It's missing the fonts though, so I had to find the decovar font separately and put it in the right place.
In this testcase I've set the font size to 159px, because otherwise we hit the 320 limit on @2x HiDPI and rasterize the font as blobs rather than glyphs.