1577117 - command line argument "attachment" (of command "-compose") is not working

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[klaus.riech]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

I sent a windows shell command (to be precise using the VBA command "shell"):
C:\Program Files (x86)\Mozilla Thunderbird\Thunderbird.exe -compose "to='[e-mail]',cc='',subject='mysubject',body='Dear Mr Test',attachment='C:\test.txt' "

Actual results:

Thunderbird opens. A new Mail is created.
The Mail is completely empty, no TO, not SUBJECT, no BODY - and nothing attached.

If I remove the command line argument "attachment". The Mail opens perfectly normal with TO, SUBJECT and BODY.

Expected results:

The Mail should have been created with TO ("[e-mail]"), SUBJECT ("mysubject"), BODY ("Dear Mr Test") and the file "test.txt" attached to it.

Comment 1

[Wayne Mery (:wsmwk)]

Thanks for filing the bug

Comment 2

[Magnus Melin [:mkmelin]]

Hmm. Apparently because Cc["@mozilla.org/toolkit/command-line;1"] is gone.

Comment 3

[Jorg K (CEST = GMT+2)]

Sigh, we use:
let commandLine = Cc["@mozilla.org/toolkit/command-line;1"]
https://searchfox.org/comm-central/rev/753e6d9df9d7b9a989d735b01c8b280eef388bab/mail/components/compose/content/MsgComposeCommands.js#2676

And that XPCOM API has disappeared from M-C in bug 1491560: https://hg.mozilla.org/mozilla-central/rev/7a4dadc9c3e6

So we need to restore this.

Comment 4

[Jorg K (CEST = GMT+2)]

This will do it: Cu.createCommandLine().
EDIT: From https://hg.mozilla.org/mozilla-central/rev/7a4dadc9c3e6#l3.12

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1577117-command-line.patch

Works fine locally, I used:
thunderbird.exe -compose "to=[e-mail],subject=mysubject,body='Dear Mr Test',attachment=D:\Desktop\BVG-Preise-2016.pdf "

Comment 6

[Jorg K (CEST = GMT+2)]

TB 68.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/6abdadcb296d084759a5596380010bacdf0027d7

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bcc11bb0ae6c
create command line via Cu.createCommandLine() after bug 1491560. r=me

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9088694 [details] [diff] [review]
1577117-command-line.patch

Review of attachment 9088694 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

Comment 9

[Magnus Melin [:mkmelin]]

Related to this, I think it was unnoticed because at https://searchfox.org/comm-central/rev/753e6d9df9d7b9a989d735b01c8b280eef388bab/mail/components/compose/content/MsgComposeCommands.js#3047 we don't really get a prompt, only the "Cannot call openModalWindow on a hidden window" error.

Comment 10

[Jorg K (CEST = GMT+2)]

Hmm, well, no one uses -compose " ... attachment= ..." on Daily or Beta. I tried in on 68.1, works fine again.
EDIT: I see, you mean the debug console doesn't show it. Right.