1726280 - Exception in call to nsIEditor.getInlineSpellChecker prevents onBeforeSend listeners working properly

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect, P1)

Description

[Geoff Lankow (:darktrojan)]

With no dictionaries, calling GetCurrentEditor().getInlineSpellChecker(true) in updateEditableFields throws an exception. I don't think it's supposed to but let's catch the exception and carry on with life.

This is a separate bug from the reported crashes and hangs because neither of these things happen. Not to me anyway.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1726280 - Catch exception in call to nsIEditor.getInlineSpellChecker. r=john.bieling

This exception's preventing everything beyond it from running. I don't think it's supposed to throw but it is, so let's catch the exception.

Tested by removing the dictionary from a build and running browser_ext_compose_onBeforeSend.js.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2ad3231a1fca
Catch exception in call to nsIEditor.getInlineSpellChecker. r=john.bieling

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9236761 [details]
Bug 1726280 - Catch exception in call to nsIEditor.getInlineSpellChecker. r=john.bieling

[Approval Request Comment]
Regression caused by (bug #): bug 1695923, maybe, could be something else
User impact if declined: some types of extensions + no dictionaries installed = unable to send mail
Testing completed (on c-c, etc.): landed last week
Risk to taking this patch (and alternatives if risky): no, it's just a try/catch block

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9236761 [details]
Bug 1726280 - Catch exception in call to nsIEditor.getInlineSpellChecker. r=john.bieling

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 92.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/de92c21f512b

Comment 6

[John Bieling (:TbSync)]

This is desperately needed on ESR. Geoff, could you request uplift?

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9236761 [details]
Bug 1726280 - Catch exception in call to nsIEditor.getInlineSpellChecker. r=john.bieling

[Approval Request Comment]
Regression caused by (bug #): bug 1695923, maybe, could be something else
User impact if declined: some types of extensions + no dictionaries installed = unable to send mail
Testing completed (on c-c, etc.): landed last week
Risk to taking this patch (and alternatives if risky): no, it's just a try/catch block

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9236761 [details]
Bug 1726280 - Catch exception in call to nsIEditor.getInlineSpellChecker. r=john.bieling

[Triage Comment]
Approved for esr91

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 91.1.0:
https://hg.mozilla.org/releases/comm-esr91/rev/c9e95cf5ff57