[meta] Ignore autocomplete="off" in address autofill
Categories
(Toolkit :: Form Autofill, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: tgiles, Assigned: tgiles)
References
(Depends on 4 open bugs, Blocks 1 open bug, Regressed 1 open bug)
Details
(Keywords: meta, Whiteboard: [fxcm-quality-compat-form-autofill] )
Attachments
(1 file, 1 obsolete file)
Recently we've had a number of bugs filed due to address autofill not working as expected on certain sites. Something in common with all these sites is that certain fields have their autocomplete attribute set to "off". With our credit card autofill, we ignore autocomplete="off" for the user's benefit. Chrome also ignores autocomplete="off" for both credit card and address autofill for the user's benefit.
We should consider the pros and cons of ignoring when an autocomplete attribute is set to "off"
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
When using getInfo of FormAutofillHeuristics, we will now ignore the case
where autocomplete=off so that users can autofill addresses as expected.
This change affects both credit card autofill and address autofill,
but we already had an exception for credit card autofill.
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 2•2 years ago
|
||
This fixes the aliexpress case and other cases that I am unaware of.
I'm not entirely sure if this should be a separate bug or not, happy to
split this out if that makes the patch easier to keep track of.
Depends on D145916
|
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
|
||
Comment 3•2 years ago
|
||
Comment on attachment 9275764 [details]
Bug 1754879 - Use element's placeholder as a heuristic when trying to match field type. r=sgalich!,dimi!
Revision D145917 was moved to bug 1768642. Setting attachment 9275764 [details] to obsolete.
Pushed by tgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4459dc0bd90d Ignore autocomplete=off in Form Autofill. r=sgalich,dimi
Pushed by imoraru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eea89e415937 fix file-whitespace lint failures on autocomplete_off_on_inputs.html. r=fix
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4459dc0bd90d
https://hg.mozilla.org/mozilla-central/rev/eea89e415937
|
||
Updated•2 years ago
|
Description
•