Closed Bug 1754879 Opened 5 months ago Closed 2 months ago

[meta] Ignore autocomplete="off" in address autofill

Categories

(Toolkit :: Form Autofill, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: tgiles, Assigned: tgiles)

References

(Depends on 5 open bugs, Blocks 6 open bugs)

Details

(Keywords: meta, Whiteboard: [fxcm-quality-compat-form-autofill] )

Attachments

(1 file, 1 obsolete file)

Recently we've had a number of bugs filed due to address autofill not working as expected on certain sites. Something in common with all these sites is that certain fields have their autocomplete attribute set to "off". With our credit card autofill, we ignore autocomplete="off" for the user's benefit. Chrome also ignores autocomplete="off" for both credit card and address autofill for the user's benefit.

We should consider the pros and cons of ignoring when an autocomplete attribute is set to "off"

Blocks: 1755681
Depends on: 1755703
Depends on: 1755634
Depends on: 1755915
Depends on: 1755920
Depends on: 1755927
Depends on: 1758102
Blocks: 1753647
Blocks: 1751159
Whiteboard: [fxcm-quality-compat-form-autofill]

When using getInfo of FormAutofillHeuristics, we will now ignore the case
where autocomplete=off so that users can autofill addresses as expected.
This change affects both credit card autofill and address autofill,
but we already had an exception for credit card autofill.

Assignee: nobody → tgiles
Status: NEW → ASSIGNED

This fixes the aliexpress case and other cases that I am unaware of.
I'm not entirely sure if this should be a separate bug or not, happy to
split this out if that makes the patch easier to keep track of.

Depends on D145916

Attachment #9275763 - Attachment description: Bug 1754879 - Ignore autocomplete=off in Form Autofill. r=sgalich,dimi → Bug 1754879 - Ignore autocomplete=off in Form Autofill. r=sgalich!,dimi!
Attachment #9275764 - Attachment description: Bug 1754879 - Use element's placeholder as a heuristic when trying to match field type. r=sgalich,dimi → Bug 1754879 - Use element's placeholder as a heuristic when trying to match field type. r=sgalich!,dimi!

Comment on attachment 9275764 [details]
Bug 1754879 - Use element's placeholder as a heuristic when trying to match field type. r=sgalich!,dimi!

Revision D145917 was moved to bug 1768642. Setting attachment 9275764 [details] to obsolete.

Attachment #9275764 - Attachment is obsolete: true
Depends on: 1769229
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4459dc0bd90d
Ignore autocomplete=off in Form Autofill. r=sgalich,dimi
Pushed by imoraru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eea89e415937
fix file-whitespace lint failures on autocomplete_off_on_inputs.html. r=fix
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
Depends on: 1775458
You need to log in before you can comment on or make changes to this bug.