1774799 - Library automatically adjusts scroll position to selected bookmark/history item upon refocus

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[aoia7rz7l]

Just noticed this on 101.0.1 when I was trying to organize my bookmarks.

STR:

1. (Depending on your screen resolution) create enough bookmark/history items in the same folder in the Library (around 50 to 100 should do).

2. Navigate to that specific folder in the Library and select any bookmark/history item.

3. Scroll up/down until the selected item moves out of sight.

4. Change the active window to something else (Firefox or not).

5. Change the active window back to the Library.

Expected Behavior:

The Library does not automatically adjust its scroll position upon refocus.

Actual Behavior:

The Library automatically adjusts its scroll position to the selected bookmark/history item upon refocus. During mozregression, I noticed when I use Alt + Tab (as opposed to left mouse click), this sometimes happens right after I change the active window away from the Library instead.

I appreciate that the library infopane can no longer obscure bookmarks located towards the end of a long list, but the current fix is not really helpful for organizing bookmarks. I could be looking at other parts of my unsorted bookmarks or other opened tabs in another Firefox window in order to decide how to organize this mess, or I could be simply distracted by something else (notifications maybe?). Having to remember to select a random item to retain scroll position is not fun, and should I need to refocus to the selected bookmark's position, I could have simply used the up/down arrow keys.

INFO: Last good revision: 2e154dcda079ad6ca50bc5d18cbd0991386c5989
INFO: First bad revision: 2ca189b8925dba3f28a1cefdc3e6f143ffbee290
INFO: Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2e154dcda079ad6ca50bc5d18cbd0991386c5989&tochange=2ca189b8925dba3f28a1cefdc3e6f143ffbee290

Comment 1

[Alice0775 White]

I can reproduce this issue in Nightly103.0a1 Windows10.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:jteow, since you are the author of the regressor, bug 1471546, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[James Teow [:jteow]]

Indeed I was able to reproduce this.

I'm away next week but I can look more deeply into this once I'm back, specifically whether I can do an additional check at the point of where I'm calling ensureRowIsVisible or if there's a better place to add that code to avoid this regression.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1471546

Comment 6

[aoia7rz7l]

FYI it's not even necessary to switch to a different window. Merely clicking on the expand/collapse button of any folder on the left sidebar in the Library is sufficient to trigger this behavior.

Comment 7

[Donal Meehan [:dmeehan]]

:jteow has there been any progress since comment 3?

Comment 8

[James Teow [:jteow]]

:dmeehan, no, I was going to attempt to tackle this when I have more availability this month.

Comment 9

[James Teow [:jteow]]

Attachment: Bug 1774799 - Add conditions to when ensureRowIsVisible is fired - r?mak

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 3 duplicates.
:jteow, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 13

[James Teow [:jteow]]

This bug should no longer be an issue in FF 106 due to the patch associated with Bug 1786518 which reverts the changes that caused this bug in the first place.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jteow, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox105 to wontfix.

For more information, please visit auto_nag documentation.

Comment 15

[James Teow [:jteow]]

I don't think this bug is important enough to uplift as there are workarounds.

Setting status-firefox105 to wontfix.

Comment 16

[Ardelean Oana, Desktop QA [:oardelean]]

I managed to reproduce this issue on Firefox 105.0(build ID: 20220915150737) on Windows 10 using the STR from the Description. Verified as fixed on Firefox 106.0b4(build ID: 20220925185751) and Nightly 107.0a1(build ID: 20220926213808) on Windows 10, macOS 12, Ubuntu 22.