1818257 - french dictionary wasn't included by default like it used to

Status: RESOLVED FIXED

(Thunderbird :: L10n, defect)

Description

[Florent]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

Spelling checker (french for example) didn't appear

Actual results:

Spelling checker (french for example) didn't appear

Expected results:

Previous version have automatically the french dictionnary integrated after new installation

Comment 1

[Florent]

*For Windows

Comment 2

[Rob Lemley [:rjl]]

Confirmed, no French spelling dictionaries in 102.8.0. They were present in 102.6.1. Broken in 102.7.0+.

en_US does have them, it appears that localized builds do not.

Looks like beta is affected as well, I'd wager Daily is too.

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1818257 - Grab dictionaries from l10n-central when doing L10n repacks. r=#thunderbird-build-system-reviewers

Comment 4

[Rob Lemley [:rjl]]

Dictionaries for the locales that have them come from l10n-central.

For French: https://hg.mozilla.org/l10n-central/fr/file/tip/extensions/spellcheck/hunspell

Other localized builds are at the same path.

Post l10n-split, that directory was not included when copying the strings files from the l10n-central repositories to produce localized builds. It's a silent fail because many localized builds do not have dictionaries installed by default for one reason or another.

The attached patch adds the extensions/spellcheck path to the others copied from the l10n-central repositories. It will cover developer localized builds and langpacks (mach build installers-fr, mach build langpack-fr) as well as CI L10n repacks.

Verification can be done on Daily after this lands by checking the French build and langpacks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4f081c682751
Grab dictionaries from l10n-central when doing L10n repacks. r=mkmelin

Comment 6

[Rob Lemley [:rjl]]

Confirmed that the dictionaries are in today's Daily build for "fr" locale.
Dictionaries are not part of langpacks; my statement in comment 4 incorrectly mentioned them.

Comment 7

[Rob Lemley [:rjl]]

Comment on attachment 9319389 [details]
Bug 1818257 - Grab dictionaries from l10n-central when doing L10n repacks. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1765629
User impact if declined: Locales that include spell check dictionaries do not have them
Testing completed (on c-c, etc.): Verified on Daily (2023-02-23) fr build by inspecting omni.ja manually
Risk to taking this patch (and alternatives if risky):
Low risk, uses same code paths that are part of L10n strings repackaging already in use.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9319389 [details]
Bug 1818257 - Grab dictionaries from l10n-central when doing L10n repacks. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 111.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/cb3da33f6584

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9319389 [details]
Bug 1818257 - Grab dictionaries from l10n-central when doing L10n repacks. r=#thunderbird-build-system-reviewers

[Triage Comment]
approved for esr102

Comment 13

[Daniel Darnell [:dandarnell]]

Thunderbird 102.9.0:
https://hg.mozilla.org/releases/comm-esr102/rev/fcbd0e3c1b58