1907519 - [toolbar redesign] The address bar and nav bar don't hide when watching a video on full screen

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect, P1)

Description

[raj.azharuddin]

Attachment: Screenshot_2024-07-12-14-15-45-44_984e1414ae90666a90f12ff17ec14a7f.jpg

When the address bar and new toolbar is at button, it is hiding properly in full screen mode however if address bar is set to top, I still see a border on the top. Attaching screenshot.

Please note new toolbar feature is by default enabled in nightly, so this must be fixed at the earliest

Comment 1

[raj.azharuddin]

I have done a fresh installation also from playstore ...build 11th July
When address is set to top, I see the white border on the top in full-screen mode in light theme and a dark grey border in dark theme.

Device: Realme gt 6t
Android 14

Comment 2

[raj.azharuddin]

Attachment: Screenshot_2024-07-12-19-38-38-76_984e1414ae90666a90f12ff17ec14a7f.jpg

Comment 3

[raj.azharuddin]

Attaching a video . probably that will clear the confusion

Comment 4

[raj.azharuddin]

Attachment: Record_2024-07-12-19-48-37.mp4

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

:mavduevskiy, since you are the author of the regressor, bug 1902798, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 6

[Roger Yang [:royang]]

Attachment: Screenshot 2024-07-12 at 11.54.39 AM.png

Hi Raj, looking at the recording, it looks like you already have extra space above the address bar when you're browsing. Is this the case? Is this showing up for any site?

Comment 7

[raj.azharuddin]

Attaching new video with and without new nav toolbar feature enabled...

Comment 8

[raj.azharuddin]

Attachment: Record_2024-07-12-21-41-59.mp4

Comment 9

[Roger Yang [:royang]]

I see, so it's not related to the extra space before fullscreen. Thanks for confirming.

Comment 10

[Mike a [:mavduevskiy]]

Attachment: Bug 1907519 - Fix a bug causing extra spacing in fullscreen when navbar feature is on

Comment 12

[Delia Pop]

Attachment: GooglePixel8Pro.png

Confirming this issue is reproducible in the latest Nightly 130.0a1 from 07/18 with Google Pixel 8 Pro (Android 14). The blank space is also displayed while in pip mode.

Comment 13

[Delia Pop]

Attachment: Google Pixel 8 Pro (Android 14)

Comment 15

[Titouan Thibaud [:titouan]]

Attachment: image.png

From Bug 1907519:

In nightly, if I enter full screen mode for a video when I am in portrait mode then I get some empty space at the top of the video and no way to adjust volume, or fast forward in the video. Attached an image for clarification. This seems to be a recent regression.

Comment 16

[Titouan Thibaud [:titouan]]

The empty space will have the same position as the toolbar's: top if toolbar is set to top, bottom otherwise.

I've tried applying the current patch (D216484), that doesn't really fix the problem. The empty space will always be at the bottom of the screen though, no matter what the toolbar position is.

Comment 17

[effleurager]

I've noticed this issue occurs not just in videos, but across all pages. Whenever the viewport size changes, the toolbar is liable to counted as visible and subtracted from the available height.

The docs site yields the [attached] (https://drive.google.com/file/d/1G0SJQLkieliPJ9Y7KtYGAIcoeNVLbwfw/view) result when scrolling a tall page; this also occurs on pages exactly the size of the viewport such as in the attached images from Politaire.

Comment 18

[effleurager]

Attachment: Miscalculated viewport (landscape)

Comment 19

[effleurager]

Attachment: Miscalculated viewport (portrait)

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the following bug duplicate has higher severity:

• Bug 1908772: S2

:mavduevskiy, could you consider increasing the severity of this bug to S2?

For more information, please visit BugBot documentation.

Comment 21

[Mike a [:mavduevskiy]]

effleurager, thanks for providing more context!

addressed the usecase in the updated patch revision

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46df31a95832
Fix a bug causing extra spacing in fullscreen when navbar feature is on r=android-reviewers,tthibaud

Comment 24

[Serban Stanca [:SerbanS]]

Backed out for causing BrowserFragmentTest related fenix-debug failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | org.mozilla.fenix.browser.BrowserFragmentTest.WHEN fullscreen state changes THEN inFullScreen is updated with the current state | java.lang.ClassCastException: class java.lang.Object cannot be cast to class android.view.WindowManager (java.lang.Object is in module java.base of loader 'bootstrap'; android.view.WindowManager is in unnamed module of loader org.robolectric.internal.AndroidSandbox$SdkSandboxClassLoader @20a05b32)

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d5f8b003b5f
Fix a bug causing extra spacing in fullscreen when navbar feature is on r=android-reviewers,tthibaud

Comment 26

[tszentpeteri]

Backed out as requested by mavduevskiy to refactor.

• Backout link

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/821299f1e023
Fix a bug causing extra spacing in fullscreen when navbar feature is on r=android-reviewers,tthibaud

Comment 28

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/821299f1e023

Comment 29

[Florin Bilt]

(In reply to Pulsebot from comment #23)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46df31a95832
Fix a bug causing extra spacing in fullscreen when navbar feature is on
r=android-reviewers,tthibaud

Perfherder has detected a browsertime performance change from push 46df31a958329e5ef38c56bb858acbdb65386af0.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
2%	speedometer3 NewsSite-Nuxt/NavigateToUS/Sync	windows11-64-nightlyasrelease-qr	fission webrender	19.31 -> 18.88	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 1558

For more information on performance sheriffing please see our FAQ.