191184 - Non-ASCII keyboard input incorrect in all widgets

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect)

Description

[marina]

*** observed with 2003012908 build on WinXP ***
Steps to reproduce:
- opena new Address Card;
- type into First, Last name etc cyrillic chars;
//note: it inputs hex symbols, screen shot to follow

Comment 1

[marina]

same is true for New Mailing list, New Address Book, New LDAP directory

Comment 2

[Andrew Hagen]

This looks like a duplicate of bug 186798 or the other way around.

Comment 3

[marina]

it seems that the problem reported in 186798 is about central european chraset.
I'll mark it a dup and change the summary 

Comment 4

[marina]

*** Bug 186798 has been marked as a duplicate of this bug. ***

Comment 5

[Jure Repinc (JLP)]

Shouldn't this bug be marked as dup of 186798 as 186798 us older and has more
info about the bug.

Comment 6

[marina]

Jure, bug # 186798 was entered for the wrong component and assigned to the wrong
people. If there is pertinent info in that bug please put your comments here.
Thanks. 
Frank, please look at the bug #188704 that discribes the same problem with
Hebrew text. As Jure mentioned in bug # 186798 it happened as early as in
20011212 build.

Comment 7

[Andrew Hagen]

Perhaps also duplicates: bug 181290, bug 191326, bug 185998, and bug 185529. 
 

Comment 8

[Simon Montagu :smontagu]

*** Bug 188704 has been marked as a duplicate of this bug. ***

Comment 9

[Simon Montagu :smontagu]

undefining MOZ_UNICODE removes this bug for me (for the Hebrew case at least)

Comment 10

[Roy Yokoyama]

is this regression from NS7?

Comment 11

[Simon Montagu :smontagu]

Taking bug

Comment 12

[Simon Montagu :smontagu]

.

Comment 13

[Simon Montagu :smontagu]

Attachment: Patch

Comment 14

[Simon Montagu :smontagu]

*** Bug 191140 has been marked as a duplicate of this bug. ***

Comment 15

[Simon Montagu :smontagu]

*** Bug 191186 has been marked as a duplicate of this bug. ***

Comment 16

[Simon Montagu :smontagu]

*** Bug 191198 has been marked as a duplicate of this bug. ***

Comment 17

[Simon Montagu :smontagu]

*** Bug 191326 has been marked as a duplicate of this bug. ***

Comment 18

[Simon Montagu :smontagu]

*** Bug 181290 has been marked as a duplicate of this bug. ***

Comment 19

[Simon Montagu :smontagu]

*** Bug 185529 has been marked as a duplicate of this bug. ***

Comment 20

[Simon Montagu :smontagu]

This is a bad regression, but the fix may be too high risk to request 1.3
approval for, since it will affect just about every Windows message. Frank, what
do you think?

Comment 21

[Simon Montagu :smontagu]

*** Bug 189473 has been marked as a duplicate of this bug. ***

Comment 22

[Andrew Hagen]

Nominating for 1.3 beta, but anytime before 1.3 final would be good. It would be
a lot of breakage for a milestone release.

Comment 23

[Simon Montagu :smontagu]

*** Bug 191007 has been marked as a duplicate of this bug. ***

Comment 24

[Roy Yokoyama]

Comment on attachment 113261 [details] [diff] [review]
Patch

/r=yokoyama
I was hoping we catch this 
kind of bugs sooner.

Thanks, Simon

Comment 25

[kinmoz]

Comment on attachment 113261 [details] [diff] [review]
Patch

sr=[e-mail]

Has someone done a sweep through all of the source looking for Win32 calls that
have a corresponding nsToolkit::m* version that should be changed over?

Comment 26

[Jo Hermans]

*** Bug 192012 has been marked as a duplicate of this bug. ***

Comment 27

[Asa Dotzler [:asa]]

I think this probably blocks 1.3beta. Can we get more eyes on the patch,
additional reviews or testing to help minimize risk of landing it so late in beta?

Comment 28

[Simon Montagu :smontagu]

Updating summary. The various dupes mention at least Calendar, Address Book,
Mail/News account settings, Mail/News search, Message filters, Bookmark Manager,
and Composer widgets as affected locations; and Cyrillic, Eastern European,
Thai, Armenian and Hebrew as affected languages.

Comment 29

[Simon Montagu :smontagu]

Comment on attachment 113261 [details] [diff] [review]
Patch

Requesting approval for 1.3b. 

Marina says " I tested all widgets in the mentioned bugs (including dups) and
it looks OK. I read comments # 35 to the bug # 104934 and i don't see any
regressions..."

Although the patch will have quite a wide effect, since it makes all Windows
messages that go through nsAppShell::DispatchNativeEvent() use the
DispatchMessageW API instead of the DispatchMessageA API, I think Marina's
testing is sufficient to be sure that there are no major regressions. The
original MOZ_UNICODE checkin in bug  104394 did the same thing for Windows
messages in more common code paths, and Marina has tested regressions that were
discovered at the time. I think it's unlikely that there will be any completely
new regressions.

Comment 30

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 113261 [details] [diff] [review]
Patch

a=dbaron for trunk checkin (for 1.3beta).  Please get this checked in today so
that we get as much testing as possible.

Comment 31

[Simon Montagu :smontagu]

Fix checked in.

Comment 32

[marina]

on the optimized build this scenario was tested for Hebrew (and other lang that
had a problem:non-Latin-1):
Open a web page with a form.
Open a dialog affected by this bug, e.g. Mail Account Settings, and set focus to
the Your Name text field.
Return to the web page without closing the dialog.
Input is now corrupted in the web page forms. 
//result: with the patch the input in the web form was correct

Comment 33

[Jure Repinc (JLP)]

Seems to be fixed in build 2003020608 on Windows XP Pro.

Comment 34

[Wesha]

*** Bug 192104 has been marked as a duplicate of this bug. ***

Comment 35

[marina]

verified as fixed