Closed Bug 195047 Opened 22 years ago Closed 21 years ago

doesn't automatically delete mail in junk mail folder

Categories

(MailNews Core :: Filters, defect)

Product:
MailNews Core
Component:
Filters
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Mats.Larsson, Assigned: Bienvenu)

References

Details

Attachments

(1 file)

proposed fix
3.37 KB, patch
mscott
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.3b) Gecko/20030211
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.3b) Gecko/20030211

The setting "Automatically delete messages marked as junk mail after 5 days" is
checked. But mail older than 5 days is not removed from my Junk filder.

Reproducible: Always

Steps to Reproduce:

Actual Results:  
No mails are deleted.

Expected Results:  
Mail older than <value> days should bee deleted.
Reporter, are you using POP or IMAP ?

I have the same problem (on IMAP), but that's because my IMAP server doesn't
allow searches without an index. I get the same error when I try to search for a
message directly on the mailserver  "The current command did not succeed. The
mail server responded : SEARCH database is not full-text indexed.".
Same results on my 4 POP accounts with 
Mozilla/5.0 (Windows; U; Windows NT 5.1; de-AT; rv:1.3) Gecko/20030227
Answer to comment #1:

I use IMAP/Exchange (Microsoft Exchange Internet Mail Service Version
5.5.2655.55). No problem searching it.
I have the same problem on Mozilla 1.4b running on Windows 2000 SP2.  But this
used to work!  I have it set to delete message in Junk folder every 3 days - as
I write this, I have 1296 messages in my Junk folder with some messages dating
back to 1999 - obviously the spammer's machine didn't have their dates set
right!  What date does the algorithm-to-remove go by?  The date it was put in
the Junk folder or the actual date on the message?  Either way, some of the
messages have been sitting in my folder for more than a month.

Hope this gets fixed as I currently have to manually go into the folder,  select
everything and delete.



same effect on my installation, Mozilla/5.0 (Windows; U; Windows NT 5.1; de-AT;
rv:1.4b) Gecko/20030507

can anyone explain when purging of junk mails starts
Possibly duplicate (OS=Win2000): Bug 203623, comment 3

True for WinXP as well as Sun.  I have junk mail controls set to delete after 1
day and it does not delete at all.
fixing summary to make bug look like a bug report rather than a request.
Summary: don't automatically delete mail in junk mail folder → doesn't automatically delete mail in junk mail folder
I see this with 1.5a 25 jun 2003 Linux i686 and on Sun/Sparc Solaris 8 as well. 
I sometimes see some of the mails being deleted, but I cannot find a rule. 
I've several accounts open. Maybe this is something that happens when the 
sender has set a wrong date (in the future) to get it's mail on the top or
bottom for a couple of days. 'delete if received-from-time is older 
than xx days' may works better than using the Date field. Or does the algorithm
check for mails EXACTLY xx days old ? That would be obviously weak. In which
source file can we find the algorithm ?
Found the source:
http://lxr.mozilla.org/seamonkey/source/mailnews/base/src/nsMsgPurgeService.cpp
In line 266, it states

nsTime nextPurgeTime = lastPurgeTime + nsInt64(mMinDelayBetweenPurges * 60000000
/* convert mMinDelayBetweenPurges to into microseconds */ );

Apart from the funny in-braces comment, the multiplication inside nsInt64 gives
a value larger than 2^31, which overflows a 4 byte signed integer (
mMinDelayBetweenPurges=480). I'm not sure about how that multiplication is
handled by the compiler, but for in Fortran program this would be an error.
(I'm not an experienced C++ hacker...)
Bug 200802 is for using received date, rather than the Date header.
Tried to verify my theory by setting mail.purge.min_delay in 
defaults/pref/mailnews.js to 60. No change, nothing deleted.
*** Bug 212755 has been marked as a duplicate of this bug. ***
I'm seeing my junk mail auto deleted correctly from one of my pop accounts (the
first listed - default) but auto delete is not working in the two subsequent
accounts even though the settings are exactly the same. I am running seperate
junk folders for each account. Running 1.4 on WinXPPRo. Auto delete is set to
three days for each account. 
Same problem here. I also use IMAP. To determine whether this is an IMAP issue I 
will (temporarly) move my junk mail folder to a local folder.
It's not an IMAP problem only, I'm using only POP3.
The following statement seems to be true:
If you have two mail accounts, it works correctly on the second, but not at all on 
the first (or at least at one of the two). Maybe it's in the order they were 
created or found by the junk mail controls.
*** Bug 203623 has been marked as a duplicate of this bug. ***
Platform/OS => All, dupe is for Windows.

Reports in the dupe corroborate with the idea that this problem is for one of
several accounts.

I have my three accounts putting their junk into the same "Local Folders/Spam"
folder, but one of those accounts gets almost no mail, and no junk at all; mail
from the first two accounts are being deleted.
OS: SunOS → All
Hardware: Sun → All
*** Bug 212936 has been marked as a duplicate of this bug. ***
Sorry for filing a dupe ( Bug 212936 ), but my search did not return any results.

As I stated in my bug report, it worked on my system (PowerPC G4, MacOS 10.2.6)
using Mozilla 1.3.1
I then upgraded to 1.4 (via RC2) and since then, it works on my first and second
account (as I just noticed), but does not on the third. (which is the one with
the far most spam, in accordance with Murphy)

As soon as I found out more details, I'll let you know.
I'm still getting the same issues with 1.5a.  All but
the last account has the junk removed.  My last email
account now has 500+ junk from last month and this
month.  


I only have one IMAP account these days (used to have two) and nothing gets
deleted from my junk mail folder unless I do the following:

1. Select all mails in the junk mail folder.
2. Mark them as junk (most of them are *not* marked as junk!?).

Then the older ones (older > 5 days for me) are deleted automagically. As a user
I think all mails in th junk folder should be marked as junk mail. That's not
the case for me even though they once have been moved to the junk mail filder.
Ik have also this problem with Moz 1.5 beta build 17 sept 2003:

Two IMAP accounts (myrealbox.com) with this setting:
* Automatically delete junk mail oder tha 1 days from this folder

Junk mail that is older than 1 day is remaining in "Junk". I don't know
precisely; but I think I had not this problem with Moz 1.4 final.
My POP3 account seems to be OK.

OS is Win 98 SE.
*** Bug 220798 has been marked as a duplicate of this bug. ***
Apologize for Dupe Bug 220798.  Searching for "automatically delete junk" turned
up no hits.  Perhaps the bug title should be altered to match the UI string
"Automatically delete junk mail messages older than <X> days from this folder".

A workaround on 
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4) Gecko/20030624
is to select the Junk folder and then select the menu item Tools|Run Junk Mail
Controls on Folder.  Workarounds are of course irritating.
I only have one e-Mail account on the affected machine, so I can't speak to
applicability to installations with multiple accounts.

Also, perhaps this bug should be reclassified as "Minor".  There's no
substantial failure, just unexpected behaviour that could be rectified by
removing the word "Automatically" from the Spam settings dialog.  And there's a
straightforward workaround (in one test case).
I find this bug annoying. Please don't reclassify it downwards.
I agree..  please don't drop this to minor.  It's 
quite unnecessary and very irksome and defeats
the purpose of having such a feature.
*** Bug 222162 has been marked as a duplicate of this bug. ***
Anyone working on this bug?
maybe david or mscott can help.
Assignee: naving → bienvenu
is the problem that we're only deleting junk mail from the junk folder, and not
non-junk mail? I think the idea there was that you might specify a "normal"
folder as the junk folder (e.g., the trash folder) and we wouldn't want to age
away non-junk messages from that folder. 

If your imap server is one that doesn't support user defined keywords, the junk
flag wouldn't get carried over to the junk folder. However, I implemented and
checked-in a work-around for that recently.
Bienvenue: No, the problem is that we are not deleting anything from all except
one folder, no matter if it's junk or not.
I tend to agree with David Bienvenu in comment #32. For me the problem is that
after the automatic move to my junk mail folder (Junk) mail is *not* marked as
junk anymore and hence never gets deleted.
Using new Moz1.5 and any junk mail automatically moved to
the junk folder retains their 'junk' status.  

But still not deleting junk mail given the constraint of
1 day.  




My experience goes along with comment #33.  However, this is with Thunderbird
and not with the Suite mail/news component.  I used to have my 2 IMAP accounts
each having their own Junk folder on the server, and junk mail only got deleted
from the Junk folder on the first listed account.  I changed them both to put
the junk mail in the same folder and now all is well.  This even works if they
put the Junk mail on the Server for the second listed account, and it also works
if the first account has a junk folder as long as automatic deletion is NOT
enable for that junk folder.  So, at least for Thunderbird, the issue is that if
you have more than 1 junk folder, junk mail is only automatically deleted from
the one associated with the first listed account for which you have automatic
deletion enabled.
But I only have one IMAP account these days (see comment #23).
OK, so it sounds like there might be 3 issues then:

1.  It only works on one folder

2.  If the e-mail in the Junk folder is not marked as junk it does not delete it.

3.  Some e-mail that is moved to the junk folder somehow ends up not having the
junk flag set in the junk folder.
Comment to #38 item 3:
For me all mail moved to the junk folder looses its junk flag.
Mats, are you running a 1.6 trunk build yet? That's where the fix is to retain
the junk flag when moving a message between imap folders on servers that don't
support user defined keywords.
Using POP accounts so that the Junk folder is local, 
Items automatically marked as Junk retain Junk-ness in the Junk folder.
Items manually marked as Junk do not retain Junk-ness in the Junk folder.
No items are automatically deleted from the Junk folder, regardless of Junk-ness.
All (old enough) items are deleted from the Junk folder when Junk rules are run
against the folder, regardless of Junk-ness.
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4) Gecko/20030624
I never saw that the junk mail flag was lost (Linux i686). That maybe is another
OS dependent bug and should be spawned from this one (with respect to the original
report). 
Answer to comment #40. No I'm not using the 1.6 trunk build. I will try it and
get back.
With the 1.6 trunk build (Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.6a)
Gecko/20031020) everything works fine. Mail automatically and manually (click on
the junk button) moved to my junk folder retain its junk flag and mail older
than 5 days (my setting) gets deleted automatically.
I was told this bug was fixed???  
I am using 1.6a and still junk messages are not deleted after "x" number of days. 
As far as I can tell, the problem still exists. I am currently running
Thunderbird (M2 release... Mozilla Thunderbird 0.4a (20031105)). I have several
IMAP & POP3 accounts.

For each account, I have a separate Junk folder setup. Thunderbird does a great
job of catching then junk mail and moving it to the appropriate folder for each
account and it retains being marked as junk. Also, for each account, I have it
set to automatically delete from the Junk folder after 4 days. Unfortunately,
this doesn't happen. The junk mail will stay in the folder until I delete it
manually.
WFM Mozilla 1.6a Linux i686 gcc2.95.3 compiled
the basic problem is that the code that periodically purges a junk folder on a
server picks the same junk folder every time.
Status: NEW → ASSIGNED
So, David, basically what you are saying is that if, for example, I have 3
different IMAP accounts with a junk folder for each, Thunderbird will delete
junk mail from the junk folder of one account (the same one each period) but
never from the other two accounts??
yes, that's the bug, from what I can see. I'm looking into how to fix it.
Attached patch proposed fix — — Splinter Review 
always pick the least recently purged server, and store last purge time as last
purge attempt so a down server doesn't always get serviced.
Attachment #134938 - Flags: superreview?(mscott)
Attachment #134938 - Flags: superreview?(mscott) → superreview+
fix checked in, along with bulletproofing follow on fix.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Is there any chance this patch addresses bug 187504?  That's also about a Junk 
feature not working on multiple IMAP accounts; I am IMAP-deprived and cannot 
test.
*** Bug 225676 has been marked as a duplicate of this bug. ***
*** Bug 225697 has been marked as a duplicate of this bug. ***
This have added a warning on brad TBox:

+mailnews/base/src/nsMsgPurgeService.cpp:178
+ `PRInt32 purgeIntervalToUse' might be used uninitialized in this function

it's a bogus warning, but we could make it go away, I guess.
*** Bug 228662 has been marked as a duplicate of this bug. ***
Product: MailNews → Core
Issue not resolved with Netscape (7.1), since there is no file
nsMsgPurgeService.cpp there. The only configuration file, which contains the
word "purge" is mailnews.js in the folder C:/Program
files/Netscape/defaults/pref/ - but the code is totally different that the
source provided in the Mozilla patch.
Please, could you release or mail me a fix, which could work with Netscape 7.1?
So, in my case, the bug is still nor resolved nor fixed :-/ (but I can not
change the bug level here)
angelg@vfemail.net
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: