20336 - Ctrl-Enter should send the message only if there is pref to turn it off

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P2)

Description

[Richard Zach]

As in Navigator, 4.x, pressing Alt-Enter in the message compose window should
send the message, Alt-Shift-Enter send it later.

Linux build 1999.11.29.08

Comment 1

[Phil Peterson]

Note that it's CTRL-Enter on Windows and CMD-Enter on Mac. Would like to have
this for B1, but wouldn't hold for it.

Comment 2

[Richard Zach]

Alt-Enter now seems to attempt to send the message, but causes Mozilla to hang
(Linux build 2000.02.11.11).

Comment 3

[lchiang]

Does clicking the Send button cause it to hang?

Comment 4

[Richard Zach]

No, send button is fine.
After I hit Alt-Enter, I get this in the console:

toAddress: [e-mail]
we don't handle eBorderStyle_close yet... please fix me
WEBSHELL+ = 37
-------- BOX IS ROOT --------
onload top.composeWindow: [object Window]
onload toAddress: [e-mail]

Then Mozilla becomes unresponsive and has to be killed.

Comment 5

[lchiang]

I'm going to modify the summary and nominate for beta since the hang can result 
in data loss of the compose window.

Comment 6

[leger]

Putting on the PDT+ radar for t hang and beta1.  But discarding the key binding
is perfectly acceptable for beta.

Comment 7

[Richard Zach]

Btw, I think we're moving to Ctrl for shortcuts, so it should probably be
Ctrl-Enter anyway.

Comment 8

[Richard Zach]

On Linux build 2000.02.14.09 I don't hang anymore.  Could you verify, and then
either make this into the shortcut RFE or resolve and file a new bug (or tell me
what to do)?

Comment 9

[lchiang]

Why don't we just turn this bug into switching to ctrl-enter then (where did you 
hear about the ctrl key?)  Thanks.

Comment 10

[Richard Zach]

In bug 23575 german writes: "We had collectively decided earlier (after a
newsgroup poll and discussion) to move away from Alt as shortcut and leave this
for menmonics only. We decided to use Ctrl as default shortcut qualifier key for
Linux et al. This is the state it should be in for beta1."  Assume since we're
talking about shortcut for Edit | Send, it should now be Ctrl-Enter. CC german,
hyatt

Comment 11

[Jean-Francois Ducarroz]

I don't understand why alt/ctrl-enter causes the application to crash. Atl-enter 
is not yet binded to Send.

As zach doesn crash anymore, I remove the [PDT+] status and change back the 
summary to "Ctrl-Enter should send the message". If PDT team agree, we should 
remove the keyword beta1

Comment 12

[leger]

Putting on PDT+- radar for beta1.  Would not hold beta, can release note if 
needed.

Comment 13

[Kathleen :Brade]

Adding a few interested people to the cc list.

I would like to see this bug resolved as WONTFIX since I often see reports of 
users who press enter/return and inadvertently also press control.  This makes 
them look stupid when they've sent a message that they didn't finish.

If we really need a keybinding for this, how about a 3-key binding or something a 
little less likely to be pressed while typing?

Comment 14

[Akkana Peck]

I miss having a "send" binding and use control-return heavily in 4.x, but I
agree with Kathy that it's unintuitive.  I'd like to see this functionality
bound to some other key -- not a 3-key sequence, just something a little less
unintuitive than control-return.

I hesitate to suggest one since I don't know what's available.  Do we have a
spec anywhere for key bindings?

Comment 15

[Simon Fraser [no longer active]]

This is my most hated keyboard shortcut. I can't tell you how many times I've 
fumbled on the keyboard, and sent a message by mistake. Please either kill this 
shortcut, or put up a confirmation dialog before sending.

Comment 16

[lchiang]

cc: [e-mail] for input.

Comment 17

[laurel]

removing relnote keyword.  Will include a general statement in mailnews release
notes something like "not all keyboard shortcuts are implemented, please rely on
relative menu or toolbar items".

Comment 18

[Matthew T (active 1999-2002)]

Ctrl+Enter seems to me to be about as intuitive as you can get. But if there 
really are some people who type it by mistake (is there some keyboard layout I 
don't know about where Ctrl and Enter are next to each other?), then perhaps this 
is a good case for an optional confirmation dialog.

Since the keyboard shortcut itself involves the Enter key, the default action for 
the confirmation dialog should probably be Cancel. This would prevent problems 
where the user presses Ctrl+Enter, sees a dialog come up, thinks `oh, whoops, I 
actually meant to press Shift+Enter' (or whatever), and then does the usual human 
thing by going ahead and pressing Shift+Enter (or whatever) -- thereby dismissing 
the dialog and sending the message.

Comment 19

[Akkana Peck]

Nooo, please, not a confirmation dialog!  The whole point of having a keybinding
here is as a "quick send without having to use the mouse".  If I then have to do
something else (usually involving moving from the keyboard to the mouse) this is
no longer a win over clicking on the toolbar.

A better solution would be to use a different binding, one which users don't
tend to hit by accident.  I'd suggest one if I knew of where to find the
existing bindings, in order to look for one that isn't already spoken for.

Comment 20

[Matthew T (active 1999-2002)]

* Some e-mail/Usenet clients, such as MT NewsWatcher for example, have an
  optional confirmation dialog for sending messages already. It's useful as a
  sanity checker, not just as a way of making sure that you didn't hit the Send
  key combination by accident.

* Why should dealing with a simple confirmation dialog involve using the mouse?
  It would be Ctrl+Enter to bring up the dialog, then Tab, then Enter.

* You're going to have the problem with accidentally hitting the key-binding
  occasionally no matter which key-binding you choose.

* Ask Lake if you want a list of the current bindings. They haven't been
  published anywhere yet AFAIK.

Comment 21

[Akkana Peck]

* It involves the mouse because when the dialog comes up, the focus isn't in it,
so hitting return will go to the wrong window.  You obviously use a
click-to-type focus model; not everyone does.  This is especially true in
mozilla, where we don't mark our dialogs as transient so even Linux window
managers which are smart enough to put focus in transient windows don't know to
do so in mozilla.

* I have never accidentally hit the alt-return binding, in three years of using
4.x. Which is not to be construed as an argument that I think it's a good choice
for the binding, just that lots of people are good with keyboard control and bad
with mouse control, just as some people are the other way around.

Comment 22

[Richard Zach]

How about a pref? ;)

Comment 23

[Matthew T (active 1999-2002)]

akkana: Well, that's a problem with Mozilla's dialog windows on X in general, 
then; it's not a problem which should spill over into deciding whether a 
confirmation dialog is a good idea or not in this particular case. (And, like I 
said, the dialog should be optional, so people who don't have a problem with the 
key-binding can have the confirmation dialog turned off.)

We shouldn't make Mozilla's UI worse, XP, just because some X window managers are 
clueless. If you followed that argument to it's logical conclusion, Mozilla could 
never have any confirmation dialogs at all.

Comment 24

[Charles Manske]

I would like a pref as well. 
I also wouldn't mind a dialog asking if I want
to send. If you want Ctrl+Enter because you like the keyboard interface, you
just hit Enter for the dialog to continue if assume the default to the yes/no
choice is is "yes"

Comment 25

[selmer (gone)]

Mass moving to M16 to get these off the M15 radar.  Please let me know if this
is really an M15 stopper.

Comment 26

[selmer (gone)]

Mass moving M16 to M17 - look for nsbeta2 before anything else.

Comment 27

[scottputterman]

moving to M18 and nominating for beta3.

Comment 28

[Nelson Bolyard (seldom reads bugmail)]

Today, while composing a rather important email message in the plain text 
email composer, I accidentally pressed ctrl-Enter, and discovered to my 
horror that it was the hotkey for "Send Now".   AAAAAAARRRRGGGGGGHH! 

PLEASE, if you implement this hot key for Seamonkey, provide a way to 
disable it!

Comment 29

[Steve Parkinson]

I hit this about once a month or so in 4.x. I think it depends a lot on the 
users typing style. I have hit it a few times when trying to figure out how 
get unstuck from editing a bulleted list.

Having a dialog come up may also be a problem. Generally, those damn dialogs 
only come up when prompting for auto-save, and I usually hit okay straight away.
Maybe the first time the users does that, we could pop up the dialog asking if 
that's the behaviour he wants... then the dialog wouldn't come up any more. 

Can't we have at least have a pref?

Comment 30

[Peter Trudelle]

I agree that Ctrl-Enter is far too easy to hit accidentally.  Comparing the
slight benefit of having an easy accelerator, versus the continual disaster of
inadvertant sends, I think we should make it more difficult, by dropping the
feature, adding another modifier or perhaps disabling it by default, but adding
a confirmation dialog would be an abomination.  I feel dirty even talking about it.

Comment 31

[Matthew T (active 1999-2002)]

I'm astounded that so many people seem to have trouble with hitting Ctrl+Enter by 
mistake ... How did you ever survive using 3.x and 4.x?

And is anyone actually going to suggest an alternative shortcut???

Comment 32

[Steve Parkinson]

I have figured out what it is - ... it's when I'm using ctrl-V to paste 
something, followed by an enter. But if my timing is slightly off, the ctrl
key is still pressed with my left pinky. I think it comes down to 
lack of left-hand/right-hand coordination.

Comment 33

[jglick]

I've tried to keep track of the accelerators that I know are being used. If you 
know of any missing, drop me a note.

Here is the URL for internal folks.  I will attach the file to this bug for 
external folks.

Ctrl+Shift+S is already taken, but Ctrl+Shift+M is available ("Mail")?

Or, we could use Ctrl+Shift+Enter for Send Now. If you're currently offline, it 
would send later.

Comment 34

[jglick]

http://gooey/client/5.0/specs/mail/Misc/Accelerators.html

Comment 35

[jglick]

Attachment: SeaMonkey accelerators

Comment 36

[Kathleen :Brade]

Jennifer--can you publish that spec on mozilla.org (or ask someone else to do it 
for you)?  It's easier for some of us to view this stuff when it's not behind the 
firewall.  Thanks!

Comment 37

[Matthew T (active 1999-2002)]

Users expect that Ctrl+Shift+{somekey} performs an action which is a logical 
counterpart to the one performed by Ctrl+{somekey} -- e.g.:
* Ctrl+S (save) vs. Ctrl+Shift+S (save as), in many apps
* Ctrl+P (print) vs. Ctrl+Shift+P (print preview, or print setup), in many apps
* open page in Navigator (Ctrl+O) or in Composer (Ctrl+Shift+O), in 4.x
* find in this message (Ctrl+F) or in lots of messages (Ctrl+Shift+F), in 4.x.

Therefore, Ctrl+Shift+M to send is inappropriate because it is too close to
Ctrl+M (new message). (The Aphrodite spec has Ctrl+Shift+M opening a dialog 
asking which template you want to use for a new message.)

And Ctrl+Shift+Enter is inappropriate because it would be the complete *opposite* 
of what 4.x (and 3.x) uses by default (Ctrl+Enter for `Send Now' and
Ctrl+Shift+Enter for `Send Later').

Comment 38

[Daniel Veditz [:dveditz]]

We could do something like the standard AIM and have it be a preference. In the 
AOL chat client "Return" means send by default but it can be switched to put a 
return in the message instead; ditto tabs.

I *like* Ctrl-Return and Ctrl-Shift-Return, never have a problem with early 
sends. Sounds like lots of people like it, and certainly lots of people are 
used to it from Communicator. So make it a pref that can be turned off.

Comment 39

[:deanis74]

I like it, too.  In fact, Microsoft must have realized that it has some value, 
too, because even though it's not published in either UI, the combination can be 
used to send in both Outlook and Outlook Express.

Comment 40

[lchiang]

+ per mail triage

Comment 41

[Kathleen :Brade]

change summary to reflect wishes of many users who have been burned by this key-
combination

Comment 42

[Akkana Peck]

A better summary might be: "Need key binding for send message", and then try to
pick one that users don't hit accidentally.  I would think that even a lot of
the users who get burned by control-enter might like a key binding for Send, if
it were something that they didn't hit accidentally ... no?  I certainly use
alt-enter a lot.  But I don't want to get into a summary war here.

Comment 43

[Jean-Francois Ducarroz]

Here is what I am proposing to do:

Add a pref to turn on/off Ctlr-Enter to send message, the pref will be off by 
default. Like that you wont have a surprise...

Comment 44

[timeless]

Please consider the nagable format.
user w/o pref presses <ctrl>-<enter> a dialog appears explaining what the 
binding does asking should it be bound <enter> would cause yes and send the 
message.  There is work on a prefs panel for boolean toggles, and this would 
easily fit that.

Comment 45

[Matthew T (active 1999-2002)]

This is turning surreal.

> Add a pref to turn on/off Ctlr-Enter to send message, the pref will be off by
> default. Like that you wont have a surprise...

Yes you will, because if you've used *any* previous version of Netscape 
Mail/Messenger, the keyboard shortcut you've used hundreds of times (or more 
likely, tens of thousands of times) suddenly won't work any more. If that's not 
a surprise, what is?

And WE STILL DON'T HAVE ANY ALTERNATIVE SUGGESTIONS for the keybinding. If 
there is going to be a pref (something which reviewers will laugh at, no doubt) 
to switch the keybinding from Ctrl+Enter/Shift+Ctrl+Enter (for Send Now/Send 
Later) to {something}/Shift+{something}, WHAT is that {something} going to be?

Comment 46

[Kathleen :Brade]

so as not to be understood, my suggestion was that the pref should completely 
disable a keybinding for send now (not toggle between two or more keybindings).

As for compatibility with 4.x, yes, some users might like that but reality is 
that many keybindings will change.  (This is true with every commercial product 
upgrade I've ever made.)

Comment 47

[selmer (gone)]

OK.  This discussion needs closure.

Jean-Francois has agreed to implement a pref to control whether the keybinding
ctrl-enter should be active or not.  The default setting of this pref for the
Netscape commercial product will be compatible with 4.x.

No other action is plussed by this bug.  Please file individual enhancement
requests if you care about the other suggestions in this bug.

Comment 48

[lchiang]

second pass: - per mail triage

Bug 50252 which we need to fix this on Linux has been marked nsbeta3-.  

Comment 49

[Matthew T (active 1999-2002)]

So it works on Mac, and can work on Windows once the prepared fix to bug 50255 is 
checked in. Are PDT saying, therefore, that Ctrl+/Cmd+Enter shouldn't be 
implemented on *any* platform, just because it wouldn't work for a while on 
Linux? (Couldn't you do an #ifndef???)

Comment 50

[Akkana Peck]

No need for an ifndef -- if it doesn't work, then it doesn't.

How ironic that Linux, the only platform where people didn't mind the old
binding, is the one where it doesn't work!

I still think it's ridiculous that no one is willing to consider an alternate
binding for this very useful functionality.

Comment 51

[Jean-Francois Ducarroz]

Maybe we should reconsider our desicion. I can checkin the fix for windows as it 
has been reviewed and tested and quickly implement this key binding. It will 
works on Mac and Window.

Comment 52

[Jean-Francois Ducarroz]

oops, I totally forget a little problem. If I implement the keybinding, we will 
have a major problem on linux as CTLR+M (New Message) will be equal as 
CTRL+Enter (Send message). I don't know which one will win but it will be too 
dangerous to do it. Sorry, we must fix bug 50252 first.

Comment 53

[Akkana Peck]

Reviewing the key bindings, ^T is the only alphanumeric key I can find which
isn't currently bound in the mail compose window.  Not especially intuitive, but
no less so than ^<Return>.  There are lots of non-alphanumeric keys available,
like ^> (that sorta has a feel of sending to someone -- think redirect -- and
would seem like a fine keybinding for Send Now), ^., ^\, and all the shifted
stuff (though using shifted nonalpha keybindings, like $ or * or whatever, is
likely to run into platform incompatibilities in our event system).

Alternately, argue for the nsbeta3+-ness of 50252 or 46992 (probably the same
bug) so Pav or I can work on them.

Comment 54

[Grey Hodge (jX)]

Aside from the Linux issues, I don't see where there are any really valid
arguments. A lot of current email programs acknowledge CTRL-ENTER as a SEND
shortcut. Including NS4.x and Microsoft's Email offerings. And if the PDT team
is looking to really compete with a competitor, then obviously NS6 needs to do
everything the competitors do, better. I think this one is a no brainer.

Plus, chicks dig it.

Comment 55

[Jean-Francois Ducarroz]

*** Bug 56696 has been marked as a duplicate of this bug. ***

Comment 56

[Ben Bucksch (:BenB)]

IMO, we shouldn't have a pref, but a key which is unlikely to be hit during
composition.

I think, Ctrl-Enter is much more likely to be hit accidently than Alt-Enter.
This user might accidently have his left hand rest on Ctrl, or he might be
trying to hit Shift-Enter, but get the wrong modifier. For the same reason,
Crtl-Shift-Enter is not a good key IMO, because the user might try to hit
Shift-Enter and accidently also press Ctrl.
I don't see such a risk for Alt (neither in theory, nor in my experience.
Unfortunately, we don't seem to be allowed to use Alt for shortcuts.

I propose Ctrl-0. It can be access quickly (one key per hand), and doesn't seem
to be taken.

Comment 57

[Ben Bucksch (:BenB)]

Or what about the function keys? I don't see any of F1..F12 being taken. Any of
them (other than F1 and F10) would be fine with me, or Ctrl + any of F5..F12.

Comment 58

[Jean-Francois Ducarroz]

*** Bug 57052 has been marked as a duplicate of this bug. ***

Comment 59

[scottputterman]

sorry for the extra email. Removing mail2 keyword.

Comment 60

[varada]

Adding mail3 keyword.

Comment 61

[Ninoschka Baca]

*** Bug 47708 has been marked as a duplicate of this bug. ***

Comment 62

[James "Kovu" Russell]

I think the shortcut for Send should Alt+S, just as in Outlook and ICQ. It's
very fast, and in the Mail Compose window, Alt+S isn't currently used for
anything that I can see.

In all cases I think we should be consistent using Alt+ the first letter of the
function (at least Alt+ in Windows, which is used a great deal for hotkeys),
unles the Alt+ is taken and then we could find a reasonable alternative, like
Alt+Shift+ or something else. Something that can be done with one hand and only
two fingers when possible. Alt+ is just a roll of the thumb and a tap with the
index finger. I love it.

See bug 55679 where I discuss that the toolbars in Mozilla that currently have
hotkeys, just as their counterparts on the menu toolbar do, just like Outlook
does, and so on. 

Comment 63

[Grey Hodge (jX)]

Ctrl-Enter should still be supported, in addition to any other hotkey for a 
number of reasons:
1. NS4.x parity
2. Parity with Outlook and Outlook express (the currently most common mail 
client)
3. Chicks dig it.

But 1 and 2 are the most important.

Comment 64

[timeless]

ctrl-s is save, this has already been argued. We need to support ctrl-enter, if 
you want to argue ctrl-s, please file a separate bug. [Actually don't as I 
suspect we already have one marked won't fix, but ...]

Comment 65

[[e-mail] (gone - use [e-mail] instead)]

CC:ing myself.

Comment 66

[Jacob Steenhagen]

I second the Alt+S.  I see two problems with Ctrl+Enter.
 1. The aforementioned accidental hitting (never had that problem... in fact,
    until I read it hear, I didn't realize Outlook even had that option.
 2. In all other Win32 apps with drop down AutoComplete, you can use the arrow
    keys to select the option you want, and then hit Ctrl+Enter to select it.
    This currently doesn't work in Mozilla (I was looking to see if there was
    already a bug on this when I found this bug).

Comment 67

[Ben Bucksch (:BenB)]

Kovu, jake, read above. Alt is reserved.

Comment 68

[Jacob Steenhagen]

> move away from Alt as shortcut and leave this for menmonics only

I assume that's what's being refered to above... That's fine.  Make the Send
button have a menmonic of "S" (as Outlook does).

Comment 69

[scottputterman]

marking nsbeta1=, moving to mozilla0.8.  This is for putting back Ctrl-Enter.  A
hidden pref to turn it off is fine.

Comment 70

[Sheela Ravindran]

change qa contact

Comment 71

[Ninoschka Baca]

Reassigning QA Contact to nbaca.

Comment 72

[Blake Ross]

Tens of millions of AIM, Netscape 3.x/4.x, ICQ, AOL, and Outlook users have 
this shortcut ingrained in their brains.  We really shouldn't change it.

Comment 73

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 64661 has been marked as a duplicate of this bug. ***

Comment 74

[Gervase Markham [:gerv]]

Just as an additional note - I've been suffering from "accidental mail send" in 
NS 4.x for several years, and couldn't ever work out which key combo it was that 
I was accidentally hitting! Now I've read this bug, I know...

Believe me, Ctrl-Enter problems are probably more widespread than you think - 
people just blame it on "the software playing up" - I know I did for a while.

By the way, why aren't we having total UI key rebindability, like in e.g. Word 
or a decent editor? Surely XUL makes this reasonably easy; then we wouldn't have 
to have a special hidden pref for every key someone didn't like...

Gerv

Comment 75

[Moses Lei]

Right now, it looks like most people want this:

1. User installs Mozilla.
2. user writes an email message, and presses ctrl+enter.
3. Dialog pops up:

+------------------------------------+
|Do you wish to send the message now?|
|                                    |
| [ ] don't ask me this again        |
|                                    |
| [OK]           [Cancel]            |
+------------------------------------+

4. if user checks "Don't ask me this again" and clicks OK, from now on
ctrl+enter won't pop up the dialog but will immediately send the message.

5. if user checks "Don't ask me this again" and clicks Cancel, from now on
ctrl+enter won't do anything.

6. In addition, there will be a pref for this.

For bonus points, the pref could be a drop-down list for which key binding you
want for send:
- None
- Ctrl+enter
- Alt+enter
- Alt+S
- F6 or whatever

Is my summary accurate? Please comment if not.

Comment 76

[timeless]

f6 is *very* unavailable.

Comment 77

[:deanis74]

I like the basic dialog, but shouldn't the buttons be:

  Windows: Yes      No
  Mac:     Send     Don't Send
  Linux:   ???      ???

Timeless: What's F6 used for (just curious) ?

Comment 78

[Akkana Peck]

Re the last few entries: You probably want to look at bug 18508 (fix regression
to let user specify keybindings) and bug 57805 (UI for custom key bindings).

Comment 79

[Akkana Peck]

The dialog sems fine (make the buttons on linux the same as the mac ones) as
long as it has "remember this", as it does in the example.
Re mapping the keybinding to something else: we have no way of saving the result
unless 18508 is fixed.

Comment 80

[timeless]

ie5.5's definition:
<tr><td>Move forward between frames.</td>
<td>CTRL+TAB or<BR>F6</td></tr>

nc4.x's definition is at least slightly confused. you should encounter the bug 
where i described it. references include: bug 30864, bug 48251, bug 35134

Please read /your/ bug 30864 esp my Comments 2000-08-01 22:31 and 
[e-mail] 2000-08-11 20:08.

to borrow law's phrase: Oh dear. I'm removing [f6 from consideration] for 
obvious reasons (I hope).

Comment 81

[Ian Tommins ('thelem')]

I strongly support Moses Lei's idea from 2001-01-10 14:17.

It seems the only method which will make everyone happy:
 - CTRL + Enter, a widely used shortcut is supported.
 - There is only ever one dialog box for people who want this function
 - People who don't want this function can easily disable it, and should never
accidentally send a message.

You shouldn't need to go into the preferences to setup your keyboard bindings.

Comment 82

[[e-mail]]

How would this interact with the autospell pref? As there is currently no way to
detect an aborted spell, a prompt here would be very useful.

Comment 83

[timeless]

in nc4 if you have spell check on send set then it will spell check on 
ctrl+enter, and if you abort the spell check the send will abort.

That is NOT part of this bug, spell check issues are covered in other bugs, and 
since we have no spell check engine [another bug] it is certainly not relevant 
here.

Comment 84

[scottputterman]

moving to mozilla0.9

Comment 85

[scottputterman]

marking nsbeta1- and moving to future milestone.

Comment 86

[Gervase Markham [:gerv]]

This bug is mostfreq. Nominating for mozilla1.0.

Gerv

Comment 87

[:deanis74]

<spam>
OK, this bug cracks me up.  It's the perfect example for people who argue 
against open source:

1. Start with a simple task.
2. Allow everyone to comment.
3. Keep going in circles for well over a year.
4. Keep pushing it off to later and later dates.

Sorry, it's just that everytime I see this getting pushed off yet again, I laugh 
a little more.
</spam>

Comment 88

[Jean-Francois Ducarroz]

Even if we would not have pushed this bug again, we would not have been able to
go forward with it until bug 50255 is fixed. Once bug 50255 is fixed, we will
look again closely at this one. Until then, we have way much more other
important stuff to fix.

Comment 89

[scottputterman]

Bringing back nsbeta1+ to have some accelerator that can send a message.

Comment 90

[scottputterman]

moving to mozilla0.9.1

Comment 91

[varada]

Re-assigning to varada

Comment 92

[varada]

Marking dependant on 76891 - Ctrl-Enter event is not being recognized on Windows.

Comment 93

[scottputterman]

moving to 0.9.2

Comment 94

[Oliver Klee]

*** Bug 79142 has been marked as a duplicate of this bug. ***

Comment 95

[Blake Ross]

*** Bug 83022 has been marked as a duplicate of this bug. ***

Comment 96

[Christopher Blizzard (:blizzard)]

What's going on with this bug?  Even in win32 is broken we should get the
functional part of the patch in for mail/news.  It might motivate people to get
win32 fixed.

Comment 97

[Ian Tommins ('thelem')]

Does this code work other than the CTRL+Enter being broken (i.e. if it was
changed to a different key combination then would it work)?

If so, then I see no reason not to check this in when the tree branches.

Comment 98

[scottputterman]

moving to 0.9.3

Comment 99

[Ben Sandberg]

Can this keyboard shortcut be implemented, or is no one willing to do it?  It
seems to me that Moses Lei proposed the right idea (2001-01-10 14:17), but it
keeps getting pushed further and further out.

I think at this point, it should either be implemented, or scrapped entirely.

Comment 100

[scottputterman]

moving to 0.9.4

Comment 101

[kmurray1115]

So if this is in 9.4, how can the bug this depends on (50255) be in 9.5?

Comment 102

[[e-mail] (gone - use [e-mail] instead)]

Rod spears moved it up on the 21st to 0.9.5 from 0.9.4.

Comment 103

[kmurray1115]

Fine, but let's move the bugs this depends on up as well.

Comment 104

[Scott MacGregor]

this isn't going to hold up the .9.4 branch so moving to .9.5. We'll work with
Rod to fix  50255 and then consider the fixes for the eMojo branch.

Comment 105

[Scott MacGregor]

Looks like there's another dup of this bug over in: 56696 which also has a patch.

Comment 106

[selmer (gone)]

How does this ancient bug that shipped with 6.1 suddenly become *critical* for
the current release?

Comment 107

[kmurray1115]

I'm actually amazed that we didn't plus or move up the last bug that this
depends on: bug 50255, and it looks like 56696, where the patch resides, needs a
review. Here's the deal: We continue to not have a keyboard accelerator for
sending a mail message. I may turn this into a personal vendetta on open source
if we don't get this fixed soon. :-) The fact is, this *is* critical for any
release we might do, be it Netscape commercial or a mozilla milestone. This has
swirled for *years,* and I think we're close if roc+moz's patch in 56696 flies.
Updating summary to remove resolved dependency (50252).
If someone thinks this should be a dupe of 56696, please mark it so.

Comment 108

[Jaime Rodriguez, Jr.]

Adding correctness Status Whiteboard, correct/expected behavior does not occur.

Comment 109

[Scott MacGregor]

*** This bug has been marked as a duplicate of 50255 ***

Comment 110

[Scott MacGregor]

sorry about that. ignore that. I was trying to bring up bug 50255 and typed in
the wrong field =).

Comment 111

[Jaime Rodriguez, Jr.]

Nobody has touched 50255 in a month, and it does not have nsbranch+. This looks
like a polish bug, that it is too late to resolve. PDT-

Pls feel free to bring this to the PDT if you have a fix, and strongly belive
this is a stop ship bugger.

Comment 112

[Grey Hodge (jX)]

Do we have any key-combination that sends the mail, or is this mouse-only? If
there's a keyboard send function, I think that it's not as big a deal as it
would be with no way to send from the keyboard.

Comment 113

[bill]

now that I'm actually USING Netscape 6.x, I find this bug really annoying.

I don't need to use the mouse to type a message, why do I need it to SEND a
message.  I really liked that funcationality in Netscape 4.x (or every other
mail client, for that matter).

Please, someone, add the accelerator.  It's been almost 2 years waiting for this
minor-but-frustrating bug to get resolved.

Comment 114

[Johnny Proton]

I agree.  It is the little interface issues that are holding people back from 
using Mozilla.  Every power-email-user I know EXPECTS to be able to send email 
by that key combo.

I couldn't care less if there is a pref to turn it off though.  Save that for later.

Comment 115

[Daniel Veditz [:dveditz]]

There is a non-mouse way to send: Alt-F, d   It's a three-key, two-stroke combo
and I hate it (especially when menus are being slow) but it's better than using
the mouse.

Comment 116

[kmurray1115]

I think there is general agreement that this is badly needed. This relies on bug
50255 and the engineer that owns that bug is pretty doomed with other work. If
we truly want this bug, someone needs to help get 50255 fixed, which as I
understand it, is high-risk and fairly complex. Anyone wanna help rods fix 50255?

Comment 117

[:deanis74]

If someone can tell me where 50255 is at, and even better provide a test case
for all keys that are currently broken, I can take a run at it.  No promises,
though.

Comment 118

[Scott MacGregor]

I'm minusing this bug at this time because we need a fix for 50255 and it looks
unlikely that that fix is going to happen in time for eMojo. 

Comment 119

[Kathleen :Brade]

Reminder:  this bug has evolved into "when ctrl-enter sends a message, please 
make a preference to disable the keybinding for those of us who are prone to 
accidentally pressing accelerator-enter when typing text"

Strictly speaking, it's not dependent on #50255 (but #56696 is).

Comment 120

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This bug was fixed with my checkin for bug 56696 (my patch brings up a warning
dialog box when you press Ctrl-Enter; there is a checkbox in the dialog which
activates a pref to disable the dialog permanently).

However, bug 50255 means the feature still doesn't work on Windows. If you're
using Windows, please direct your votes and attention there.

Maybe we should leave this bug open until 50255 is fixed, so people can find
this before they submit a duplicate bug.

Comment 121

[Kathleen :Brade]

I thought the dialog that came up had a checkbox that was for never opening the 
dialog again.

This bug is for allowing users to essentially disable the keybinding (have it 
never send a message).  Do we need another checkbox or a set of 3 radio buttons:
  o Always prompt me
  o Don't prompt me, send anyways
  o Don't prompt me, don't send
(wording to be revised of course)

Comment 122

[sairuh (rarely reading bugmail)]

from seth in bug 56696, 2001-10-01 12:01 comments:

jglick, the current dialog has a checkbox to allow the user to disable the 
confirmation dialog.

[ ] Do not show me this dialog box again

is currently hooked up to the "mail.warn_on_send_accel_key" pref.

I think that showing the alert is a good idea to prevent the user from sending 
before they meant to.

"Send the message now?", what about if we are offline?  
In that case, ctrl+enter is really going to be doing a "send later".

Comment 123

[Christopher Blizzard (:blizzard)]

I think that if you're offline that you have to use ctrl-shift-enter to activate
Send Later.  It doesn't seem to be smart enough to automatically change the binding.

Comment 124

[Christopher Blizzard (:blizzard)]

Oh, and I think that there should be something in the pre UI to set this setting
by hand.  Right now to get the dialog back you have to edit the config file
manually.

Comment 125

[(not reading, please use [e-mail] instead)]

as far as I understand this bug, we'd need another pref to disable ctrl+enter 
from sending the message.

the existing pref (that roc added) is only for controlling if we show the 
warning dialog or not.

Comment 126

[(not reading, please use [e-mail] instead)]

the UI issues for the new warning dialog are covered in bug 
http://bugzilla.mozilla.org/show_bug.cgi?id=102643

there is a UI issue, if we add a pref to allow the user to disable ctrl+enter 
all together.  see #102643 for that issue.

Comment 127

[Olga]

*** Bug 113116 has been marked as a duplicate of this bug. ***

Comment 128

[Oliver Klee]

Replacing duplicate with the real bug number.

Comment 129

[scottputterman]

I'm going to move this out.

Right now Ctrl+Enter works. There is a confirmation dialog.  There is a pref to
turn that confirmation dialog on or off by going into the main mail pref panel.
 Those who want  Ctrl+Enter to work all the time can turn the confirmation
dialog off. Those who are worried that they might press Ctrl+Enter accidentally
can turn the confirmation dialog on.  The only case we haven't solved is the
case where someone might hit Ctrl+Enter followed by an Enter accidentally and
unintentionally send the message.  I think that case isn't too likely and
doesn't warrant adding an additional pref in the near future if ever.

Comment 130

[laurel]

*** Bug 133859 has been marked as a duplicate of this bug. ***

Comment 131

[Peter Lairo]

Based on the reasons given in comment #129 this bug is about a trivial as can
be. Suggest to change Priority to "P5" and Severity to "Enhancement".

Comment 132

[timeless]

.

Comment 133

[:deanis74]

Suggest marking worksforme.  If the string of events in comment 129 actually
turns out to be a big problem, it can be addressed in a new bug.

Comment 134

[Olga]

I remove nsbeta1- keyword - it was for MachV.

Comment 135

[Olga]

Now I add 'nsbeta1' keyword for Buffy. Sorry, it's faster to edit multiple bugs
at once than manually go to each and remove minus.

Comment 136

[Moses Lei]

The way to address comment #129 is to make "Don't send" the default button in
the confirmation dialog, thus making the sequence C-enter enter do nothing.

Let's close this bug!

Comment 137

[(not reading, please use [e-mail] instead)]

taking all of varada's bugs.

Comment 138

[Daniel Veditz [:dveditz]]

Ctrl-Enter is not sending in build 2003032611. I have no idea when this might
have regressed, but 1.3 final worked fine.

removing nsbeta1- for re-consideration, this was a big deal for many of the 4.x
holdouts and they will not like it going away again.

Comment 139

[Simon Fraser [no longer active]]

Crl-Enter not working is bug 198976.

Comment 140

[Mike Fedyk]

I can tell you that it did work on 20030303 but it isn't working in Mozilla/5.0
(X11; U; Linux i686; en-US; rv:1.4a) Gecko/20030326 and 1.3 is 20030312, so it's
sometime between those dates.

Comment 141

[Thomas Winteler]

hi all..

have Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a) Gecko/20030401 and
ctrl+enter doesn't work in the message body.. it work in the subject line and in
the adress (to, cc,..) line... but not in the message body...

thomi

Comment 142

[Dave T]

Hi everyone,

I'm a newbie to bugzilla, and found this bug while trying to figure out why my 
ctrl-enter stopped working after i upgraded to Mozilla/5.0 (Windows; U; Win 9x 
4.90; en-US; rv:1.4a) Gecko/20030401.  I'm very impressed with how many years 
of effort you guys have put in to a simple shortcut key!

Anyhow, the prob is exactly as described in comment #141, I'm guessing the ctrl-
enter is somehow trapped by the compose front-end when the cursor is in the 
main text panel, as it results in a carriage return on the page.  This might 
mean a bug needs to be submitted to the people who work on that bit.  (I don't 
know exactly where though - so if someone else a bit more experienced wants 
to... feel free!).

Also it should be displayed in the file menu as 'ctrl-enter' in win9x, 
not 'ctrl-return'.

Comment 143

[Dave T]

oops, 
ctrl-enter not working is bug #198976, and appears to now be fixed
incorrect menu text is bug #106327 
apologies for spam while i learn how to use bugzilla :(

Comment 144

[Ian Tommins ('thelem')]

This has been fixed for ages.

Comment 145

[Kathleen :Brade]

reopening bug
If indeed this bug is fixed, the pref for NOT sending a message should be listed
in the bug somewhere.  A quick scan of all recent comments does not list the pref.

Comment 146

[Ben Bucksch (:BenB)]

brade, the dialog which comes up when you press Ctrl-Enter has a checkbox "Do
not show me this dialog box again".

Comment 147

[Ben Bucksch (:BenB)]

brade, the dialog which comes up when you press Ctrl-Enter has a checkbox "Do
not show me this dialog box again". There is also a checkbox in the Prefs
dialog: "Mailnews|Composition|Confirm when using keybord shortcut to send message".

Comment 148

[Daniel Wang]

Please open a new bug for any regression bug.