Closed Bug 216133 Opened 22 years ago Closed 21 years ago

Message pane indicator for blocked image

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird0.8

People

(Reporter: mscott, Assigned: mscott)

References

(Depends on 1 open bug)

Details

Attachments

(7 files, 1 obsolete file)

Example of how Outlook 2003 allows you to see messages
84.15 KB, image/jpeg
Details
patch of work in progress
15.06 KB, patch
Details | Diff | Splinter Review
preference change to show a broken icon for blocked images
760 bytes, patch
Details | Diff | Splinter Review
new screen shot with broken image & border
31.68 KB, image/png
Details
patch
1.16 KB, patch
Details | Diff | Splinter Review
add ability to use an address book as a white list
13.17 KB, patch
Details | Diff | Splinter Review
screen shot of the new pref option
7.80 KB, image/png
Details
through the options dialog you can block all incoming images for messages. It would be great if we had some icon we could show in the message pane when the message contained blocked images. You should be able to press this icon to reload the message, unblocking the images for that message only.
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird0.4
This is similar to #215959. I suggest we combine the two.
Sounds even like a dupe
QA Contact: asa
*** Bug 215959 has been marked as a duplicate of this bug. ***
Although it should be noted that bug 215959 is a bit more thorough in the proposed implementation of this feature.
Target Milestone: Thunderbird0.4 → Thunderbird0.6
Jake can you or someone else post a screen shot of outlook showing this in the message pane?
I've attached a picture, showing the basic functionality in Outlook. You get a message in the top of the preview window and also, for each blocked picture. Clicking on the message shows a context menu, where you can view the images.
moving out new feature work
Target Milestone: Thunderbird0.6 → Thunderbird0.8
*** Bug 230916 has been marked as a duplicate of this bug. ***
Scott: What does #7 mean? Bug 225147 has a different take on this. It's not a dupe, but covers similar ground.
OS: Windows XP → All
Hardware: PC → All
Depends on: 245280
I'm pretty close to having a workable patch for this feature. Moving the milestone into 0.7 Remaining issues: 1) Currently when mozilla blocks an image we don't show the image on the web page (that means no border and no broken/blocked icon in the image window). This is the desired behavior when blocking images from a web page. However if you are a mail client showing a message with blocked images we really want to have a border and a blocked image in place of the image. So we need a custom way to make that happen in nsImageFrame. 2)We need the new content policy patch ported to the aviary branch for my new code to work. 3) I need to get some qute based artwork for the blocked image status bar in the message pane. 4) There are more remote elements than just img src tags that we want to block. Over time we'll want to add more and things to use the content policy APIs to verify if the element can be loaded.
No longer depends on: 245280
Target Milestone: Thunderbird0.8 → Thunderbird0.7
Depends on: 245280
Attached image screen shot of the work in progress (obsolete) —
1) The delete icon is just provisionary artwork until I can get a new icon 2) The background color is provisionary as well. Still experimenting. It might be nice to find a complimentary gradient color to the junk bar's background color (the dark blue) Someone else might be able to come up with some prettier CSS for this box but it gives you an idea. As you can see from the screen shot, currently for a blocked image, gecko doesn't show a border or a broken/blocked image.
How about "Show Images" instead.
Thanks for the "Show Images" text suggestion. I like that a lot. Here's a patch of the work in progress. Still to do for the UI portion: 1) If a message is marked as junk, dont' show the remote content status bar. We already render the HTML stripped of any remote content. So there is no need to show both status bars.
This feature will also protect user's privacy from things like: http://didtheyreadit.com/
Depends on: 245360
Depends on: 245361
Is this also planned for Seamonkey's Mail & News? Does a bug exist for that?
*** Bug 245550 has been marked as a duplicate of this bug. ***
*** Bug 245803 has been marked as a duplicate of this bug. ***
Thanks to a tip from Boris, setting network.image.imageBehavior makes layout show a broken icon + a border around the image instead of a blank space for blocked images. This only works for the case where the content policy manager returns REJECT_REQUEST which is fine for Thunderbird right now. It gets us started.
Attachment #149810 - Attachment is obsolete: true
Target Milestone: Thunderbird0.7 → Thunderbird0.8
*** Bug 249145 has been marked as a duplicate of this bug. ***
The current patch forces a minimum width of the message pane (in vertical view layout). On my 1024px screen the message pane expands when showing the box, and shrinks back after I clicked "Show Images". Solution: The text should wrap to obey the current message pane width.
yuck, that really is gross in the vertical view. I'm not sure how we can force the privacy xul box to wrap.
Maybe bug 241705 can be of help here, since the attached screenshot shows a wrapped message.
> I'm not sure how we can force the privacy xul box to wrap. talked to mscott about this over aim, and we have a patch.
landed that last patch on tbird trunk and aviary 1.0 branch
That last patch is great, confirming it fixed the issue. Next up would be a whitelisting feature (again, like in Outlook 2003). They have the options (translated from German) "Add sender to trusted senders" and "Add domain to trusted senders". That way I could unblock my Daily Dilbert mails.
*** Bug 251539 has been marked as a duplicate of this bug. ***
Blocks: 252073
*** Bug 252073 has been marked as a duplicate of this bug. ***
(In reply to comment #27) > Next up would be a whitelisting feature (again, like in Outlook 2003). They have > the options (translated from German) "Add sender to trusted senders" and "Add > domain to trusted senders". Is there a bug raised for this? I made a little search but couldn't find it immediately.
On one of my machines the status bar remains after clicking "Show images" until i leave the folder (either for another folder or the account's root node). Can someone imagine a cause for that?
Finishing touch before I close this bug out. 1) Enable remote image blocking by default 2) Add pref UI for also allowing an address book to be used as a white list. Defaults to on as well. 3) Make the content policy code smart enough to look the recipient up in the white list checking for a match when we encounter a message with remote images.
The white list stuff has been checked into the branch and trunk. Remote image blocking is now on by default. Marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Is there a complimentary Mozilla Suite bug in reference to this same issue? Is this patch going to be applied to the Mozilla Suite builds as well ??
*** Bug 254323 has been marked as a duplicate of this bug. ***
I just discovered this (great) feature, and have one suggestion regarding the whitelist: I have noticed that enabling images for newsletters i get regularly (i get a lot of newsletters) can be a hasstle. Although the addressbook whitelist may be the technically simpler solution, it is the less useful one. Most messages that contain _remote_ images come from newsletters and the sort. These are typically from addresses that are _not_ in an addressbook. Also, (admittedly a minor issue) users (like me) may have more than one addressbook, and the UI doesn't account for that. I would therefore suggest to create an explicit whitelist that users can _easily_ add to. The UI could look like this (add "Always Allow" button): X To protect your ... [ Always Allow \/ ]_[ Show Images ]________________ | Images from this e-mail address (Daily@CNET.com) | | Images from this domain (CNET.com) | |--------------------------------------------------| | Edit remote images whitelist | +--------------------------------------------------+ The tooltips for the two buttons could explain what they do: - Always Allow: Add e-mail address or domain to a whitelist - Show Images: Show remote images for this message PS. Please give this whitelist file a sensible filename (e.g., RemoteImagesWhitelist) ("key3.db" anyone?). ;)
(In reply to comment #37) > RemoteImagesWhitelist * RemoteImagesWhitelist.txt
*** Bug 227942 has been marked as a duplicate of this bug. ***
*** Bug 225147 has been marked as a duplicate of this bug. ***
The Show Images button/bar remains in the view when I select another email (one with no images). This is always repeatable. I am using TB 0.8 with an IMAP server.
Mozilla builds ? Will someone implement this for those builds?
*** Bug 236311 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: