Closed Bug 22174 Opened 26 years ago Closed 25 years ago

go/back/fwd menus blank for file: and ftp: urls

Categories

(Core :: DOM: Navigation, defect, P1)

Product:
Core
Component:
DOM: Navigation
Platform:
x86
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: Crysgem, Assigned: law)

References

Details

(Whiteboard: [nsbeta2-][nsbeta3+][medium])

Attachments

(1 file)

Sets title in directory.js's Init() function
574 bytes, patch
Details | Diff | Splinter Review
Mozilla build ID: 1999121915 Cause the beast to display a document with a (properly-parsed) title - then to load an FTP directory. The string displayed in the window titlebar will be that of the previous HTML page, rather than the appropriate FTP banner.
Assignee: rickg → valeski
Component: Parser → Browser-General
Jud -- I'm not sure what mechanism you're using for this, but I don't believe this is a parser issue.
Assignee: valeski → donm
not sure how this got to rickg.
Assignee: donm → don
Assigning from donm to don, jud has just been enlightened that don melton is not donm
really
Assignee: don → law
Target Milestone: M15
Bill, is this a bug for you?
Status: NEW → ASSIGNED
I think the only title setting done currently is driven from the back-end code when it encounters the <title> tag (or end of <head> regardless of whether there was a <title> tag?). Thus, no title is set in the case of ftp directories (or plain text files, apparently). This is a bit messy to deal with. We have to somehow make sure we set some title in all cases yet not reset a real document title.
*** Bug 22323 has been marked as a duplicate of this bug. ***
*** Bug 22735 has been marked as a duplicate of this bug. ***
*** Bug 23337 has been marked as a duplicate of this bug. ***
I hope the title is gonna be something like: "Directory /mirros on sunsite.org.uk" instead of just like in Netscape 4.7 "Directory of /mirros"
*** Bug 23487 has been marked as a duplicate of this bug. ***
With the attached patch, the title becomes "Directory of <URL> - Mozilla" when a ftp directory (or a local directory, see bug #24848) URL is loaded. Note that I hardcoded the "Directory of " string portion of the title, which I know is a Bad Thing(TM), but I don't know how to create a label suitable for localization.. hope this helps anyway.
borto: thanks for the patch, I'll give it a whirl today. FYI, the way to add "hard coded" strings is to factor them out into a DTD file.
*** Bug 24848 has been marked as a duplicate of this bug. ***
*** Bug 29087 has been marked as a duplicate of this bug. ***
Could we have some better text than "Directory of <URL>". Considering that we can show filesystem directories and (someday) LDAP directories, I think we should add some FTP identifier. How about "FTP Directory of <URL>"? :-)
*** Bug 34480 has been marked as a duplicate of this bug. ***
Move to M16 for now ...
Target Milestone: M15 → M16
*** Bug 27360 has been marked as a duplicate of this bug. ***
Target Milestone: M16 → M18
*** Bug 39870 has been marked as a duplicate of this bug. ***
This behavior also occurs when viewing your local filesystem, too. 1. Go to a web page that sets the title 2. In the URL box type: c:\ (or /, or whatever your filesystem may use) Notice the title hasn't changed.
OS: Windows 98 → All
Move to M21 target milestone.
Target Milestone: M18 → M21
*** Bug 38504 has been marked as a duplicate of this bug. ***
for reference, 4.7 titles the pages for file/ftp as follows, respectivly: Directory listing of %s Directory of %s These should probably be changed slightly... maybe... Directory listing of /home/x FTP listing of /pub/x on ftp.x.org Note also that history is totally screwed, probably because of title not being set. I think theres a seperate bug for that, maybe deps should be set, but if there isn't, briefly: go to a file: url. load a file. click back. won't work. it reloads the current file, instead of going back to the listing. This is making file and FTP pretty much unusable. M21 target needs to be rethought.
Summary: Title data as displayed in bar not updated upon FTP loading → Title data as displayed in bar not updated on FTP/file loading
*** Bug 43436 has been marked as a duplicate of this bug. ***
*** Bug 32913 has been marked as a duplicate of this bug. ***
updating summary to reflect the more generalized problem, adding mostfreq kw, and sending to history
Component: Browser-General → History
Keywords: 4xp, mostfreq
QA Contact: janc → claudius
Summary: Title data as displayed in bar not updated on FTP/file loading → Title data of FTP sites is stored wrong in session history
Severity: minor → normal
IMHO this should've been nsbeta2+ long ago(my bad) because of the bad ramifications (like dupe bug 32913). Namely Back+ Forward won't work for FTP (and prolly file) URL's. If you click 'Back' the page just appears to reload. It will do this for as many times as FTP url's were loaded and then it will go back to the most recent non FTP url. upping severity to major since with have a major loss of function w/no known(to me) workaround. Suggest we reconsider Priority and Target Milestone as well.
Severity: normal → major
Keywords: nsbeta2
Putting on [NEED INFO] radar. PDT needs to know impact to user and risk of fix to make a call on this bug. Is this causing problems with the session history or is this bug just about not storing title data correctly? Please explain the problem and log a new bug if we are talking about two issues here.
Whiteboard: [NEED INFO]
I'm not sure that this bug is the cause of the back and forward problems. The only problem here, afaik, is that the title isn't stored correctly in the SH. Radha can elaborate more..
This bug is not related to the Back/forward button problems we have today. I'm not sure the patch submitted will work right with session history. Did anyone try the patch?
Not the back/forward problems today, the ones that claudius mentioned. I'll try the patch.
Setting to nsbeta2- radar per PDT mtg for Nav beta2 review today.
Whiteboard: [NEED INFO] → [nsbeta2-]
adding relnote2 keyword. It'll say something like "The Back and Foward buttons completely ignore ftp:// url's"
Keywords: relnote2
nav triage team: nsbeta3+ reworded summary
Summary: Title data of FTP sites is stored wrong in session history → session history back/fwd ignores FTP sites
Whiteboard: [nsbeta2-] → [nsbeta2-][nsbeta3+]
I think the new summary is misleading, because we have two different bugs here: back/fwd don't work with FTP sites, and the titles of FTP sites are stored wrong in SH. I don't know if the two bugs are related...law? radha?
Adding nsbeta3 keyword to bugs which already have nsbeta3 status markings so the queries don't get all screwed up.
Keywords: nsbeta3
I've changed the summary. All is well (I think) except for the fact that the Go menu and the back/forward menu buttons have blank items for all file: and ftp: urls. This is due to not setting up the SH entries properly, I presume. Should be relatively easy to fix. BTW, I'm not anxious to try to come up with fancier "Directory of" kind of titles. What you see (on the title bar) is what you'll get.
URL: ftp://ftp.mozilla.org/pub/mozilla/nig... → go/back/fwd menus blank for file: and...
Priority: P3 → P1
Whiteboard: [nsbeta2-][nsbeta3+] → [nsbeta2-][nsbeta3+][medium]
URL: go/back/fwd menus blank for file: and...
Summary: session history back/fwd ignores FTP sites → go/back/fwd menus blank for file: and ftp: urls
Blocks: 44114
I've checked in code that ensures that file: and ftp: directory URLs have SH entry titles. The title defaults to the URL since that is what appears in the title bar in such cases.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
VERIFIED fixed with 2000082208 builds
Status: RESOLVED → VERIFIED
Component: History: Session → Document Navigation
QA Contact: claudius → docshell
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: