250983 - "Close Window" (ctrl-shift-w) does not display confirm dialog when multiple tabs are open.

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Tobias Sager]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040626 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040626 Firefox/0.8


See bug 108973 for confirm dialog.
Bug 210639 reports and fixes this problem for mozilla. I still have it in
Firebird though.


Reproducible: Always
Steps to Reproduce:
1. Open new window with multiple tabs in it.
2. File->Close Window or Ctrl-Shift-W.


Actual Results:  
Window with all tabs closes.

Expected Results:  
Confirm dialog for closing window (as with pressing Alt-F4).

Comment 1

[Tobias Sager]

Add'l info: browser.tabs.warnOnClose is true and the confirm dialog comes when
pressing Alt-F4.

Comment 2

[Oleg Sidletskiy]

in Mozilla 1.7 this works properly, maybe the fix for Bug 210639 was not applied
to Firefox code?'

-> CONFIRMING

Comment 3

[DStile]

I'm seeing this behavior on Firefox Linux Official 0.9.1 Mozilla/5.0 (X11; U;
Linux i686; en-US; rv:1.7) Gecko/20040626 Firefox/0.9.1 and on nightlies from
7/10 as well. Setting to All OSes.

Comment 4

[Tom Hessman]

I also see this behavior on Mac OS X.
Build ID: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7)
Gecko/20040804 Firefox/0.9.1+

I filed a bug for a similar issue: bug 254401 - "Firefox -> Quit Firefox (or
File -> Exit) does not display confirm dialog when multiple tabs are open." 
These issues may be related.

CC'ing self.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Features should be consistent. Probably just a matter of running the two code
paths through the same function. 

Comment 6

[bugzilla]

Confirmed to be very annoying, it really ought to get fixed.  What an obnoxious
bug!  I finally found a defense against losing form data to accidental window
closes, and now there's a common typo (word-erasing in all caps) which overrides it.

Comment 7

[Ariel Burone]

This bug is similar to bug #220385 (but with a diferent point of view)

Comment 8

[Ariel Burone]

This bug is similar to bug #220385 (but with a diferent point of view)
And bug #254401 have some more information

Comment 9

[Leon Sha]

Attachment: Patch porting from 210639

Also fixed bug 254401.

Comment 10

[José Jeria]

*** Bug 261335 has been marked as a duplicate of this bug. ***

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 159929 [details] [diff] [review]
Patch porting from 210639

please get reviews before requesting approval. thanks.

Comment 12

[Ariel Burone]

found an extension who does that
http://gorgias.de/mfe/#tabwarning

Comment 13

[Mike Connor [:mconnor]]

Comment on attachment 159929 [details] [diff] [review]
Patch porting from 210639

ok, r=[e-mail]

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 159929 [details] [diff] [review]
Patch porting from 210639

a=asa for aviary checkin.

Comment 15

[chris hofmann]

need to get this in soon if we are going to take it.

Comment 16

[Asa Dotzler [:asa]]

Leon, do you have cvs access? I see a Leon Zhang has cvs access, but it doesn't
appear that Leon Sha has access. 

Comment 17

[:Gavin Sharp [email: [e-mail]]]

*** Bug 254401 has been marked as a duplicate of this bug. ***

Comment 18

[HARUNAGA Hirotoshi]

*** Bug 263224 has been marked as a duplicate of this bug. ***

Comment 19

[Leon Sha]

(In reply to comment #16)
> Leon, do you have cvs access? I see a Leon Zhang has cvs access, but it doesn't
> appear that Leon Sha has access. 

I do not have cvs access. So can anyone help to checkin this?

Comment 20

[Steffen Wilberg]

Checked in br & trunk.

Comment 21

[Steffen Wilberg]

*** Bug 225829 has been marked as a duplicate of this bug. ***

Comment 22

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 200410150x-0.9+ builds on linux fc2 and mac os x 10.3.5.

Comment 23

[Jeremy M. Dolan]

*** Bug 264558 has been marked as a duplicate of this bug. ***

Comment 24

[Jo Hermans]

*** Bug 265918 has been marked as a duplicate of this bug. ***

Comment 25

[Roman Frolow]

No warning when there are only pinned tabs.