Closed Bug 257285 Opened 20 years ago Closed 16 years ago

Live Bookmark wont display 'Open in Tabs' with dynamic loading

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Version:
1.0 Branch
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED WORKSFORME
Milestone:
Future

People

(Reporter: quark29, Unassigned)

References

Details

Spinoff/consequence from bug 253698.

If you open a Live Bookmark folder (I'm doing it from Bookmarks Toolbar Folder)
while it's loading, upon finishing it will update the display with the links
dynamically.  However, the seperator and 'Open in Tabs' then fails to display
until you reopen the folder.

This may or may not be related to bug 252412, as both seem to involve a Live
Bookmark updating.
Ugh. The issue here is that that there's only one item in the folder when the
submenu is first opened, so open in tabs doesn't display.. but then we
dynamically add more items when the feed parses.  Not sure if it's worth bandaiding.
there are 2 more of these issues....

Open bookmarks after a while browsing

repro: 
1. be lucky to check the Live Bookmark folder while it auto-refreshes
2. notice after refresh the separator between the bookmarks and "open in tabs"
has moved to the top of the bookmark folder

---------  <-- wrong position
live bmk 1
live bmk 2
live bmk 3
Open in Tabs

3. go back to the live bmk folder and context menu "Refresh Live Bookmark" to
attempt to restore the folder
4. this partially succeed, the separator goes to it's normal place, but
unfortunately a second on is added.


live bmk 1
live bmk 2
live bmk 3
---------  <-- second separator
---------
Open in Tabs

Any next refresh, automatic or via context menu will leave the folder with the
double separator

Tell me if I need to file a separate bug for it or if you want to keep these 3
minor issues together Vlad ?


I also occasionall see

---------  <-- wrong position
live bmk 1
live bmk 2
live bmk 3

This also happens when you open the folder, invoking a refesh.
"Open in tabs" is missing, reopening the folder (comment #0) does not help

(In reply to comment #1)
> Ugh. The issue here is that that there's only one item in the folder when the
> submenu is first opened, so open in tabs doesn't display.. but then we
> dynamically add more items when the feed parses.  Not sure if it's worth
bandaiding.

The by far simplest workaround would be to add 

the separator
open in tabs

by default in the live bookmark folder

99.999% of the feeds have more than one link anyway.

change open in tabs 
to open in tab(s)

and no one will have a reason to complain/file a bug.

this would also solve the problem when the refresh takes place.

I can also get some of this behavior to happen with normal bookmarks. 
Specifically this:
bookmark
bookmark2
bookmark3
---------  <-- second separator
---------
Open in Tabs

Steps to reproduce:
1)Have a Folder in your Bookmarks Toolbar Folder (easiest location).
2)Right click the Folder, select "New Folder".  Fill in anything for name.
3)Left click the original folder, right click new folder.  Select "New Bookmark"
or "New Folder" (it doesn't matter), and create again.
4)Left click original folder, there's an extra seperator and the new folder or
bookmark is missing.  Bookmarks Manager/Sidebar show them correctly.

With this you can keep adding on more seperators to your hearts content.  Note
that only the CURRENT window is affected, and restarting Firefox fixes the glitch.
*** Bug 258127 has been marked as a duplicate of this bug. ***
(In reply to comment #6)
> *** Bug 258127 has been marked as a duplicate of this bug. ***

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040904
Firefox/1.0 PR (NOT FINAL)

With the two latest nightlies I've used (0903 and 0904), I've had simiar issues.
After browsing for a while, and checking my Live Bookmarks every now and
then, they tend to end up partially fouled up.

More specifically, when hovering over a Live Bookmark folder, the separator that
follows the bookmarks and which is followed by the "Open in tabs" command ends
up on top of the bookmarks list, as previously mentioned. Worse yet, if I close
and then open the same
folder again, the "Open in tabs" command vanishes as well! This condition
remains as long as the browser isn't restarted.

Reproducible: Sometimes
Steps to Reproduce:
1. Make a few Live Bookmarks.
2. Browse for a while, and open them so they refresh a few times.
3. After a while, weird stuff sometimes happens: the separator that usually
separates the bookmarks from the "Open in Tabs" command get sent up to the top
of the bookmark list, and "Open in Tabs" vanishes altogether the next time the
folder is opened, as well.

Actual Results:  
Separator gets sent to top, "Open in tabs" vanishes.

Expected Results:  
The Live Bookmark folder should contain the bookmarks, followed at the bottom by
the one separator and its trailing "Open in tabs" command.

Shouldn't this be taken more seriously? This is a very blatant issue, and I
suggest we find a way around it before we hit the big one-oh, as it most
probably will turn off new users (especially converts from IE, which probably
haven't even used site feeds before, and having blatant bugs in our own support
will scare them away).
Flags: blocking-aviary1.0?
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040905
Firefox/1.0 PR (NOT FINAL)

WFM (guessing)

Somehow i'm unable to see this anymore.
All issues discusssed in this bug appear to have vanished.
At first I thought it was a coincidence, but after a good 12 hours of browsing
it's still not showing.
I'm still getting this.

Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040908 Firefox/0.10

Sadly, this is hard, if not impossible, to fix with the way things are currently
architected.
Flags: blocking-aviary1.0? → blocking-aviary1.0-
Target Milestone: --- → After Firefox 1.0
*** Bug 260764 has been marked as a duplicate of this bug. ***
> The by far simplest workaround would be to add 
> 
> the separator
> open in tabs
> 
> by default in the live bookmark folder
> 
> 99.999% of the feeds have more than one link anyway.
> 
> change open in tabs 
> to open in tab(s)
> 
> and no one will have a reason to complain/file a bug.
> 
> this would also solve the problem when the refresh takes place.
> 

I agree with this, why not always add the option "open in tabs" and the
separator. It's far more preferable than a inconsistent/faulty UI.

(In reply to comment #12)
> I agree with this, why not always add the option "open in tabs" and the
> separator. It's far more preferable than a inconsistent/faulty UI.

It wouldn't help; the result would be a menu that has a separator, "Open in
Tabs", and then all the live bookmark entries that got loaded.  This is more of
a core problem with the current content generation mechanism in XUL; it won't be
fixed in time for 1.0.  Sorry!

*** Bug 263625 has been marked as a duplicate of this bug. ***
Assignee: vladimir → vladimir+bm
*** Bug 304129 has been marked as a duplicate of this bug. ***
Assignee: vladimir+bm → nobody
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
this should be WFM actually since we only rebuild non static content
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090115 Shiretoko/3.1b3pre
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.