260849 - identify unread live bookmark items

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Live bookmarks should identify unread items -- e.g. making them bold or similar.
 We know when an item is unread by checking 1) the items LastVisitDate (which
won't be set on new items, also will get cleared when the livemark is reloaded);
2) by checking history.  These are the same operation, and this will get much
easier when we coalesce history and bookmarks post-1.0.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: identify unread patch (in progress)

This patch starts to add some of this support.	It doesn't work, due to
template builder issues, namely that it doesn't switch templates if a
more-restrictive one becomes valid while a less-restrictive one is active.  We
also have no way of imposing negative queries.

Also, I just realized that I can replace the ugly nsIURI-creating code by just
using the RDF datasource interface of history, not to mention removing the
docshell dependency, by just getting "rdf:history" and using my
already-existing resource with it.

Putting this patch here for when I get back to this later.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

*** Bug 261069 has been marked as a duplicate of this bug. ***

Comment 3

[Phil Ringnalda (:philor)]

*** Bug 259315 has been marked as a duplicate of this bug. ***

Comment 4

[Phil Ringnalda (:philor)]

*** Bug 272563 has been marked as a duplicate of this bug. ***

Comment 5

[Jonathan Avidan]

> also will get cleared when the livemark is reloaded

I have to disagree. Note that Firefox tends to reload the livebookmarks quite
often. In addition, no one wants his feeds to be mark as unread every time he
opens Firefox again. Once a feed is marked as read it should stay that way,
unless  we decide to have a context menu option of "mark as unread"

On a further note, if we do fix this - we shoudn't directly mark the feed as
bold but rather give it a certain class whose default style is text-weight:bold;
Thus other themes could have different appearances

Comment 6

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change

Comment 11

[Dietrich Ayala (:dietrich)]

Attachment: wip

working proof-of-concept patch. needs styling, localization, ltr, etc.

Comment 14

[Alex]

suggest for Rss:
not to show unread (bold), but to hide read completely.
Rss's older than current date may be --not shown at all-.
This is not what is suggested initially.

Comment 18

[Christopher Chan]

We may show a number beside each RSS feed title indicating the number of unread entries, and making the unread entries bold.

Comment 20

[Marco Bonardo [:mak]]

fixed by bug 613588, the status is tracked by the new icon.