302470 - Virtual folders in IMAP account with non ascii characters displayed wrong

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Anders Betnér]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Thunderbird 1.0+ (20050727)

If you create a virtual folder based on an imap search with a name with non
ascii characters it will show upp corectly in the UI, but at the next
application launch it won't be visible at all in the UI. At the launch after
that it will be visible but with its "I forgot it is unicode" view. (something
like Inbox-l&APY-ne)

Reproducible: Always

Steps to Reproduce:
1. Search for something in the search box
2. Choose "Save search as folder"
3. Pick a name like "Inbox-åke" (alt-0229 on windows)
4. Close TB
5. Open and verify that the folder is missing
6. Close TB
7. Open and verify that the folder shows up as "Inbox-&AOU-ke"

Actual Results:  
See step 5,7 above

Expected Results:  
The folder should show up as "Inbox-åke" (and preferably every time you launch TB :)

In my profile there are two folders after the second re-launch of TB.
"Inbox-&AOU-ke.sbd" and "Inbox-&-AOU-ke.sbd"
This might be similar to bug #271711 which was fixed before 1.0 was released.

Comment 1

[Anders Betnér]

Bugzilla might need some character set tweaking too. The ineligible character
above is å (press alt-0229 on windows if you have a crippled keyboard) 

Comment 2

[Mike Cowperthwaite]

Reproduced with TB 1.0+0725 and TB 1.0.5, Win2K.  This happens only when the 
folder is placed under the IMAP account.

There are additional problems.  The saved-search folder can occasionally (after 
restarting, and then selecting the folder) simply disappear, or lose its "saved-
search" status, then when selected, the client polls the server for the folder, 
can't find it, and deletes it.

Workaround: create the Saved Search folder under Local Folders.

Comment 3

[Anders Betnér]

I've just tried this on thunderbird 1.5 beta1 and the error is still there. I
don't know if the native English speakers realize the severity of this problem.
Most of these unusable characters are vowels. So the English equivalent of this
problem would be. "You can name your folder whatever you want, but you can't use
the letters 'e' or 'a'." Of course you can use the product with the limitation,
but it is a major annoyance. (apart from that thunderbird rocks :)

Comment 4

[u81239]

FWIW, as a member of the Dutch localisation team, I think this is very important too.

Comment 5

[Magnus Melin [:mkmelin]]

Seeing this on linux too. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051120 Thunderbird/1.5 ID:2005112006

Comment 6

[Christian Kalkhoff]

*** Bug 345819 has been marked as a duplicate of this bug. ***

Comment 7

[Scott MacGregor]

I think I've got a fix for this. 

Comment 8

[Scott MacGregor]

Attachment: escape and encode the folder name as utf-8

This makes the encoding for the folder name string we write out to disk match the encoding used for local folder saved searches in nsMsgDBFolder::AddSubfolder.

Since virtual folders never get sent to the imap server, it should be safe to not use modified utf-7 here (I hope).

With this patch, I'm able to create virtual folders with names like: Inbox-åke. Quiting and restarting shows the correct name in the folder pane. 

Although I'm still having problems trunk only where the folders aren't showing up until I toggle folder views. But that happens without this patch for me right now.

Comment 9

[Scott MacGregor]

fixed on the branch and trunk. Note: this works for new saved search folders, not folders you may have already created that contained non-ascii characters.

Would be great if we could get some testing feedback on this in beta 2 (when it comes out) or on a branch nightly.

Comment 10

[Magnus Melin [:mkmelin]]

This seems to be working fine on trunk.

However, branch is still very broken, removing fixed1.8.1.2. Tested on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2pre) Gecko/20070110 Thunderbird/2.0b1 ID:2007011003

After restart saved searches named XXåäö look like ABC&AOUA5AD2 or something similar.

Comment 11

[Scott MacGregor]

That's strange. And these are newly created saved search folders?

Comment 12

[Scott MacGregor]

The patch didn't get checked into the branch. I just corrected that :).

Comment 13

[Magnus Melin [:mkmelin]]

Looking good with todays build:)

Comment 14

[Anders Betnér]

I've given it a good bashing on OSX and it works like a charm, Thanks!!!