337204 - add MOZ_SAFEBROWSING to configure to enable it for Firefox Alpha3

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

SafeBrowsing isn't enabled yet in the default configure, and should be so that we can get the feature tested for Firefox 2 Alpha 2.

See also: bug 336832 for setting default prefs
          bug 336273 for creating pref panel

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

converts --enable-safe-browsing to --disable-safe-browsing and defines MOZ_SAFE_BROWSING=1 by default

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 221406 [details] [diff] [review]
patch

>+MOZ_ARG_DISABLE_BOOL(safe-browsing,
>+[  --enable-safe-browsing        Disable safe browsing (anti-phishing) implementation],

Should that be --disable-safe-browsing?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: revised patch

Fix the issue beltzner found.

Comment 4

[Benjamin Smedberg]

Comment on attachment 221414 [details] [diff] [review]
revised patch

We shouldn't be defaulting safe-browsing on for all apps... the default should be changed only for firefox by changing the default in the browser) section. I'm inclined to leave the enable/disable code alone (don't rename the flag).

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: enable for browser only

Comment 6

[Benjamin Smedberg]

Comment on attachment 221458 [details] [diff] [review]
enable for browser only

I don't know what the status of 181 is, but this is the right fix on trunk and branch. I'm only doing build-config review here... somebody else is in charge of actually making the decision that safebrowsing should be turned on by default.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Checked in on the branch for a2, with a=schrep/beltzner. Will backout if it causes Ts/Tp issues.
mozilla/configure.in 	1.1503.2.64

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Backed out this change since it caused large Ts and Tp increases on the branch (~21% Ts, ~9% Tp on pacifica).

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Retargetted at beta 1

Comment 10

[Boris Zbarsky [:bzbarsky]]

This also caused jumps by about a factor of 2 in both Rlk and Lk on balsa.  Are there bugs filed to track the leak and perf issues?

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

We're going to try to get SafeBrowsing in for Bon Echo Alpha 3, re-targeting.

Comment 12

[Mike Schroepfer]

Removing from a2 tracking bug

Comment 13

[u88484]

Can this please be enabled for the trunk beforehand? So you guys don't have to hold up a release again to work out the bugs. I thought that's how things were supposed to work anyways...land big things on trunk, let bake and work out bugs, land on branch? I'm saying this because I see in the today's status meeting this is supposed to land the day before branch freeze for Alpha 3 and release the following day after the freeze.

Sorry for the spam.

Comment 14

[Darin Fisher]

fixed on SAFEBROWSING_20060516_BRANCH

Comment 15

[Darin Fisher]

> fixed on SAFEBROWSING_20060516_BRANCH

I was referring to attachment 221458 [details] [diff] [review] (sorry for the spam!)

Comment 16

[Steffen Wilberg]

This was fixed on trunk 2006-05-19 13:29 and on 1.8 branch 2006-05-19 15:55.

I don't know if there's something missing though. The Safe Browsing tab is present in Options-Advanced and shows that browser.safebrowsing.enabled is true, but the test page isn't reported as phishy:
http://www.google.com/tools/firefox/safebrowsing/phish-o-rama.html

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a2) Gecko/20060521 BonEcho/2.0a2

Comment 17

[u88484]

(In reply to comment #16)
> This was fixed on trunk 2006-05-19 13:29 and on 1.8 branch 2006-05-19 15:55.
> 
> I don't know if there's something missing though. The Safe Browsing tab is
> present in Options-Advanced and shows that browser.safebrowsing.enabled is
> true, but the test page isn't reported as phishy:
> http://www.google.com/tools/firefox/safebrowsing/phish-o-rama.html
> 
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a2) Gecko/20060521
> BonEcho/2.0a2
> 

Doesn't work for anyone. Regis on the forums says that he created a debug build and some files were missing. Adding these files made safebrowsing work and I can confirm. New bug?

http://caspar.regis.free.fr/various/components.zip

Comment 18

[Tony Chang (Google)]

(In reply to comment #17)
> 
> Doesn't work for anyone. Regis on the forums says that he created a debug build
> and some files were missing. Adding these files made safebrowsing work and I
> can confirm. New bug?
> 
> http://caspar.regis.free.fr/various/components.zip

Oops, opening bug 338757 for this.