Closed
Bug 39209
Opened 24 years ago
Closed 23 years ago
Table reflows, shrinks on form input (page reflows on login at Slashdot)
Categories
(Core :: Layout, defect, P2)
Tracking
()
VERIFIED
FIXED
mozilla0.9
People
(Reporter: jwbaker, Assigned: karnaze)
References
()
Details
(Keywords: perf, testcase, Whiteboard: [nsbeta2-] [nsbeta3-][PDTP2])
Attachments
(5 files)
Using the i686-pc-linux-gnu Build 2000051308 at slashdot.org, I can make Moz do a lot of gratuitous page reflowing. To reproduce: 1) Start Moz 2) Go to http://slashdot.org/article.pl?sid=00/05/13/1847242&mode=thread 3) Mouseover the "userlogin" button. Page reflows for no reason. 4) Focus the "Nickname" input. Page reflows again. 5) Focus the "Password" input. Page reflows again (not always). 6) Click the "userlogin" button. Page reflows again. 7) Move the focus between the modal dialog and the main Moz window. Page reflows many times, always shifting to the left. This is 100% reproducible on this build, platform, and URL. I haven't found another page that trigger the problem yet.
Assignee | ||
Comment 1•24 years ago
|
||
Triage duty calls. Reassinging to pierre.
Assignee: clayton → pierre
Comment 2•24 years ago
|
||
I confirm the bug. Problem: the testcase is fairly large and when I try to simplify using the 4x Editor, the bug goes away. Adding 'helpwanted' for the next couple of days: a simpler testcase would be nice.
Comment 3•24 years ago
|
||
Btw, the bug is very easy to reproduce by clicking on the "userlogin" button, keeping the mouse button pressed and mousing over - in and out - the "userlogin" button.
Reporter | ||
Comment 4•24 years ago
|
||
Reporter | ||
Comment 5•24 years ago
|
||
I created a minimal testcase to reproduce this bug. Removing anything from the testcase makes the bug go away. In particular, note the interaction between the fixed width and the alignment of the nested table. In this testcase, the problem only happens once. It happens the first time you mouseover the button. In the original document, the problem happens repeatedly as described by Pierre.
Keywords: helpwanted → testcase
Summary: Page reflows needlessly when dialog gains, loses focus → Page reflows needlessly when button gains, loses focus
Reporter | ||
Comment 6•24 years ago
|
||
Reporter | ||
Comment 7•24 years ago
|
||
Silly me. You can actually remove the fixed width of the nested table, and the bug is still present. Even more minimal testcase is attached.
Comment 9•24 years ago
|
||
Blake's testcase is awesome. This really looks like another table reflow bug. Chris, can you take another look?
Assignee: pierre → karnaze
Comment 10•24 years ago
|
||
(That was Jeff's testcase, not Blake's) I'm going to attach yet another version of that minimal testcase which shows that after the mouseover reflow the TABLE containing the FORM has a width of twice what would be necessary to display the FORM. You can also see that the 'left' value of the inner TABLE is (rightfully) used to calculate the width of its cell during the initial reflow but *not* after the spurious reflow generated by the mouseover.
Comment 11•24 years ago
|
||
Assignee | ||
Comment 12•24 years ago
|
||
I filed bug 44730 to handle the 3rd attachment and moved it to "future" since it deals with relative positioning.
Status: NEW → ASSIGNED
Assignee | ||
Comment 13•24 years ago
|
||
Assignee | ||
Comment 14•24 years ago
|
||
I'm nominating this for beta2 since it will affect any page that has a nested table with align=center or a left or right auto margin.
Keywords: nsbeta2
Assignee | ||
Updated•24 years ago
|
Whiteboard: fix-in-hand
Comment 15•24 years ago
|
||
Putting on [NEED INFO] radar. PDT needs to know impact to user and risk of fix to make a call on this bug. Any top100 sites that show this behavior? We need to know if this is going to be highly visible or not.
Whiteboard: fix-in-hand → [NEED INFO]fix-in-hand
Comment 16•24 years ago
|
||
Putting on [nsbeta2-] radar. Not critical to beta2.
Whiteboard: [NEED INFO]fix-in-hand → [nsbeta2-] fix-in-hand
Comment 17•24 years ago
|
||
Additional problem seems to have appeared (or I just didn't notice it before) 1. IN URL above if you focus inside the nickname: input box, and start to type the page reflows on the same manor, except it continously shrinks the middle column as you type or even as you backspace.
Comment 18•24 years ago
|
||
Nominating for nsbeta3 and adding the perf keyword; we are hurting on the perf front.
Comment 19•24 years ago
|
||
Approving for nsbeta3
Whiteboard: [nsbeta2-] fix-in-hand → [nsbeta2-] [nsbeta3+] fix-in-hand
Reporter | ||
Comment 20•24 years ago
|
||
*** Bug 47548 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 21•24 years ago
|
||
*** Bug 46580 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 22•24 years ago
|
||
Changed the description to make this bug easier to find.
Summary: Page reflows needlessly when button gains, loses focus → Table reflows, shrinks on form input
Reporter | ||
Comment 23•24 years ago
|
||
*** Bug 47983 has been marked as a duplicate of this bug. ***
Comment 24•24 years ago
|
||
Same as bug 29511 ? They seem to have the same symptoms ...
Reporter | ||
Comment 25•24 years ago
|
||
*** Bug 48219 has been marked as a duplicate of this bug. ***
Comment 26•24 years ago
|
||
*** Bug 48159 has been marked as a duplicate of this bug. ***
Comment 27•24 years ago
|
||
Adding nsbeta2 keyword to bugs with nsbeta2 triage value in status field so the queries don't get screwed up
Keywords: nsbeta2
Comment 28•24 years ago
|
||
*** Bug 48288 has been marked as a duplicate of this bug. ***
Comment 30•24 years ago
|
||
*** Bug 29511 has been marked as a duplicate of this bug. ***
Comment 31•24 years ago
|
||
*** Bug 48004 has been marked as a duplicate of this bug. ***
Comment 32•24 years ago
|
||
*** Bug 48121 has been marked as a duplicate of this bug. ***
Comment 33•24 years ago
|
||
We've had a patch since July; could we please get it checked in? This bug is getting duped daily...(updating summary to help catch some of them)
Summary: Table reflows, shrinks on form input → Table reflows, shrinks on form input (page reflows on login at Slashdot)
Reporter | ||
Comment 34•24 years ago
|
||
*** Bug 49003 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 35•24 years ago
|
||
*** Bug 48957 has been marked as a duplicate of this bug. ***
Comment 36•24 years ago
|
||
Chris is on sabbatical: he'll check in the patch when he returns (it is BETA3+)
Priority: P3 → P2
Comment 37•24 years ago
|
||
I'll review the patch and if it's ok I'll check it in.
Assignee: karnaze → buster
Status: ASSIGNED → NEW
Comment 38•24 years ago
|
||
the changes here are too big to check in without Chris' help. Not a good use of my time right now. So, Reassigning back to Chris. Chris, when you get your feet back on the ground, I'll review these changes with you.
Assignee: buster → karnaze
Updated•24 years ago
|
Priority: P2 → P1
Target Milestone: --- → M18
Comment 39•24 years ago
|
||
PDT moving to P2...setting to [PDTP2]
Priority: P1 → P2
Whiteboard: [nsbeta2-] [nsbeta3+] fix-in-hand → [nsbeta2-] [nsbeta3+][PDTP2] fix-in-hand
Comment 40•24 years ago
|
||
*** Bug 50068 has been marked as a duplicate of this bug. ***
Comment 41•24 years ago
|
||
*** Bug 51296 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 42•24 years ago
|
||
cvs cannot apply the patch even on the versions from which it originally diffed.
Whiteboard: [nsbeta2-] [nsbeta3+][PDTP2] fix-in-hand → [nsbeta2-] [nsbeta3+][PDTP2]
Assignee | ||
Comment 43•24 years ago
|
||
This is fixed except for the problem with depressing the "userlogin" button on the url (depressing the button on the first two attachments is ok). So, I've marked this nsbeta3-. I need a new test case for the remaining problem. Most of the bugs marked as duplicates of this are fixed except for the few that mention the userlogin button on the slashdot page.
Keywords: qawanted
Whiteboard: [nsbeta2-] [nsbeta3+][PDTP2] → [nsbeta2-] [nsbeta3-][PDTP2]
Comment 44•24 years ago
|
||
Hi all, with (2000101015 on linux redhat7.0), I have a little problem that look like this. When you enter 3 letter (at http://www.dejanews.com/), the table just go down a little, maybe 1 millimeter. I isolate the html code for this, it's a table in a table and then you have the form in the middle, by getting out the first table it work OK, but with the two table in, it do the little move, all the form is going down. By looking at the HTML, it didn't look to have any error in it, so I decided to test it in a w3c html validator and nothing major was found. So it look like this bug, this was post on an other bug (http://bugzilla.mozilla.org/show_bug.cgi?id=52649) that I have found who was corrected, but it still happen to have a little bug in the same form and liv@duke.edu just said that maybe it was a duplicate of this one. Go there to see a minimal test case on which I have send on one of my other bug http://bugzilla.mozilla.org/showattachment.cgi?attach_id=17607 - enter 3 letters and the form will go down a little.
Comment 45•24 years ago
|
||
Chris, this bug worksforme on all testcases and URL under Win98. I think you can close the bug.
Comment 46•24 years ago
|
||
I have noticed that this also happens on http://www.google.com Whenever text is typed into the search box, the text box moves. This is a fairly small test case, happens on linuxppc,linux x86 and Mac as of 0.7.
Comment 47•24 years ago
|
||
sorry for the spam
Comment 48•24 years ago
|
||
can't reproduce this on reported urls at slashdot.org and all testcases. but i can confirm reflowing at www.dejanews.com as described by Francis. not his testcase, though - everything is ok in it. i've noticed the same reflows at http://forum.hardware.ru/cgi-ubb/search.cgi?action=intro type two letters in the first field, and table will move down a few millimeters. delete them, and table will move back. i'm using linux 20010128 nightly build.
Comment 49•24 years ago
|
||
Here's another example. I'm going to attach an almost (more on this later) HTML 4.01 strict compliant document with CSS compliant styles in a minute. Notice that when you bring the page up in Mozilla and start clicking alternately on the radio buttons, Mozilla will (*badly*) reflow the table. The first two or three times is really bad. After that, we're talking chump change in comparison, but by that time the layout of the page is completely gone. The reflow goes away if you take the javascript out that disables the button. It also goes away if you replace the button with a text box and disable/enable that instead. this is mozilla build 2001020108 on Linux kernel 2.2x. On a side note. I couldn't get the silly HTML validator at w3.org to validate this doc. It said something about ending the head tag that wasn't finished. I looked for examples and found stuff on their site that was doing exactly what I was doing. Anybody have any ideas? also adding self to cc list
Comment 50•24 years ago
|
||
Reporter | ||
Comment 51•24 years ago
|
||
The test case is invalid becaue it lacks the mandatory TITLE element, which must be in the HEAD element.
Comment 52•24 years ago
|
||
Cool. Thanks! I had the TITLE in there but figgrd it was not needed to demonstrate the test case and got rid of it. Learn something new every day. Note that the test case is still perfectly valid for demonstrating the table reflow problem...
Comment 53•24 years ago
|
||
I just tried this bug in W2K build 2001020204 and see almost the same problem as I do in Linux. The difference is that Linux will badly reflow the table as soon as you toggle the radio buttons the first time. Windows doesn't reflow badly until you toggle the radio buttons the second time. The OS should be marked as all
Comment 54•24 years ago
|
||
Unsetting target milestone - M18 is long past. Gerv
Keywords: mozilla0.9
Target Milestone: M18 → ---
Assignee | ||
Comment 55•23 years ago
|
||
Moving to m0.9
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
Assignee | ||
Comment 56•23 years ago
|
||
I'm closing this bug because the original problem was fixed (as well as most of the additional urls mentioned). There are still some outstanding issues raised by this bug summarized as follows: bug 75792 - remaining problem with attachment #2 [details] [diff] [review] bug 44730 - remaining problem with attachment #3 [details] [diff] [review] bug 75804 - remaining problem with attachment #5 [details] Please do not reopen this bug with yet another url. Please file a new bug instead.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•