Open Bug 405108 Opened 14 years ago Updated 2 months ago

make sorting changes in places/library (session) persistent


(Firefox :: Bookmarks & History, defect, P5)





(Reporter: wpisham, Unassigned)



(Keywords: uiwanted, Whiteboard: [Fx2-parity][has patch][needs UX definitions])


(1 file)

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O 10.5; en-US; rv:1.9b1) Gecko/2007110903 Firefox/3.0b1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O 10.5; en-US; rv:1.9b1) Gecko/2007110903 Firefox/3.0b1

In the Organize Bookmarks window, sorting all bookmarks, or sorting a particular folder of bookmarks succeeds in the organize window, but has no effect after the organize window is closed:  the sort doesn't stick.

Upon re-opening the organize folder, the bookmarks remain listed as "unsorted."

Reproducible: Always

Steps to Reproduce:
1.Open Organize Bookmarks
2.Using the View popup menu, choose Sort (I used "by name")
3.Close the Organize window.
Actual Results:  
The bookmarks remain unsorted

Expected Results:  
bookmarks sorted
Confirmed Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112205
adding FX2-parity and adjusting bug title.
Severity: normal → minor
Component: Bookmarks → Places
Ever confirmed: true
Flags: blocking-firefox3?
OS: Mac OS X → All
QA Contact: bookmarks → places
Hardware: Macintosh → All
Summary: Sorting bookmarks doesn't stick → make sorting changes in places/library (session) persistent
Whiteboard: [Fx2-parity]
Version: unspecified → Trunk
Assignee: nobody → mano
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P3
Target Milestone: --- → Firefox 3 M11
Target Milestone: Firefox 3 beta3 → ---
Assignee: mano → mak77
possible patch in bug 405010
for more info see bug 405010 discussion.

There's a problem here since in a sorted view the drop position is somehow wrong, remembering always the sorting will make users think that D&D is not working correctly.

IMHO, we should persist the sorting order in the Library when a user moves
through folders, but not persist it across sessions, this way when the user
opens the Library the D&D is correctly working, and he will soon understand the
difference between a sorted view and an unsorted one.

Mano: That said, I don't think there's much value in persisting the sort method
anyway. If we cannot get sensible d&d support when the view is sorted, it'd be
fine not to persist sorting for the time being.
the last was not a request for Mano, but a comment from him (sorry i forgot the quote)
Attached patch patchSplinter Review
Keywords: uiwanted
Whiteboard: [Fx2-parity] → [Fx2-parity][has patch][needs def due to D&D]
this should not block, or at least needs definition, see comment #3
Flags: blocking-firefox3+ → blocking-firefox3?
I agree, doesn't block, might even be WONTFIX. Changing a view shouldn't actually permanently alter the way that the items are represented in the menu, IMO.
Flags: blocking-firefox3? → blocking-firefox3-
Keywords: uiwanted
this is not about persisting the sorting in menu, is about persisting the sorting when moving between folders into the Library...
Duplicate of this bug: 426784
yep, this should be library only and without session persistence of course.
so, will there be a update [(UI-)review] on this issue in the near future? :-)
Duplicate of this bug: 448321
Keywords: uiwanted
Whiteboard: [Fx2-parity][has patch][needs def due to D&D] → [Fx2-parity][has patch][needs UX definitions]
Duplicate of this bug: 440988
Duplicate of this bug: 508914
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Component: Places → Bookmarks & History
QA Contact: places → bookmarks
Assignee: mak77 → nobody
Duplicate of this bug: 752024
Priority: P3 → --
Duplicate of this bug: 408776
Priority: -- → P5
Duplicate of this bug: 1567677
Duplicate of this bug: 1627149

1627149 was not a duplicate of this bug, and making a sorting change persistent doesn't really fix the issue at all. But I guess the idea was just outright torpedoed. Too bad.

Alphabetical sort of URLs, even if made persistent, isn't the same thing at all. Alphabetical sort is not what an average user would expect -- they would expect like URLs from the same site to be clustered together, not to be in vastly different areas depending on what subdomain was used ("www" versus no "www", or being in the As while is in the Ws). The regex described would've accomplished that.

Duplicate of this bug: 1698286
You need to log in before you can comment on or make changes to this bug.