Back/forward buttons disappear when moving from 1.8 to 1.9 if they've been moved

RESOLVED FIXED in Firefox 3.1a1

Status

()

Firefox
Toolbars and Customization
--
minor
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: Cww, Assigned: dao)

Tracking

(Depends on: 1 bug, {fixed1.9.0.2})

3.0 Branch
Firefox 3.1a1
fixed1.9.0.2
Points:
---
Bug Flags:
blocking-firefox3 -
wanted-firefox3 +
blocking1.9.0.2 +
wanted1.9.0.x +
in-testsuite -
in-litmus +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MU+])

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
This is a followup bug based on my comment here: https://bugzilla.mozilla.org/show_bug.cgi?id=417421#c29

Following on from bug 417421 it doesn't patch the case as follows:

I have all my navigation buttons in my menu toolbar... so I have everything in one line, address bar, search bar, menu.  Moving from .13 to Minefield still makes the back/forward buttons disappear.  Doubly annoying because they don't show up in Toolbars>Customize, they get dumped in the (hidden) navigation toolbar.

Having it set up correctly in Minefield and then moving to 2.0.0.13 still makes the back/forward buttons disappear.

I would expect that Firefox 3 would figure out where the back button is and put the megabutton there even if it's not on the navigation toolbar and that 2.0.0.13 would look for the megabutton and put both the back and forward buttons where it is.

It's a minor issue but I can see people who customize their toolbars being minorly annoyed/confused after upgrading to 3 if it's in the final.

Anyhow by way of providing details, below are excerpts from my localstore.rdf after performing a series of steps.

1. Start with a fresh 2.0.0.13 profile.  Move buttons to menubar, hide navigation toolbar.

<RDF:Description RDF:about="chrome://browser/content/browser.xul#toolbar-menubar"
                   iconsize="small"
                   currentset="back-button,forward-button,stop-button,reload-button,home-button,menubar-items,urlbar-container,spring,search-container,throbber-box" />
<RDF:Description RDF:about="chrome://browser/content/browser.xul#nav-bar"
                   iconsize="small"
                   currentset="__empty"
                   collapsed="true" />

2. Open in Minefield, see that the back/forward buttons are "missing" (they're actually in the navigation toolbar).  Don't make any changes or touch anything, just close.
<RDF:Description RDF:about="chrome://browser/content/browser.xul#toolbar-menubar"
                   iconsize="small"
                   currentset="back-button,forward-button,stop-button,reload-button,home-button,menubar-items,urlbar-container,spring,search-container,throbber-box" />
<RDF:Description RDF:about="chrome://browser/content/browser.xul#nav-bar"
                   iconsize="small"
                   collapsed="true"
                   currentset="unified-back-forward-button,__empty" />

3. Make changes in Minefield to put the buttons where they should be.
<RDF:Description RDF:about="chrome://browser/content/browser.xul#toolbar-menubar"
                   iconsize="small"
                   currentset="unified-back-forward-button,stop-button,reload-button,home-button,menubar-items,urlbar-container,spring,search-container,throbber-box" />
<RDF:Description RDF:about="chrome://browser/content/browser.xul#nav-bar"
                   iconsize="small"
                   currentset="__empty"
                   collapsed="true" />

4. Open in 2.0.0.13 and see that the back/forward buttons are missing.


You can probably see what's going on from there.

Updated

9 years ago
Flags: in-testsuite?
Flags: in-litmus?
Flags: blocking-firefox3?

Comment 1

9 years ago
I agree, this could be quite confusing to users who have moved the buttons to another toolbar and hidden the navigation bar.

Anoother (possibly simpler) solution would simply be to reset the navigation bar state to "visible" when upgrading from FF2 to FF3.
This will not block the final release of Firefox 3. Any patch will need unit tests in order to be approved.
Flags: blocking-firefox3? → blocking-firefox3-
Duplicate of this bug: 426696
Duplicate of this bug: 428619
Duplicate of this bug: 428681
Duplicate of this bug: 428753

Updated

9 years ago
Duplicate of this bug: 430194
Duplicate of this bug: 428663
(Reporter)

Updated

9 years ago
Duplicate of this bug: 433737
(Reporter)

Updated

9 years ago
Duplicate of this bug: 434129

Updated

9 years ago
Duplicate of this bug: 434910
Keywords: relnote

Comment 12

9 years ago
I was using the latest version of Firefox 2, when I installed the Beta for Firefox 3 (last Beta before RC1). After using Firefox 3 for a day or so, I accidentally opened Firefox 2. The Forward and Back buttons disappeared. I'd never moved the buttons as the topic of this bug suggests. They were in their default spot, until they vanished. Now in both versions of Firefox I have no Forward or Back buttons. I've since uninstalled Firefox 2 and reinstalled Firefox 3. The buttons are still missing.
When Firefox 3 final is released, will the problem be fixed? And how can I fix the problem manually until then? I fully accept the consequences of using Beta software. :)

Comment 13

9 years ago
I had the same issue as described in comment#12.
Sort it by running Mozilla Firefox (Safe Mode) from your Start Menu, and selecting the 'reset toolbars' option.

Comment 14

9 years ago
Another way to fix the problem in comment 12 is:
View->Toolbars->Customize... in the non-safe form
If it's the same problem I had (it starts out the same way mine did), the forward/back buttons should be in the "customize toolbar" box that pops up.  Just drag-and-drop them back to where you want them to be.  Or, if you don't want to drag-and-drop, hit the "Restore Default Set" button on the customize toolbar box.  That should put your arrows back where they belong.  Yay Beta!

Hope this helps!
-Christen
Flags: wanted1.9.0.x?
Flags: wanted-firefox3+

Updated

9 years ago
Duplicate of this bug: 439073

Updated

9 years ago
Duplicate of this bug: 439662

Updated

9 years ago
Duplicate of this bug: 434507

Updated

9 years ago
Duplicate of this bug: 439799

Comment 19

9 years ago
my problem is that they straight up aren't there. they were in 2.0.0.14 and in 3.0 beta 2 but not in 3.0

weird?

Comment 20

9 years ago
A bump in priority might be in order, while there are still relatively few version 3 users.  Since it happens only after update to 3, if it's not fixed fairly soon you might as well WONTFIX it.
Flags: blocking-firefox3.1?

Comment 21

9 years ago
i found the solution to this problem.

since most of the comments i was getting back were more like discussion and less like help i decided to look for them myself. i tried resetting the navigation and such but it came down to this simple of procedure:

view > toolbar > customize

and they were right there. just had to click and drag them to where i wanted them

this didn't happen because i customized the toolbar. i left everything default since i first got FF
I vaguely recall fixing something like this on the 1.8 branch a release or two ago. Can someone confirm this issue still exists?

Comment 23

9 years ago
This is definitely a new thing Samuel - the unified keyhole button appears in Navigation Toolbar even if that toolbar is hidden and even if original back and forward were somewhere else.
(Assignee)

Comment 24

9 years ago
(In reply to comment #22)
> I vaguely recall fixing something like this on the 1.8 branch a release or two
> ago. Can someone confirm this issue still exists?

You probably mean bug 417421.
This one is a special case (comment 23) that our migration code doesn't handle.
(Assignee)

Updated

9 years ago
OS: Windows XP → All
Hardware: PC → All
(Assignee)

Comment 25

9 years ago
Created attachment 329419 [details] [diff] [review]
handle the menu and personal toolbars as well

might be a good idea to fix this before we roll out major updates
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #329419 - Flags: review?(gavin.sharp)
Whiteboard: [MU?]
(Assignee)

Updated

9 years ago
Flags: blocking-firefox3.1? → blocking1.9.0.2?
(Assignee)

Updated

9 years ago
Version: Trunk → 3.0 Branch
Attachment #329419 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 26

9 years ago
http://hg.mozilla.org/index.cgi/mozilla-central/rev/9fbc65c8de31
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a1
(Assignee)

Updated

9 years ago
Attachment #329419 - Flags: approval1.9.0.2?
Whiteboard: [MU?] → [MU+]
Can we get a test here before landing on 1.9.0? A major update Litmus test would be acceptable but an automated test would be even better.
(Assignee)

Comment 28

9 years ago
Marcia, can we get a major update Litmus test for this? It should cover moving the back button somewhere in the menu, navigation or bookmarks toolbar on Firefox 2 and then running Firefox 3.x for the first time with that profile.
Flags: in-litmus? → in-litmus-
Flags: in-litmus- → in-litmus?
(Assignee)

Updated

9 years ago
Flags: in-testsuite? → in-testsuite-
Flags: blocking1.9.0.2? → blocking1.9.0.2+
https://litmus.mozilla.org/show_test.cgi?id=5889 added to Litmus, to the 2.0->3 major update portion.
Flags: in-litmus? → in-litmus+
Comment on attachment 329419 [details] [diff] [review]
handle the menu and personal toolbars as well

Approved for 1.9.0.2. Please land in CVS. a=ss
Attachment #329419 - Flags: approval1.9.0.2? → approval1.9.0.2+
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
Whiteboard: [MU+] → [MU+][needs landing]
checked into CVS.
Keywords: checkin-needed
Whiteboard: [MU+][needs landing] → [MU+]
(Assignee)

Updated

9 years ago
Keywords: relnote → fixed1.9.0.2
Flags: wanted1.9.0.x? → wanted1.9.0.x+
Dao, what about custom toolbars? Placing the back/forward buttons onto such ones they still disappear with the latest nightly builds. Should we reopen this bug or shall I file a new one?
Version: 3.0 Branch → Trunk
(In reply to comment #32)
> Should we reopen this bug or shall I file a new one?

The answer to that question is "file a new bug" in 99% of cases (including this one) :)
Depends on: 452057
(Assignee)

Updated

9 years ago
Version: Trunk → 3.0 Branch

Updated

9 years ago
Duplicate of this bug: 437577

Comment 35

8 years ago
Could this have anything to do with https://bugzilla.redhat.com/show_bug.cgi?id=530466 ? (not that I would be able to reproduce it)?
(Assignee)

Comment 36

8 years ago
It shouldn't, this bug is fixed.
You need to log in before you can comment on or make changes to this bug.