417421 - Loss of back forward buttons when switching between 1.8 and 1.9

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Stuart Parmenter]

Say I have a profile that I run with 1.8, now when I run with 1.9 and go back my back/forward buttons are gone.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Gavin/Dao: is this due to the changes we made to the navigation toolbar? I suspect so. How hard would it be to allow the downgrade scenario, or at least, not leave people without back/forward buttons?

I worry a little about the "try Firefox 3, go back to Firefox 2" scenario, here.

Comment 3

[Dão Gottwald [:dao]]

This happens if you customize your toolbar while you're on 1.9.

Comment 4

[Dão Gottwald [:dao]]

I'll work on making customizing backwards-compatible.

Comment 5

[Dão Gottwald [:dao]]

Attachment: support downgrading

Can we land something similar on branch? Otherwise we'll lose the unified button if you go back to branch, customize, and go forward to trunk again.

Comment 6

[Dão Gottwald [:dao]]

Attachment: support downgrading (checked in)

added a semicolon

Comment 9

[Reed Loden [:reed]]

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.973; previous revision: 1.972
done

Comment 10

[Dão Gottwald [:dao]]

Attachment: branch patch

Comment 11

[Dão Gottwald [:dao]]

Attachment: on trunk, don't add unified-back-forward-button if it's already there (due to the change on branch)

Comment 13

[Daniel Veditz [:dveditz]]

Too late for 1.8.1.13 given lack of trunk landing. If you decide we're really doing this on the trunk please nominate for 1.8.1.14

Comment 14

[Dão Gottwald [:dao]]

Attachment 303369 [details] [diff] has landed on trunk.
Attachment 305153 [details] [diff] isn't supposed to land on trunk.
Attachment 305154 [details] [diff] is an optimization for the migration code which makes sense only once the branch patch is live.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Gavin tells me that this patch is somehow related to our decision to move the home button, which is a change we are most likely going to backtrack on.

So let this be the definitive statement: Firefox 3 final *will* have the keyhole by default, but will also have the home button on the main navigation toolbar.

Comment 16

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 305154 [details] [diff] [review]
on trunk, don't add unified-back-forward-button if it's already there (due to the change on branch)

>Index: browser/components/nsBrowserGlue.js

>+          target = target.replace(/(?:^|,)home-button(?:$|,)/, ",");

>+        if (target && !/(?:^|,)home-button(?:$|,)/.test(target))

Assign this regexp to a variable (hasHomeButton?)?

Comment 17

[Dão Gottwald [:dao]]

Attachment: second trunk patch, review comment addressed

Comment 18

[Samuel Sidler (old account; do not CC)]

Comment on attachment 305153 [details] [diff] [review]
branch patch

Approved for 1.8.1.13, a=ss for release-drivers.

Please land ASAP as our code freeze is tonight at 11:59pm PST.

Comment 19

[Reed Loden [:reed]]

(In reply to comment #18)
> Please land ASAP as our code freeze is tonight at 11:59pm PST.

Will land tonight. :)

Comment 20

[Reed Loden [:reed]]

Checking in browser/components/nsBrowserGlue.js;
/cvsroot/mozilla/browser/components/nsBrowserGlue.js,v  <--  nsBrowserGlue.js
new revision: 1.72; previous revision: 1.71
done

Comment 21

[Reed Loden [:reed]]

MOZILLA_1_8_BRANCH

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.479.2.220; previous revision: 1.479.2.219
done

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Verified.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.13pre) Gecko/20080310 BonEcho/2.0.0.13pre ID:2008031003

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008031004 Minefield/3.0b5pre ID:2008031004

Comment 24

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

I forgot to set verified1.8.1.13 yesterday.

Comment 29

[[:Cww]]

I'm not about to reopen this bug but I'm not sure that's a sufficient fix.  Here's my problem: I have all my navigation buttons in my menu toolbar... so I have everything in one line, address bar, search bar, menu.  Moving from .13 to Minefield still makes the back/forward buttons disappear.  Doubly annoying because they don't show up in Toolbars>Customize, they get dumped in the (hidden) navigation toolbar.

Having it set up correctly in Minefield and then moving to 2.0.0.13 still makes the back/forward buttons disappear.

Comment 30

[Dão Gottwald [:dao]]

Cww, could you please file a new bug?

Comment 31

[[:Cww]]

I did: Bug 426026