42604 - Windows shortcuts shouldn't be created with comments on Win2000

Status: VERIFIED FIXED

(SeaMonkey :: Installer, enhancement, P5)

Description

[Henrik Gemal]

On Windows 2000 if you rightclick and select properties on the shortcuts created 
by the mozilla win32 installer you'll see that in the Comment field is says 
"Mozilla Seamonkey".
This is giving some visual problems when dragging the shortcut to the Quick 
Launch bar.
Because of the comment the icon in the quick launch bar will have the text 
"Mozilla Seamonkey" twice in the tooltip:
Mozilla Seamonkey
Mozilla Seamonkey

I'll attach a screenshot showing the UI problem.

Expected:
The shortcuts are created with the comment field left empty.

Comment 1

[Henrik Gemal]

Attachment: Screenshot of tooltip after dragging shortcut to quick launch bar

Comment 2

[Henrik Gemal]

Isn't the description for the shortcut in somekind of .it file?
Couln't we just remove this descriptione?

Comment 3

[timeless]

It'd be much more useful if you named the QL shortcuts after builds and kept 
the comments so:
2000091108[.lnk]
Mozilla SeaMonkey

Less useful is the converse...

Comment 4

[Hixie (not reading bugmail)]

Even better would be to do what Microsoft do for their IE shortcuts:
      Name: Internet Explorer.lnk
   Comment: Finds and displays information and Web sites on the Internet.
...and so on.

Comment 5

[timeless]

yeah for release builds we should do something like that.  My request was for 
non release builds...

Comment 6

[Curt Patrick (gone)]

Taking over for Sean

Comment 7

[Henrik Gemal]

*** Bug 111844 has been marked as a duplicate of this bug. ***

Comment 8

[Jonas Jørgensen]

How about "Everyone's favorite green lizard" as the comment?

Comment 9

[Andy Lyttle]

I like that, but in various places it's a red lizard.  Besides, the icon is blue.

The comment should reflect the fact that Mozilla is not just a browser - it's
also a mail client, IRC client, WYSIWYG HTML editor, etc. if those components
are installed.  However, since the average user thinks of it as a browser,
calling it "A general platform upon which various components can be built" would
be really dumb.

Comment 10

[Jonas Jørgensen]

The blue icon is ugly and should be changed, and average users are not supposed
to use Mozilla. 

About the color... well, Netscape old mascot, Mozilla, is green. Mozilla.org's
logo is red. But http://www.mozilla.org/feedback.html says that "The Open
Directory Project is also not connected with mozilla.org (although they do
display an affection for everyone's favorite green lizard)".

So maybe "Everyone's favorite red lizard"? :-)

Comment 11

[Curt Patrick (gone)]

This is related to a PRD item so I'm adding it to the dependency tree

Comment 12

[Henrik Gemal]

*** Bug 123338 has been marked as a duplicate of this bug. ***

Comment 13

[Henrik Gemal]

*** Bug 112487 has been marked as a duplicate of this bug. ***

Comment 14

[Henrik Gemal]

*** Bug 125692 has been marked as a duplicate of this bug. ***

Comment 15

[Grace Bush]

nsbeta1+ issues for Win Installer

Comment 16

[Jaime Rodriguez, Jr.]

nsbeta1- per ADT/XPInstall triage.

Comment 17

[Daniel Veditz [:dveditz]]

*** Bug 134237 has been marked as a duplicate of this bug. ***

Comment 18

[selmer (gone)]

Please update this bug with an [adt1] - [adt3] impact rating (or take it off the
list if it doesn't even rate adt3.)  Thanks!

Comment 19

[Henrik Gemal]

*** Bug 135971 has been marked as a duplicate of this bug. ***

Comment 20

[Chris Lyon]

*** Bug 136102 has been marked as a duplicate of this bug. ***

Comment 21

[R.K.Aa.]

*** Bug 136302 has been marked as a duplicate of this bug. ***

Comment 22

[R.K.Aa.]

*** Bug 136568 has been marked as a duplicate of this bug. ***

Comment 23

[Ian Sidle]

As an quick comment, the shortcut that is put on the desktop (automatically) is
the same one that is put in the "Quick Launch" bar. So the double name/comment
shows up in the tooltips still applies. So *both* should be changed (or change
whichever is made first). I think the mozilla logo/mascot/whatever is an
dinosaur, not a lizzard. So "Everyone's favorate red dinosaur", or "Everyone's
Favorate T-rex". That tooltip string (whatever is chosen) should also be put in
for the macos equilivant (help bubbles I think).and/or also in the get-info
dialog box. For a more (semi) serious idea's..

Mozilla: The tokyo city destroying internet set
Mozilla: Your Internet toolkit
Mozilla: Internet communication toolkit
Mozilla: Everything you would ever need
Mozilla: World domination in a box

With Variations thereof. 

Comment 24

[[not reading bugmail]]

boy this one is really getting some attention as of late... here is another
suggestion 'Mozilla Communicator Suite'.. you could leave 'Mozilla' off the
comment field.

Comment 25

[Henrik Gemal]

The shortcut could just be:
Name: "Mozilla Navigator"
Comment: "Launch Mozilla Navigator"

Name: "Mozilla Mail & Newsgroups"
Launch: "Mozilla Mail & Newsgroups"
etc...

that's how IE does it. And then we dont have to invent any Mozilla Suite names
war, which will rage for 10 years...

Comment 26

[David Barnes]

As a first step it would be nice if the comment field could be made blank. Then 
the discussions could start on what to put there. As it is now, the tooltip 
simply looks silly "Mozilla Mozilla".

Proposal:
Step One: Immediately make comment field blank. I think everyone could agree 
this would be better than current situation.
Step Two: Decide new phrase. Have a vote!
Step Three: Implement

My point is there's no reason to have a new comment ready before making the 
current one blank.

Comment 27

[Henrik Gemal]

*** Bug 137703 has been marked as a duplicate of this bug. ***

Comment 28

[Colin S]

I feel the best idea is to have the comment field be the build ID. (It Just
Makes Sense.)

Comment 29

[scottputterman]

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email [e-mail].  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

Comment 30

[scottputterman]

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email [e-mail].  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

Comment 31

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 140918 has been marked as a duplicate of this bug. ***

Comment 32

[R.K.Aa.]

*** Bug 142287 has been marked as a duplicate of this bug. ***

Comment 33

[R.K.Aa.]

*** Bug 142646 has been marked as a duplicate of this bug. ***

Comment 34

[R.K.Aa.]

*** Bug 144016 has been marked as a duplicate of this bug. ***

Comment 35

[R.K.Aa.]

*** Bug 144590 has been marked as a duplicate of this bug. ***

Comment 36

[R.K.Aa.]

*** Bug 144801 has been marked as a duplicate of this bug. ***

Comment 37

[R.K.Aa.]

*** Bug 146944 has been marked as a duplicate of this bug. ***

Comment 38

[Stefan Borggraefe]

*** Bug 152500 has been marked as a duplicate of this bug. ***

Comment 39

[Gregg Landskov (gone)]

renominating because this is a trivial fix with no risk and shipping with it
would look very sloppy.

Renominating nsbeta1, we talked about this at the install meeting and agreed it
should be an adt2, marking as so.

Comment 40

[Gregg Landskov (gone)]

cc'ing adt members as this is another bug that has not gotten plussed for some
reason.  Hopefully not too late to take a fix!!

Again - makes us look really sloppy, no reason for this type of bug.

Comment 41

[Jaime Rodriguez, Jr.]

we are past the state of taking low visibility polish issues. nsbeta1-. let's
get it in for a future release.

Comment 42

[Curt Patrick (gone)]

This may not make any difference to the final decision but I'm going to correct
the last description:  This IS a polish issue, but it IS NOT a low visibility
issue, as demonstrated by the huge number of duplicates.  EVERYONE who uses
Windows 2000 will see this constantly.

Comment 43

[Gregg Landskov (gone)]

Agree with Curt - this is extremely visible for all Win 2000 users.

Comment 44

[[not reading bugmail]]

Although I've moved on to Windows XP.  I'd really say if you run an corporation
on Windows 2000 which many have yet to change to from NT.  And they decide to
use Mozilla based products.  Yes, it is really visible and for people are
perfectionists like myself, It is god awful to look at one program that can't
seem to get the 'comment' field correct.  Not that it functionaly matters, but
it does stick out like a sore thumb.  :)  Which dropping the 'comment' field
populationing, which be the from the comments our best fix.

Comment 45

[Sean Su]

I found the problem.  It should be as easy as a 1 line patch (in a couple of
places).  testing now.

Comment 46

[Gregg Landskov (gone)]

Sweet, thanks Sean.

Re-nominating nsbeta1

Comment 47

[Sean Su]

Attachment: patch v1.0

Comment 48

[Sean Su]

Attachment: patch v1.1

patch with better grammar for the comments.  I need coffee...

Comment 49

[Syd Logan]

r=syd

Comment 50

[Curt Patrick (gone)]

Comment on attachment 89333 [details] [diff] [review]
patch v1.1

r=curt (way to go)

Comment 51

[Jaime Rodriguez, Jr.]

can we turn syd's r= into a sr=syd? if yes, adt1.0.1 nomination for the branch.

Comment 52

[Daniel Veditz [:dveditz]]

Comment on attachment 89333 [details] [diff] [review]
patch v1.1

Syd is not a mozilla.org super-reviewer, but I'll give you a sr=dveditz

Comment 53

[Daniel Veditz [:dveditz]]

If you close this bug when you check into the branch please open a new bug to
fix this the correct way (allow passing in a real description). But for now this
is better than what we've got.

Comment 54

[Jaime Rodriguez, Jr.]

doh! sorry, thought i was in the other bug system. :-(

thanks for the sr=, though.

Comment 55

[Sean Su]

patch checked in to trunk.  seeking drivers approval for branch now.

bug 154539 has been filed to deal with fixing the problem the correct way.

Comment 56

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 57

[K'Trina Medina]

Attachment: Quicklaunch screenshot

Using the 20020627 nightly Mozilla 1.1a+ build

Comment 58

[scottputterman]

marking adt1.0.1- per the adt.

Comment 59

[Gregg Landskov (gone)]

Argh!  I understand you want to concentrate on the adt1 bugs and you don't want
to set a precedent for lots of other bugs trying to get in. 

There is no reason to not accept this except for worry of being asked to accept
other non-ADT1 bugs.  But you are already evaluating EVERY BUG on a one by one
basis.  This bug is very visible and very easy to fix, we should take it.

It has been around for over two years, we are at version 7.0 for goodness sake.
 We shouldn't have a visible gaffe like this that Windows 2000 users will see
EVERY DAY!

Comment 60

[Scott MacGregor]

FWIW, I run into this almost every day. High visibility.

Comment 61

[Curt Patrick (gone)]

I've really got to ditto this the above objections to leaving this bug in.  The
fix is very straightforward.  It doesn't add any new code, just removes a line
(two places) which is doing the wrong thing.

Comment 62

[Jaime Rodriguez, Jr.]

should you wish to renominate this bug for the final release, pls remove the "-"
from the "adt1.0.1-", and feel free to comment as to why this needs to be fixed
this late in the game, and/or drop by an ADT meeting to pitch your case. thanks!

Comment 63

[Curt Patrick (gone)]

I'll dial into the adt meeting today.  11:00, isn't it?

Comment 64

[Paul Wyskoczka]

Adding adt1.0.1+ on behalf of the adt.  Please check into the Mozilla 1.0 branch.

Comment 65

[Curt Patrick (gone)]

Checked into branch.

Comment 66

[Grace Bush]

fixed on trunk 2002070104

Comment 67

[Grace Bush]

also branch 2002070108

Comment 68

[Henrik Gemal]

*** Bug 198858 has been marked as a duplicate of this bug. ***

Comment 69

[Alex Hosking]

Why is my bug a duplicate when its asking for the opposite?