427203 - Investigate turning on the ftp protocol in Thunderbird builds

Status: VERIFIED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Per bug 406227 comment 3, running some of the unit tests on Thunderbird will fail due to the ftp protocol not being available.

Additionally if we had ftp enabled, it would help things like bug 273476 (Thunderbird calendar needs to be built with FTP enabled for remote calendars).

Things like bug 390057 may need to be considered for how we expect to handle ftp links etc.

We also need to consider that if/when we move to xulrunner, it will have ftp protocol enabled by default, and therefore we'll need a solution then.

Taking the bug as I'm generally looking at unit test problems on Thunderbird at the moment.

Comment 1

[Magnus Melin [:mkmelin]]

Not having ftp support for tb3 would in effect be a regression from tb2 (where e.g. ftp calendars work fine).

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> Not having ftp support for tb3 would in effect be a regression from tb2 (where
> e.g. ftp calendars work fine).
> 
Interesting considering TB 2 didn't build with ftp either:

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/configure.in&rev=1.1503.2.111&mark=4392#4380

Maybe lightning enabled it somehow?

Comment 3

[Magnus Melin [:mkmelin]]

No idea how it was done, but with trunk builds it doesn't work, instead the calendar file on the ftp server tries to download through the browser.

Comment 4

[Phil Ringnalda (:philor)]

I say, do it, and include about and reorder our NECKO_PROTOCOLS_DEFAULT to the order of the default one in configure.in so it's clear that we're only deviating by not building the flea-bitten gopher. It'll affect our handling of links not one bit, since that depends not on what protocols we build, but on what we expose in network.protocol-handler.expose.foo prefs.

FWIW, I suspect the reason we're building an abbreviated set is for footprint, and from my testing enabling about and ftp added 16,136 bytes to the Windows installer.

Comment 5

[Mark Banner (:standard8)]

Attachment: Enable FTP

Adds FTP to the build. Seems to work correctly - calling the system ftp handler.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 316985 [details] [diff] [review]
Enable FTP

r=dmose

Comment 7

[Mark Banner (:standard8)]

Patch checked in. Fixed.

Comment 8

[Magnus Melin [:mkmelin]]

Nice, thanks Mark!