42879 - Drag-n-drop a mailing list to another address book and appears as a card

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect, P3)

Description

[marina]

Steps to reproduce:
-create a list under Personal AB;
-select the created list and drag/drop it to another AB
//note: nothing is copied

Comment 1

[scottputterman]

reassigning to chuang.  I think this might be a dup of a feature we latered.

Comment 2

[lchiang]

http://bugzilla.mozilla.org/show_bug.cgi?id=32295
http://bugzilla.mozilla.org/show_bug.cgi?id=32305

There isn't an exact one which matches this one.  The above items were the 
closest ones I found.

Comment 3

[scottputterman]

moving to future milestone

Comment 4

[scottputterman]

reassigning to racham

Comment 5

[R.K.Aa.]

*** Bug 108082 has been marked as a duplicate of this bug. ***

Comment 6

[Ninoschka Baca]

Changing summary from "Unable to copy/paste a list to from one AB to another
one" to "Drag-n-drop a list to another AB and nothing copies over"

Comment 7

[Ninoschka Baca]

Trunk build 2001-12-27-03: WinMe
After I dnd a list to another AB, the list appears as a card.

Changing the summary from "Drag-n-drop a list to another AB and nothing copies 
over" to "Drag-n-drop a list to another AB and appears as a card"

Marking nsbeta1 because this makes it difficult to move lists.

Comment 8

[Ninoschka Baca]

A possible workaround is to Drag-n-drop multiple cards from AB1 into a new
mailing list dialog in AB2. Unfortunately bug# 120445 needs to be fixed. If
neither bug is fixed then the user will have to manually create lists. This
could be painful if the user has large lists.

Comment 9

[Ninoschka Baca]

*** Bug 32299 has been marked as a duplicate of this bug. ***

Comment 10

[Christopher Davis]

*** Bug 145721 has been marked as a duplicate of this bug. ***

Comment 11

[Ninoschka Baca]

*** Bug 145731 has been marked as a duplicate of this bug. ***

Comment 12

[Sean Gao]

Attachment: proposed patch

This patch works well on my Windows and Sparc. The maillist, together with the
cards inside it, is copy to the destinate AB and it does appear as a maillist. 

There still, however, remain some problem:
1. I don't find there is a method to judge whether a maillist name is already 
   used a AB. "mailListNameExists" takes effect on all ABs, therefore it does 
   not permit different ABs have maillist with identical name,:-(.I have tried
   hasCard method in nsIAbMDBDirectory interface, but it seems not working as
   my imagination. Any suggestions?
2. Part of the maillist, more precisely, part content of the cards inside the 
   maillist be dropped will lost. I think this is another bug known as #95299. 


Anyway, the maillist will not be dealed as a card when you drag & drop it.

Comment 13

[Henry Jia]

This bug exists on linux & solaris too. Marking platform and OS to 'All'.

Comment 14

[Henry Jia]

Comment on attachment 97112 [details] [diff] [review]
proposed patch

This patch is a good start point for this big issue. I tested this patch on
linux and it does dnd as mail list instead of card. However,  there are some
areas needed to be improved.

1. decide if the operation is copy or move according to the value of
'needToCopyCard'
2. after dnd copy operation, all cards in the original mail list dispare. When
you restart mozilla, you can see them again
3. code style. Don't mix 'Tab' and 'Space' when writing code. Try to use
'Space'.

Sean, thx for the patch. Keep on going if possible.

Comment 15

[Samir Gehani]

Mail triage team: Sean Gao, would you like to take ownership of this bug?  If
so, feel free to reassign it to yourself.  Thanks.

Comment 16

[Samir Gehani]

Mail triage team: nsbeta1-

Comment 17

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 18

[Jim Booth]

*** Bug 185014 has been marked as a duplicate of this bug. ***

Comment 19

[David von Oheimb]

*** Bug 212062 has been marked as a duplicate of this bug. ***

Comment 20

[Joe Infla]

*** Bug 211404 has been marked as a duplicate of this bug. ***

Comment 21

[Oliver Klee]

Also seeing this on Thunderbird 0.4 on Windows.

Comment 22

[R.K.Aa.]

*** Bug 240009 has been marked as a duplicate of this bug. ***

Comment 23

[Boris 'pi' Piwinger]

I just ran into this bug after importing an Eudora address book. Since I don't
wanted to have an extra address book with the imported addresses, I move
everything into the main book. Mailing lists were lost as described before. So I
have two points here: a) this is dataloss and hence should be marked critical
and b) this is particularly relevant for imported data which cannot be imported
into an address book of the user's choice.

pi

Comment 24

[Mike Fedyk]

*** Bug 265490 has been marked as a duplicate of this bug. ***

Comment 25

[Mark Banner (:standard8)]

As part of adding facilities for copy or move via drag and drop in bug 35837, I
have submitted a patch to implement the correct transfer of mailing lists from
one book to another. Part of the patch was based on the one attached to this bug
by Sean Gao.

Therefore taking bug, cc'ing seth (original owner) and adding dependency for
35837 so that I remember.

Comment 26

[Ben Luh]

I found a bad drop down list by Mozilla 1.7.7 on Win XP
http://www.tat.com.tw/ 
It was correct on IE.

Comment 27

[Mark Banner (:standard8)]

*** Bug 272994 has been marked as a duplicate of this bug. ***

Comment 28

[zug_treno]

*** Bug 312515 has been marked as a duplicate of this bug. ***

Comment 29

[dominik lenné]

I propose to change the summary of bug 42879 in such way, that the 
term "mailing list" appears in it, instead of only "list". So it is easier to 
find for people who bumped into the problem and want to check, if it already is 
in the bug list. Could save some dupes.
Maybe
"Drag-n-drop of mailing list to another address book changes it into a card"

Comment 30

[Mark Banner (:standard8)]

Changed summary from: Drag-n-drop a list to another AB and appears as a card

Comment 31

[dominik lenné]

I can still reproduce the bug with build 20051201.

Comment 32

[Mark Banner (:standard8)]

*** Bug 320059 has been marked as a duplicate of this bug. ***

Comment 33

[Mark Banner (:standard8)]

This has been fixed by the Part 2 patch on Bug 35837 that I just checked in.

Comment 34

[Hiro]

(In reply to comment #33)
> This has been fixed by the Part 2 patch on Bug 35837 that I just checked in.
> 
The movement of the address list is possible by D&D. 
But It is not possible to copy(Ctrl + D&D) it.

Windows XP SP1
version 3 alpha 1 (20060522)

Comment 35

[Mark Banner (:standard8)]

(In reply to comment #34)
> (In reply to comment #33)
> > This has been fixed by the Part 2 patch on Bug 35837 that I just checked in.
> > 
> The movement of the address list is possible by D&D. 
> But It is not possible to copy(Ctrl + D&D) it.
> 
> Windows XP SP1
> version 3 alpha 1 (20060522)
> 
That is correct. Currently mailing list names have to be unique (bug 170296) and therefore a copy isn't allowed. The main reason mailing list names have to be unique is for autocomplete (otherwise which mailing list is in which ab). Note that I'm not saying we can't implement this in future, but it should be part of bug 170296 if we do.