Last Comment Bug 433531 - Allow making reminder alert popups modal (config option)
: Allow making reminder alert popups modal (config option)
Status: ASSIGNED
[good first bug][lang=js]
:
Product: Calendar
Classification: Client Software
Component: Alarms (show other bugs)
: unspecified
: x86 Linux
: -- normal with 7 votes (vote)
: ---
Assigned To: Merouane Atig
:
:
Mentors: Philipp Kewisch [:Fallen]
: 724895 919168 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-13 10:04 PDT by Hans Deragon
Modified: 2016-11-10 13:09 PST (History)
11 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
433531_v1.patch (2.15 KB, patch)
2015-07-28 14:14 PDT, Merouane Atig
philipp: feedback+
Details | Diff | Splinter Review

Description Hans Deragon 2008-05-13 10:04:04 PDT
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5) Gecko/2008050509 Firefox/3.0b5
Build Identifier: Lightning 0.8, Build 2008033118

The reminder alert popups are not modal.  Thus when a reminder pops up, it remains behind other windows and often goes unnoticed.  Of course, this render reminders useless.

They should be system wide modal.  Or at least, this should be the default option with the option of disabling it in the preferences if people prefer to have the choice.

Reproducible: Always
Comment 1 Hans Deragon 2008-05-14 03:20:25 PDT
Moved this bug to 'critical'.  The #1 feature of a Calandar program is to remind people about events.  If alerts show up under other windows, the whole usefulness of the application is lost.
Comment 2 Stefan Sitter 2008-05-14 03:29:46 PDT
This request is similar Bug 250137, Bug 267925, Bug 313645, Bug 321910, Bug 377806, Bug 388073. 

In Bug 202620 it was decided to not force the window on top but use the platform dependent notification system (e.g. flash the taskbar, bounce the dock icon). 

I also proposed an alarm slider that displays on top of all windows but that proposal was requested (Bug 329676).
Comment 3 Hans Deragon 2008-05-14 04:06:43 PDT
Well, under Ubuntu 08.04, the current solution is unacceptable.

As I mentioned before, make it the default but configurable in the Preferences.

We need a solution that remains on top of all windows and require the user to
click on it to remove it.  I understand the problem with modal windows, but it
is still, of all solutions, the best under Ubuntu 08.04.  I, as a user, want a
modal window that disturb me in what I am doing.  At least, give me this
option.

I started with Lightning last Friday and today I will revert back to Korganizer because of this issue.  Even if I have to manually enter the invitations into Korganizer, at least because of its modal alerts I will not miss any meetings.  I will continue to follow Lightning development and hope that a reliable solution will emerge.

Can someone switch the status of this bug report to 'NEW'?
Comment 4 Philipp Kewisch [:Fallen] 2010-03-05 02:19:44 PST
I doubt we should make this a user visible pref, but I can imagine a hidden pref in about:config. Maybe the prefname being:

calendar.alarms.showModal
Comment 5 Orion Poplawski 2010-11-04 10:40:14 PDT
Likewise for me reminders are nearly useless because of this.  Running Fedora 14 KDE.
Comment 6 Eric Tiffany 2010-11-06 17:18:45 PDT
This problem makes the alarms basically worthless.  There is a about:config option (on Lightning under Postbox on MacOS) that is called ui.use_native_popup_windows and defaults to false.  However, changing this to true just screws up all popups.
Comment 7 Matthew Mecca [:mmecca] 2012-02-08 18:44:18 PST
*** Bug 724895 has been marked as a duplicate of this bug. ***
Comment 8 khaos119 2013-07-11 08:21:30 PDT
Why isn't this getting any attention? Everyone is right, the alert is useless if you aren't being alerted. For this reason alone I have moved to using Chrome. I love FF for firebug and would love to use it more - I will not until this is fixed.
Comment 9 Hernan 2013-09-20 06:57:23 PDT
This apparently change in TB 24 (at least in ubuntu precise), now the reminders list keep in forefront FOR EVER, the problem is that you can not send it to back, so now you can only use any other window of TB (main window, new message, ...) moving the reminder window around and around...
Comment 10 David Weinraub 2013-10-24 02:20:01 PDT
(In reply to Hernan from comment #9)
> This apparently change in TB 24 (at least in ubuntu precise), now the
> reminders list keep in forefront FOR EVER, the problem is that you can not
> send it to back, so now you can only use any other window of TB (main
> window, new message, ...) moving the reminder window around and around...

Exact same issue. Why on earth is it desirable to make this modal? Sigh...
Comment 11 Philipp Kewisch [:Fallen] 2013-10-24 02:33:19 PDT
Because it is meant to be a list of reminders: either you snooze them, or you dismiss them. If you just leave them open it turns into yet another todo list. Anyway, both methods are valid.

The change in tb24 is probably related to the window manager or the Mozilla Platform. We didn't change any code that would affect this, but possibly something further down is influencing this.
Comment 12 David Weinraub 2013-10-24 02:43:21 PDT
(In reply to Philipp Kewisch [:Fallen] from comment #11)
> Because it is meant to be a list of reminders: either you snooze them, or
> you dismiss them. If you just leave them open it turns into yet another todo
> list. Anyway, both methods are valid.
> 
> The change in tb24 is probably related to the window manager or the Mozilla
> Platform. We didn't change any code that would affect this, but possibly
> something further down is influencing this.

Fair enough. But an option to restore the non-modal behavior would be desirable. Thanks for the explanation. ;-)
Comment 13 info 2014-12-01 07:38:46 PST
I willing to start work on the reminders if there is some support.  Please see
https://bugzilla.mozilla.org/show_bug.cgi?id=1092552#c4
Comment 14 David Weinraub 2014-12-01 09:00:21 PST
I'm currently using TB on the Mac and not seeing the same behavior, so not sure I can add much info. Still, if you need something, happy to help where I can. Should I clear the needinfo flag?
Comment 15 Philipp Kewisch [:Fallen] 2014-12-01 13:40:16 PST
Please don't needinfo everyone just to get a comment, I've added the right needinfo on the bug you linked.
Comment 16 info 2014-12-01 14:53:38 PST
(In reply to Philipp Kewisch [:Fallen] from comment #15)
> Please don't needinfo everyone just to get a comment, I've added the right
> needinfo on the bug you linked.

This bug is also affected if work on bug-id 1092552 is started.  So, it's reasonable to have also some feedback of people interested in this bug.
Comment 17 Philipp Kewisch [:Fallen] 2014-12-02 00:42:04 PST
In that case a comment asking folks specific questions should be sufficient, they will all get email because they are on CC. You can needinfo "anyone" if you like. I guess its just formalities, lets not get hung up on it.

Anyway, I think its quite clear what we need in this bug: add a pref that allows making the alarm dialog modal, default to off. I'm not yet sure if this should be a user-visible pref, but we can reiterate this question when the code for the hidden pref is ready.
Comment 18 khaos119 2014-12-02 06:05:02 PST
Haven't used Firefox in over a year for this reason. Also, as a web developer, it's too slow for me. Removing myself from this list. Good luck!
Comment 19 Merouane Atig 2015-07-27 14:15:22 PDT
*** Bug 919168 has been marked as a duplicate of this bug. ***
Comment 20 Merouane Atig 2015-07-27 14:54:25 PDT
I would like to work on this issue. Is it OK to reassign this ticket to me?

I already isolated the part where the alarm window is open as a dialog: https://dxr.mozilla.org/comm-central/source/calendar/base/src/calAlarmMonitor.js#126

I now have to create a hidden pref and set the dialog parameter accordingly. I'm thinking about calling it "calendar.alarms.modal" or "calendar.alarms.alwaysontop".
Comment 21 Merouane Atig 2015-07-28 14:14:38 PDT
Created attachment 8640131 [details] [diff] [review]
433531_v1.patch
Comment 22 Philipp Kewisch [:Fallen] 2015-08-10 17:05:15 PDT
Comment on attachment 8640131 [details] [diff] [review]
433531_v1.patch

Review of attachment 8640131 [details] [diff] [review]:
-----------------------------------------------------------------

Does dialog=yes actually make it modal? IIUC then it was this way before, and for me on mac the reminder dialog is not modal. I'd appreciate if we could make sure the behavior is the same on all platforms. I'd expect this:


showModal = true: When the dialog shows up, the parent calendar window is not actionable until all reminders are dismissed
showModal = false: When the dialog shows up, it appears on top at first, but it can be switched to the main window with alt+tab

In that case, the default for showModal should be false, because this is how it has been for me before. Is this also what you would expect?

::: calendar/base/src/calAlarmMonitor.js
@@ +124,5 @@
>              this.mWindowOpening = Services.ww.openWindow(
>                  null,
>                  "chrome://calendar/content/calendar-alarm-dialog.xul",
>                  "_blank",
> +                "chrome,dialog=" + isDialog +",all,resizable",

nit: space after second +

Note You need to log in before you can comment on or make changes to this bug.