472901 - Google has updated its favicon, again

Status: VERIFIED FIXED

(Firefox :: Search, defect, P2)

Description

[Michael]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; nl; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; nl; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5

Google has yet again updated its favicon (story about it here: http://www.washingtonpost.com/wp-dyn/content/article/2009/01/09/AR2009010902566.html)
Now, the new Firefox 3.1 beta's already have the 2nd newest Google favicon in the search bar, but now it needs to be updated again.

Reproducible: Always

Steps to Reproduce:
1. Open any Firefox 3.1 beta or the 3.2 pre
2. Check out the search bar next to the address bar
3. The icon there is a blue g with a white background
Actual Results:  
The old Google favicon is shown

Expected Results:  
The newest Google favicon should be shown

Comment 1

[Michael]

Attachment: The old Google favicon which needs to be updated

Comment 3

[:Gavin Sharp [email: [e-mail]]]

That bug's already fixed, there's a new icon that we'll need to include. Kev's already getting in touch to get the right image file etc.

Comment 4

[Tyler Downer [He/Him]]

Thanks Gavin.

Comment 5

[Dave Garrett]

Why don't we just add an <IconUpdateUrl> to the XML to avoid this in the future?

Comment 6

[u88484]

Requesting blocking based on Alex's comment in bug 436497 comment 19

Comment 7

[u88484]

Attachment: Comparison Screenshot

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #5)
> Why don't we just add an <IconUpdateUrl> to the XML to avoid this in the
> future?

The search service update system doesn't currently support updating default search plugins.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

That new icon really doesn't work so well with our OS X theme, and even on windows it is complex and visually strong.  I wonder if we could continue to use a "g."  The really old icon was starting to look dated, but if they start doing icon of the month, the risk of us looking out of date becomes less of an issue.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Kev's been in touch with Google, and they've actually asked us to keep the old favicon for the search provider. Dunno what that means, but there you have it.

RESO INVALID for now. If this gets re-opened, it'll pick up blocking status. It should only get re-opened if someone has reason to believe that Google wants otherwise.

Comment 13

[Marc Croteau]

Attachment: New XML file to replace old icon

Simply replace the existing XML file with this one to have the new Google icon

Comment 14

[u88484]

(In reply to comment #13)
> Created an attachment (id=362923) [details]
> New XML file to replace old icon
> Simply replace the existing XML file with this one to have the new Google icon

Read comment #10

Comment 15

[Kev Needham [:kev]]

Google has requested we include the new favicon moving forward w/Fx3.1. 

Re-opening.

Comment 16

[Mike Connor [:mconnor]]

Kev, please let us know if the attachment already here is sufficient.

Comment 17

[Kev Needham [:kev]]

Attachment: Google search plugin (from default en-US) with current favicon from google.com

ML file looks good. patch for the default google plugin, based on the XML provided, attached.

Comment 18

[Mike Connor [:mconnor]]

Comment on attachment 364304 [details] [diff] [review]
Google search plugin (from default en-US) with current favicon from google.com 

ok.

Comment 19

[Mike Connor [:mconnor]]

http://hg.mozilla.org/mozilla-central/rev/bde86005c2ea

Comment 20

[Daniel.S]

I think this caused bug 480707.

Comment 21

[(mostly gone) XtC4UaLL [:xtc4uall]]

nope, as of https://bugzilla.mozilla.org/show_bug.cgi?id=480698#c0 it's bug 311053.

Comment 22

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/86d24010fcec

Comment 23

[Marcia Knous [:marcia]]

Verified fixed on the trunk using  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090302 Minefield/3.2a1pre and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090302 Minefield/3.2a1pre.

Verified fixed on the 1.9.1. branch using  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090302 Shiretoko/3.1b3pre and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090302 Shiretoko/3.1b3pre.

Comment 24

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the
user may encounter several times a day.

This change impacted the main window, and users will probably notice that the
icon is a bit more garishly branding the search field now (especially in an
otherwise entirely monochrome theme on OS X).