Open Bug 590297 Opened 13 years ago Updated 1 year ago

Dropping a tab in another window should transform it into the same type as that of the drop region

Categories

(Firefox :: Tabbed Browser, enhancement)

Product:
Firefox
Component:
Tabbed Browser
Type:
enhancement

Tracking

()

Status:
REOPENED

People

(Reporter: tchung, Unassigned)

References

(Depends on 1 open bug, Blocks 2 open bugs)

Details

If you open two browser windows, where one has app tabs created, and the other has a normal browser tab, dragging the normal tab into the 2nd browser window-App tab row, will just keep it as a normal tab.  Instead of becoming an app tab.

Alternately, if within the same browser window, i can drag a normal tab into the app tab row and watch it turn into an App tab

Repro:
1) install Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100824 Minefield/4.0b5pre
2) create two browser windows.  One should have a few app tabs already made.  The other should have normal tabs in it
3) Take a normal tab from browser window 2, and drag it to the App tab area in browser window 1
4) verify the normal tab sticks in window 2 as a "normal tab", instead of an "App tab"

Expected:
- dragging a normal tab into a app tab pane on another browser should stick as an App Tab

Actual:
- doing the above only generates a normal tab instead of an App tab
Punting to the future.
Target Milestone: --- → Future
duplicate of bug 579482?
Blocks: pinnedtabs
Why is that under TabCandy? Moving to the correct component.
Component: TabCandy → Tabbed Browser
QA Contact: tabcandy → tabbed.browser
Target Milestone: Future → ---
Depends on: 455694
While app tabs will be global in the long-term plan, doing this makes the most sense in the interaction model for bug 455694 until they become global.

In fact, the behavior of the patch in bug 455694 fixes this bug.

However, this doesn't block bug 551849, because it wasn't part of the original plan, and it still isn't.
No longer blocks: pinnedtabs
Status: NEW → ASSIGNED
Summary: Unable to DnD normal tab into App tab in another browser window → Dropping a tab in another window should transform it into the same type as that of the drop region
No longer depends on: 579482
My patch for bug 455694 fixes this.
Assignee: nobody → fryn
Fixed by patch in bug 455694.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Verified fixed in Firefox 8.0b1.
Status: RESOLVED → VERIFIED
Keywords: verified-beta
Whiteboard: [qa!][testday-20110930]
this is broken in 12.0b1, probably due to 455694 backout
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Assignee: fryn → nobody
Keywords: verified-beta
Whiteboard: [qa!][testday-20110930]
Target Milestone: Firefox 8 → ---
Depends on: 674925
Blocks: 886154
this is now wfm. however i think this should be retracted see bug 886154
Blocks: 1637238
Type: defect → enhancement
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.