Remove start menu directory and safe mode shortcut creation

RESOLVED FIXED in Firefox 4.0b10

Status

()

defect
RESOLVED FIXED
9 years ago
3 years ago

People

(Reporter: ddahl, Assigned: rstrong)

Tracking

(Blocks 2 bugs, {relnote})

Trunk
Firefox 4.0b10
x86
Windows 7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

(Whiteboard: [softblocker])

Attachments

(1 attachment)

Reporter

Description

9 years ago
we have added a start in safe mode menu item, but need to patch the installer to not create the directory and safe mode shortcut that sits in the start menu

this is a spin off of bug 542122
Reporter

Comment 1

9 years ago
nsis patch is started here: https://bugzilla.mozilla.org/attachment.cgi?id=477147
Reporter

Updated

9 years ago
blocking2.0: --- → ?
I think this should block final but getting it for beta 7 is a bit risky.
blocking2.0: ? → betaN+
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED

Updated

9 years ago
Blocks: safe-mode
We will also need to add a keyboard modifier that, when held, causes Firefox to start in Safe Mode. This functionality already exists on OSX.

Comment 4

9 years ago
Just to confirm, we're not getting rid of the -safe-mode command-line flag right?
(In reply to comment #4)
> Just to confirm, we're not getting rid of the -safe-mode command-line flag
> right?

Most definitely not, but I don't really consider that a user-friendly way of invoking the mode.
When Firefox is the default browser, the pinned icon in the start menu (in Vista at least) when right-clicked provides the option of starting in safe mode.
(In reply to comment #3)
> We will also need to add a keyboard modifier that, when held, causes Firefox to
> start in Safe Mode. This functionality already exists on OSX.
Filed bug 602562 to add this

(In reply to comment #6)
> When Firefox is the default browser, the pinned icon in the start menu (in
> Vista at least) when right-clicked provides the option of starting in safe
> mode.
That functionality is not present in Windows 7
Depends on: 602562
(In reply to comment #7)
> (In reply to comment #6)
> > When Firefox is the default browser, the pinned icon in the start menu (in
> > Vista at least) when right-clicked provides the option of starting in safe
> > mode.
> That functionality is not present in Windows 7

That should be handled over here in bug 519985 where its already been discussed to include on jumplist.
If Firefox is not set as the default it won't be available on Vista and below. I agree it should be added to the jumplist in bug but the point is that adding it to the jumplist won't meet all of the requirements as stated. Let's keep this bug about removing the shortcuts after the requirements have been met.
Whiteboard: [softblocker]
Comment on attachment 502856 [details] [diff] [review]
patch rev1

Looks good. Are the added ShellLink::SetShortCutWorkingDirectory call required to make this work?
Attachment #502856 - Flags: review?(jmathies) → review+
BTW, great idea, the start menu folder is annoying.
(In reply to comment #11)
> Comment on attachment 502856 [details] [diff] [review]
> patch rev1
> 
> Looks good. Are the added ShellLink::SetShortCutWorkingDirectory call required
> to make this work?
Only when $OUTDIR isn't the installation directory... I added those "just in case" and for consistency.
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/48b711ffd411
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite-
Flags: in-litmus?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b10
Is this suppose to remove it when we update from a nightly?
On update, if the start menu directory exists and contains a shortcut (based on the shortcut_log.ini) that points to the install location it creates the new shortcut in the root of the start menu, removes the shortcuts from the directory and if the directory is empty (which it should be) removes the directory.

On install, if the start menu directory exists and contains a shortcut (based on the shortcut_log.ini) that points to the install location it removes the shortcuts from the directory and if the directory is empty (which it should be) removes the directory. It by default will create the shortcut in the root of the start menu unless the choice to create the start menu shortcut is unchecked.
cc'ing some SeaMonkey and Thunderbird people in case they would like to do this as well.
(In reply to comment #16)
> On update, if the start menu directory exists and contains a shortcut (based on
> the shortcut_log.ini) that points to the install location it creates the new
> shortcut in the root of the start menu, removes the shortcuts from the
> directory and if the directory is empty (which it should be) removes the
> directory.
This part isn't working... filed Bug 627848

Updated

9 years ago
Keywords: relnote
We'll just rely on bug reports for regressions instead of a litmus test
Flags: in-litmus?

Updated

3 years ago
Flags: needinfo?(bugzilla)

Updated

3 years ago
Flags: needinfo?(info)

Updated

3 years ago
Flags: needinfo?(info)
Flags: needinfo?(bugzilla)
You need to log in before you can comment on or make changes to this bug.