598779 - Remove start menu directory and safe mode shortcut creation

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[David Dahl :ddahl]

we have added a start in safe mode menu item, but need to patch the installer to not create the directory and safe mode shortcut that sits in the start menu

this is a spin off of bug 542122

Comment 1

[David Dahl :ddahl]

nsis patch is started here: https://bugzilla.mozilla.org/attachment.cgi?id=477147

Comment 2

[Robert Strong (they/them - no direct email)]

I think this should block final but getting it for beta 7 is a bit risky.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

We will also need to add a keyboard modifier that, when held, causes Firefox to start in Safe Mode. This functionality already exists on OSX.

Comment 4

[[:Cww]]

Just to confirm, we're not getting rid of the -safe-mode command-line flag right?

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #4)
> Just to confirm, we're not getting rid of the -safe-mode command-line flag
> right?

Most definitely not, but I don't really consider that a user-friendly way of invoking the mode.

Comment 6

[Nochum Sossonko [:Natch]]

When Firefox is the default browser, the pinned icon in the start menu (in Vista at least) when right-clicked provides the option of starting in safe mode.

Comment 7

[Robert Strong (they/them - no direct email)]

(In reply to comment #3)
> We will also need to add a keyboard modifier that, when held, causes Firefox to
> start in Safe Mode. This functionality already exists on OSX.
Filed bug 602562 to add this

(In reply to comment #6)
> When Firefox is the default browser, the pinned icon in the start menu (in
> Vista at least) when right-clicked provides the option of starting in safe
> mode.
That functionality is not present in Windows 7

Comment 8

[[not reading bugmail]]

(In reply to comment #7)
> (In reply to comment #6)
> > When Firefox is the default browser, the pinned icon in the start menu (in
> > Vista at least) when right-clicked provides the option of starting in safe
> > mode.
> That functionality is not present in Windows 7

That should be handled over here in bug 519985 where its already been discussed to include on jumplist.

Comment 9

[Robert Strong (they/them - no direct email)]

If Firefox is not set as the default it won't be available on Vista and below. I agree it should be added to the jumplist in bug but the point is that adding it to the jumplist won't meet all of the requirements as stated. Let's keep this bug about removing the shortcuts after the requirements have been met.

Comment 10

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 11

[Jim Mathies [:jimm]]

Comment on attachment 502856 [details] [diff] [review]
patch rev1

Looks good. Are the added ShellLink::SetShortCutWorkingDirectory call required to make this work?

Comment 12

[Jim Mathies [:jimm]]

BTW, great idea, the start menu folder is annoying.

Comment 13

[Robert Strong (they/them - no direct email)]

(In reply to comment #11)
> Comment on attachment 502856 [details] [diff] [review]
> patch rev1
> 
> Looks good. Are the added ShellLink::SetShortCutWorkingDirectory call required
> to make this work?
Only when $OUTDIR isn't the installation directory... I added those "just in case" and for consistency.

Comment 14

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/48b711ffd411

Comment 15

[[not reading bugmail]]

Is this suppose to remove it when we update from a nightly?

Comment 16

[Robert Strong (they/them - no direct email)]

On update, if the start menu directory exists and contains a shortcut (based on the shortcut_log.ini) that points to the install location it creates the new shortcut in the root of the start menu, removes the shortcuts from the directory and if the directory is empty (which it should be) removes the directory.

On install, if the start menu directory exists and contains a shortcut (based on the shortcut_log.ini) that points to the install location it removes the shortcuts from the directory and if the directory is empty (which it should be) removes the directory. It by default will create the shortcut in the root of the start menu unless the choice to create the start menu shortcut is unchecked.

Comment 17

[Robert Strong (they/them - no direct email)]

cc'ing some SeaMonkey and Thunderbird people in case they would like to do this as well.

Comment 18

[Robert Strong (they/them - no direct email)]

(In reply to comment #16)
> On update, if the start menu directory exists and contains a shortcut (based on
> the shortcut_log.ini) that points to the install location it creates the new
> shortcut in the root of the start menu, removes the shortcuts from the
> directory and if the directory is empty (which it should be) removes the
> directory.
This part isn't working... filed Bug 627848

Comment 20

[Robert Strong (they/them - no direct email)]

We'll just rely on bug reports for regressions instead of a litmus test