63220 - Apply theme button not visible when opening pref panel

Status: VERIFIED DUPLICATE of bug 54679

(Core Graveyard :: Skinability, defect)

Description

[Jaime Rodriguez, Jr.]

1. Launch N6
2. Select Edit | Preferences
3. From the Preference window, select Appearance | Themes
4. Select the "Classic" Theme
5. Click OK.

Results: Doesn't change the theme.

Note: I think there use to be an "Apply Theme" button.

Comment 1

[Jaime Rodriguez, Jr.]

Adding Tpringle to cc: list.

Comment 2

[Blake Ross]

Pressing OK doesn't change the theme; Apply Theme does that.  I don't know why 
you don't seem to have an apply theme...wfm in new trunk builds.

Comment 3

[Jaime Rodriguez, Jr.]

I'm using Build ID 2000121804. Please see attached screen shot for Prefrences
window.

Comment 4

[Jaime Rodriguez, Jr.]

Attachment: Netscape 6 Prefrences Window w/o Apply Theme button

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Blake, I don't have an Apply Theme button either, on all my boxes here, Mac,
Linux and Win.  Build 2000121804, commercial.

Comment 6

[Blake Ross]

Seems like a dup of the recent window resizing bugs.

Comment 7

[R.K.Aa.]

apply <theme> button was still present on linux 2000121621

Comment 8

[Matthew Miller]

No "apply theme" button on my build from CVS this morning. (Linux)

Comment 9

[Jaime Rodriguez, Jr.]

Changing OS to ALL.

Comment 10

[Matthew Miller]

This is definitely a window-sizing issue -- the apply button *is* actually there
if you stretch the window larger. (On both Linux and Win32.)

Comment 11

[Fabian Guisset]

Does it still happen? The dialog issue has been fixed.. I have an apply theme
button too. OK does not apply theme, there's another bug about that

Comment 12

[Matthew Miller]

Yes, happened on a build from this morning. The "apply" button works for me once
I can see it.

Comment 13

[Jaime Rodriguez, Jr.]

Agreed, this is a window sizing issue.

Comment 14

[Jaime Rodriguez, Jr.]

Ftang - This is not an International bug, its a CORE bug.

Comment 15

[Jesse Ruderman]

*** Bug 64627 has been marked as a duplicate of this bug. ***

Comment 16

[Boris Zbarsky [:bzbarsky]]

Bug 64627 has a patch that attempts to fix this problem

Comment 17

[Stephen Walker]

*** Bug 64863 has been marked as a duplicate of this bug. ***

Comment 18

[Fabian Guisset]

*** Bug 64897 has been marked as a duplicate of this bug. ***

Comment 19

[Fabian Guisset]

It seems this bug has shifted. Bug 44032 deals with the OK button not applying 
theme. Apprently this bug now handles the fact that the "Apply theme" button is 
not visible when the pref pannel is opened (you have to resize the window).
Resummarizing. Shouldn't this go to pref?

Comment 20

[Peter Lairo]

All that needs to be changed is the size of the theme list (white area). This
area needs to be shortened so that the Apply Theme button and the corresponding
info appear. This should definetely be a low effort, high return bug.

I'm no programmer, but it seems that merely the definition of the white area
Y-coordinate needs to be changed to a smaller value. Otherwise, one would have
to change the default size (height) of the entire prefs window - not desirable.

What happens when the list of installed themes is longer than the viewable area?
Currently, it i reduce the prefs window to be smaller than the list of 3 themes,
NO vertical scrollbar appears. Of course, there should be a vert scrollbar if
the list of themes becomes long. I hope this doesn't need to be a separate bug
report.

Comment 21

[Blake Ross]

No, something obviously changed with tree sizing or sizeToContent(), and we need 
to figure out what it is (rather than just resizing the tree and closing this).

Comment 22

[R.K.Aa.]

*** Bug 64967 has been marked as a duplicate of this bug. ***

Comment 23

[sairuh (rarely reading bugmail)]

*** Bug 64220 has been marked as a duplicate of this bug. ***

Comment 24

[Fabian Guisset]

Blake : I suspect bug 63224. There was a big bad bug that caused sizeToContent()
to mess up on windows and to crash on linux. [e-mail] says it was
fixed (resolved invalid) but nowhere have I seen any fix, nor any change to the
sizeToContent() function. This needs to be looked at further.
Is this really a skinability bug? I say it's a general window bug.

Comment 25

[sairuh (rarely reading bugmail)]

this seems to be dependent on bug 53375 [although i'm not sure if the fix there
will take care of this issue] --they're at least very related from a UI
perspective...

Comment 26

[Paul Chen]

Adding polish and dogfood keywords. Marking nsbeta1-. We are going to fix this,
that's why I've marked it as dogfood, but I don't think Ben will have time
during beta1.

Comment 27

[Matthew T (active 1999-2002)]

[Note to QA: transfer dependency]


*** This bug has been marked as a duplicate of 54679 ***

Comment 28

[[e-mail] (gone - use [e-mail] instead)]

verified dup, and I made bug 54679 dependant upon bug 53375.