If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

release Add-on SDK 1.0

RESOLVED FIXED in 1.0

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: myk, Assigned: dcm)

Tracking

unspecified
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

6 years ago
We should release Add-on SDK 1.0!

Use this bug to track tasks that need to be done to release the product, like spinning candidate builds and publishing a blog post about it, as well as code blockers for the release.

To nominate a bug to block the release, comment in this bug or ask the drivers (Dave Mason or Myk Melez) about it in the discussion group, on IRC, or by email.
(Reporter)

Updated

6 years ago
Depends on: 601295
(Reporter)

Updated

6 years ago
Depends on: 607171
(Reporter)

Updated

6 years ago
Depends on: 627467
(Reporter)

Updated

6 years ago
Depends on: 658622
(Reporter)

Updated

6 years ago
Depends on: 660136
Can we add bug 659683?
(Reporter)

Comment 2

6 years ago
(In reply to comment #1)
> Can we add bug 659683?

Yes, this blocks because it blocks a blocker (bug 627467).
Depends on: 659683
(Reporter)

Updated

6 years ago
Depends on: 660680, 660695
I think we should add bug 660873 as a blocker.
I think we should make Bug 660862 a blocker as well!
With (In reply to comment #3)
> I think we should add bug 660873 as a blocker.

After discovering actual reason of a bug https://bugzilla.mozilla.org/show_bug.cgi?id=660873#c3 I no longer thing we need to make it a blocker.
Bug 660880 seems to be the kind of bug that should block a release.
Widget API brokes down when a user close a window.
(Reporter)

Updated

6 years ago
Depends on: 661300
(Reporter)

Updated

6 years ago
Blocks: 661303
(Reporter)

Comment 7

6 years ago
(In reply to comment #4)
> I think we should make Bug 660862 a blocker as well!

This is unfortunate, but it doesn't seem to rise to the level of blocker, since it makes widgets look worse, but it doesn't affect their functionality.  It also only affects widgets that are moved, and it seems like only a minority of users actually customize their toolbars (although perhaps a larger number of addon users do so).
(Reporter)

Comment 8

6 years ago
(In reply to comment #6)
> Bug 660880 seems to be the kind of bug that should block a release.
> Widget API brokes down when a user close a window.

Hmm, yeah, it does seem fairly bad, perhaps worth blocking the release for (fortunately it has already been fixed).
Depends on: 660880
Do you think bug 661615 is worth blocking for, at least until we understand why it's happening?
Bug 661652 should be a blocker, I think,
(Reporter)

Comment 11

6 years ago
(In reply to comment #9)
> Do you think bug 661615 is worth blocking for, at least until we understand
> why it's happening?

Indeed, we want lots of people to try out that tutorial, so it's important that it work.
Depends on: 661615
(Reporter)

Comment 12

6 years ago
(In reply to comment #10)
> Bug 661652 should be a blocker, I think,

Hmm, Dave and I have mixed feelings, but it seems sufficiently noticeable to be a bad enough experience to justify blocking.
Depends on: 661652
(Reporter)

Updated

6 years ago
Blocks: 661929
should Bug 661929 be a blocker? It sounds like flightdeck needs it, and it's a non-trivial change.
also Bug 661082 (copy "homepage" correctly from package.json into install.rdf) is r+ and scheduled for 1.0 . Should I land it?

Comment 15

6 years ago
i think the following should be a blocker:
https://bugzilla.mozilla.org/show_bug.cgi?id=662041
(In reply to comment #12)
> (In reply to comment #10)
> > Bug 661652 should be a blocker, I think,
> 
> Hmm, Dave and I have mixed feelings, but it seems sufficiently noticeable to
> be a bad enough experience to justify blocking.

We are going to fix bug 661652. But then, we may want to block on bug 662322 as it will help solving color issues in any case.

And I confirm that we have to block on bug 662041 as it breaks jquery in content scripts.
(Reporter)

Updated

6 years ago
Blocks: 662041
(Reporter)

Updated

6 years ago
No longer blocks: 661303, 661929, 662041
Depends on: 661303, 661929, 662041
(Reporter)

Updated

6 years ago
Depends on: 662471
Bug 663048 should probably be fixed for 1.0. Really similar to what happened in bug 662471.
(Reporter)

Comment 18

6 years ago
(In reply to comment #17)
> Bug 663048 should probably be fixed for 1.0. Really similar to what happened
> in bug 662471.

This seems less likely to occur than the related bug about capital letters in directory names, and thus it doesn't rise to the level of a blocker, but it is definitely important to fix, and we should make sure to mention it in the release notes.
(Reporter)

Updated

6 years ago
Depends on: 663268
But 664001 is a blocker, I'm afraid.
Is bug 664017 a blocker, too? It's not, necessarily, a code blocker, even if it has to be fixed before we launch.
(Reporter)

Updated

6 years ago
Depends on: 664001
(Reporter)

Comment 21

6 years ago
(In reply to comment #19)
> But 664001 is a blocker, I'm afraid.

Drivers agreed and marked it as such.


(In reply to comment #20)
> Is bug 664017 a blocker, too? It's not, necessarily, a code blocker, even if
> it has to be fixed before we launch.

Drivers decided not to block on it, as it doesn't sound like a common-enough case for our developer audience.  But we'll still take the fix as a low-risk ride-along, and the same goes for the fix for bug 664268.
Working on real addon usecase (hernan's grooveshark addon) help me to find a bug in workers. See bug 664471 for further details.
This bug blocks this addon from working with emit functions, but it may be because of very specific flash usage. Else it is more a security issue than something that would prevent an addon/API from working.
Then, I have to mention bug 660780, which is about giving access to document JS values.
Considering the amount of people that came to ask for this, we may consider this as a blocker. We had two people on the group (Naohiro and one another), hernan with his grooveshark addon that depends on this feature, cardorn (on irc) seems to use it too. I'll try to send a message on the group to see if there is other people concerned.
(Reporter)

Updated

6 years ago
Depends on: 664471
(Reporter)

Updated

6 years ago
Depends on: 660780
(Reporter)

Comment 24

6 years ago
Bug 664471 and bug 660780 have been added as blockers.
(Reporter)

Comment 25

6 years ago
We might want to spin another RC for bug 665017.
(Reporter)

Comment 26

6 years ago
(In reply to comment #25)
> We might want to spin another RC for bug 665017.

After thinking about it all day, I've decided that it's a significant enough blight on docs that we expect many new developers to see that it's worth spinning another RC just for this fix.
Depends on: 665017
I have to mention another bug on content scripts. Bug 665280. 
Scripts using XPathResult's constants will throw error or behave incorrectly without this fix. Simple usage of XPath isn't concerned.

Then, I'd really appreciate having bug 665281 fixed in 1.0. But I don't think it worth spinning a new rc only for it. So I'd only push for it if we already spin another one.

myk: I asked for your review in both cases as it is easier having you as you may approve/review/land them in a row. But feel free to forward reviews to irakli.
(Reporter)

Comment 28

6 years ago
(In reply to comment #27)
> I have to mention another bug on content scripts. Bug 665280. 
> Scripts using XPathResult's constants will throw error or behave incorrectly
> without this fix. Simple usage of XPath isn't concerned.
> 
> Then, I'd really appreciate having bug 665281 fixed in 1.0. But I don't
> think it worth spinning a new rc only for it. So I'd only push for it if we
> already spin another one.

Drivers discussed these at today's daily triage session and agreed that they don't rise to the severity of blockers for the release, although we'd like to see them fixed in 1.1 and have triaged them accordingly.
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.