Closed Bug 713852 Opened 8 years ago Closed 8 years ago

Fix strange tab appearance due to change in border-image behaviour

Categories

(Thunderbird :: Toolbars and Tabs, defect)

x86
Linux
defect
Not set

Tracking

(thunderbird12 fixed, thunderbird13 fixed)

RESOLVED FIXED
Thunderbird 13.0
Tracking Status
thunderbird12 --- fixed
thunderbird13 --- fixed

People

(Reporter: mconley, Assigned: Paenglab)

References

Details

Attachments

(3 files, 1 obsolete file)

Protz sent me this bug report over email, saying that the tab icon looks a bit off.  He linked to this screenshot (which I'm currently unable to view): http://jonathan.protzenko.free.fr/shutter/Selection_001.png. 

He then mentioned that adding padding-left: 5px to the <tab> itself fixes the issue nicely.
Summary: Tab Icon is a bit off when Personas on Linux → Tab Icon is a bit off
See also http://dl.dropbox.com/u/2301433/Screenshots/ThatsNotRight.png on Mac (as reported on Twitter…  ;)

(Cc-ing Paenglab, cause he does excellent theme work.)

Later,
Blake.
Attached patch Fix the border-image definitions (obsolete) — Splinter Review
This is a fallout of Bug 497995. This patch follows the changes in this bug plus tries to better align the tab-icons with the tab-text.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #584609 - Flags: ui-review?(mconley)
Attachment #584609 - Flags: review?(mconley)
Comment on attachment 584609 [details] [diff] [review]
Fix the border-image definitions

Richard:

This fixes up the appearance of the tabs nicely!  Great work!

One thing I've noticed is that when hovering non-selected tabs, the background colour of the hovered tab changes but the border stays the same colour, giving it a weird box-y look.  Any way to fix that here?

Thanks,

-Mike
Attachment #584609 - Flags: ui-review?(mconley) → ui-review-
Oh, I should mention - Noticed the above appearance on OSX.
Sorry missed the hover definition under Mac.
Attachment #584609 - Attachment is obsolete: true
Attachment #584609 - Flags: review?(mconley)
Attachment #584762 - Flags: ui-review?(mconley)
Attachment #584762 - Flags: review?(mconley)
Comment on attachment 584762 [details] [diff] [review]
Fix the border-image definitions v2

Review of attachment 584762 [details] [diff] [review]:
-----------------------------------------------------------------

The code looks good to me, and so far looks good on OSX, Windows 7 Aero Glass and Basic, and GNOME.  Going to check Windows XP next.
Attachment #584762 - Flags: review?(mconley) → review+
Comment on attachment 584762 [details] [diff] [review]
Fix the border-image definitions v2

Looks good to me - thanks Paenglab, looks good.
Attachment #584762 - Flags: ui-review?(mconley) → ui-review+
Keywords: checkin-needed
Checked in to comm-central as http://hg.mozilla.org/comm-central/rev/4c03954be2d1

Removing tracking for TB 11, because I don't think the border-image changes landed in Mozilla 11.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Summary: Tab Icon is a bit off → Fix strange tab appearance due to change in border-image behaviour
Patch for backout in aurora. Not tested, but should work because only the border-image definitions are changed to the old notation.
Attachment #604537 - Flags: review?(mconley)
Comment on attachment 604537 [details] [diff] [review]
Patch for backout in aurora

This looks good to me.

We'll want to apply this backout only to comm-aurora.
Attachment #604537 - Flags: review?(mconley)
Attachment #604537 - Flags: review+
Attachment #604537 - Flags: approval-mozilla-aurora?
Duplicate of this bug: 734630
Blocks: 497995
Comment on attachment 604537 [details] [diff] [review]
Patch for backout in aurora

[Triage Comment]
a=me for backout.
Attachment #604537 - Flags: approval-mozilla-aurora? → approval-comm-aurora+
Duplicate of this bug: 735002
Blocks: 735108
So this is now "fixed" in 13, but due to the backout, marking as fixed in 12 to keep flag comparisons happy.
Target Milestone: Thunderbird 12.0 → Thunderbird 13.0
Bug 497995 got backed out last minute for 13, so we're going to have to do the same backout here.

Going to see if Paenglab's patch applies to beta.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 604537 [details] [diff] [review]
Patch for backout in aurora

Due to the backout of bug 497955 on beta (13), this patch will need to be applied there.
Attachment #604537 - Flags: approval-comm-beta?
Duplicate of this bug: 749891
Attachment #604537 - Flags: approval-comm-beta? → approval-comm-beta+
Duplicate of this bug: 750043
Backed out of comm-beta (TB 13) as http://hg.mozilla.org/releases/comm-beta/rev/028c8a8a8beb.

As in https://bugzilla.mozilla.org/show_bug.cgi?id=713852#c16, marking as fixed in 13 to keep flag comparisons happy.
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Duplicate of this bug: 750617
Duplicate of this bug: 750720
Duplicate of this bug: 751063
Duplicate of this bug: 751473
Duplicate of this bug: 752645
Duplicate of this bug: 754870
Depends on: 763394
You need to log in before you can comment on or make changes to this bug.