713852 - Fix strange tab appearance due to change in border-image behaviour

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Protz sent me this bug report over email, saying that the tab icon looks a bit off.  He linked to this screenshot (which I'm currently unable to view): http://jonathan.protzenko.free.fr/shutter/Selection_001.png. 

He then mentioned that adding padding-left: 5px to the <tab> itself fixes the issue nicely.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Screenshot of problem

Comment 2

[Blake Winton (:bwinton) (:☕️)]

See also http://dl.dropbox.com/u/2301433/Screenshots/ThatsNotRight.png on Mac (as reported on Twitter…  ;)

(Cc-ing Paenglab, cause he does excellent theme work.)

Later,
Blake.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Fix the border-image definitions

This is a fallout of Bug 497995. This patch follows the changes in this bug plus tries to better align the tab-icons with the tab-text.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 584609 [details] [diff] [review]
Fix the border-image definitions

Richard:

This fixes up the appearance of the tabs nicely!  Great work!

One thing I've noticed is that when hovering non-selected tabs, the background colour of the hovered tab changes but the border stays the same colour, giving it a weird box-y look.  Any way to fix that here?

Thanks,

-Mike

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Oh, I should mention - Noticed the above appearance on OSX.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Fix the border-image definitions v2

Sorry missed the hover definition under Mac.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 584762 [details] [diff] [review]
Fix the border-image definitions v2

Review of attachment 584762 [details] [diff] [review]:
-----------------------------------------------------------------

The code looks good to me, and so far looks good on OSX, Windows 7 Aero Glass and Basic, and GNOME.  Going to check Windows XP next.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 584762 [details] [diff] [review]
Fix the border-image definitions v2

Looks good to me - thanks Paenglab, looks good.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Checked in to comm-central as http://hg.mozilla.org/comm-central/rev/4c03954be2d1

Removing tracking for TB 11, because I don't think the border-image changes landed in Mozilla 11.

Comment 10

[Richard Marti (:Paenglab)]

Attachment: Patch for backout in aurora

Patch for backout in aurora. Not tested, but should work because only the border-image definitions are changed to the old notation.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 604537 [details] [diff] [review]
Patch for backout in aurora

This looks good to me.

We'll want to apply this backout only to comm-aurora.

Comment 13

[Mark Banner (:standard8)]

Comment on attachment 604537 [details] [diff] [review]
Patch for backout in aurora

[Triage Comment]
a=me for backout.

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Backed out of comm-aurora:  http://hg.mozilla.org/releases/comm-aurora/rev/dc97cb1e9c00

Comment 16

[Mark Banner (:standard8)]

So this is now "fixed" in 13, but due to the backout, marking as fixed in 12 to keep flag comparisons happy.

Comment 17

[Mike Conley (:mconley) (:⚙️)]

Bug 497995 got backed out last minute for 13, so we're going to have to do the same backout here.

Going to see if Paenglab's patch applies to beta.

Comment 18

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 604537 [details] [diff] [review]
Patch for backout in aurora

Due to the backout of bug 497955 on beta (13), this patch will need to be applied there.

Comment 21

[Mike Conley (:mconley) (:⚙️)]

Backed out of comm-beta (TB 13) as http://hg.mozilla.org/releases/comm-beta/rev/028c8a8a8beb.

As in https://bugzilla.mozilla.org/show_bug.cgi?id=713852#c16, marking as fixed in 13 to keep flag comparisons happy.