716214 - TB: Keyboard Shortcuts broken(?)/wrong/incomplete in documentation: Ctrl+0, Ctrl++, Ctrl+-

Status: RESOLVED FIXED

(Thunderbird :: Help Documentation, defect)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #716101 +++

Thunderbird Keyboard Shortcuts documentation (1) currently has this:

==Message functions==
Increase Text Size	Ctrl + +
Decrease Text Size	Ctrl + -
Restore Text Size	Ctrl + 0

That's nonsense without explanation:
*For reading messages*, Ctrl++/-/0 will change the *zoom* level, not the text size.
Only *for writing messages*, Ctrl++/- will change *size* of text, and Ctrl+0 does nothing.
==Message functions== section is only about reading messages, because we have a separate section for ==Writing messages== (and, OT, ==Message functions== really is not a very telling headline, and we need more sections here).

So in ==Message functions== section we should have:

Zoom In 	Ctrl + +
Zoom Out	Ctrl + -
Reset Zoom	Ctrl + 0

And another documentation problem about the same shortcut further down the list (1):

==Writing Messages==
Restore Text Size: Ctrl+0

For composition only (!), this doesn't work for Windows (can't test elsewhere). Note that in composition, ctrl++ and ctrl+- make the actual *font size* of selected text bigger/smaller, so Ctrl+0 should really restore the default text size (and not the zoom as we do for reading). On windows, Ctrl+0 doesn't do anything in composition. Does it work on other OS?
Is it a regression?

Maybe somebody can explain the expected and current behaviour for all OS, so that we can fix the documentation, or create bugs as necessary.

(1) https://support.mozillamessaging.com/en-US/kb/keyboard-shortcuts

Comment 1

[rsx11m]

(In reply to Thomas D. from comment #0)
> *For reading messages*, Ctrl++/-/0 will change the *zoom* level, not the
> text size.

Note that browser.zoom.full is false in Thunderbird, thus in contrast to Firefox and SeaMonkey, images as part of the message won't be zoomed along with the text. Changing the text only is therefor correct in general, but as written ambiguous given that the display/compose context isn't considered.

Comment 2

[Thomas D. (:thomas8)]

(In reply to rsx11m from comment #1)
> (In reply to Thomas D. from comment #0)
> > *For reading messages*, Ctrl++/-/0 will change the *zoom* level, not the
> > text size.
> 
> Note that browser.zoom.full is false in Thunderbird, thus in contrast to
> Firefox and SeaMonkey, images as part of the message won't be zoomed along
> with the text. Changing the text only is therefor correct in general, but as
> written ambiguous given that the display/compose context isn't considered.

Good point. But we can't put "Zoom text" because it's actually just "Zoom", and, as you correctly point out, what will be zoomed or not really depends on the browser.zoom.full setting, which might be true or false depending on customization, and the behaviour of the shortcut will change accordingly.

So I'm not reading comment 2 as an explanation, but not an objection against comment 1. So I'll go for comment 1:

> in ==Message functions== section we should have:
> Zoom In 	Ctrl + +
> Zoom Out	Ctrl + -
> Reset Zoom	Ctrl + 0

For ==Writing Messages==, I suggest we remove documentation for "Restore Text Size: Ctrl+0" until it is fixed and/or verified for other OS.

Comment 3

[Thomas D. (:thomas8)]

(In reply to Thomas D. from comment #2)
> So I'm not reading comment 2 as an explanation, but not an objection against
> comment 1. So I'll go for comment 1:

Typo fix: I *am* reading comment 2 as an explanation, but not an objection against comment 1.

With sreepriya, I landed the following changes (1):

> > in ==Message functions== section we should have:
> > Zoom In 	Ctrl + +
> > Zoom Out	Ctrl + -
> > Reset Zoom	Ctrl + 0

updated.

> For ==Writing Messages==, I suggest we remove documentation for "Restore
> Text Size: Ctrl+0" until it is fixed and/or verified for other OS.

removed. Needs further verification for Unix/MAC, and followup bug.

(1) https://support.mozillamessaging.com/en-US/kb/keyboard-shortcuts/revision/5614

Comment 4

[Thomas D. (:thomas8)]

Verification of the actual behaviour of these shortcuts in composition would still be appreciated:

STR:

On Linux:
- composition, type "hello world", select, increase font size (Ctrl++)
- Ctrl+0 -> Actual result?
- new composition, type "hello world", increase zoom (Ctrl+mousewheel)
- Ctrl+0 -> Actual result?

On Mac:
- composition, type "hello world", select, increase font size (Ctrl++)
- Cmd+0 -> Actual result?
- new composition, type "hello world", increase zoom (Cmd+Ctrl+mousewheel)
- Cmd+0 -> Actual result?

Unless told otherwise, I'll assume that Ctrl+0/Cmd+0 do nothing in composition on MAC/Linux, as they do nothing in composition on windows.

Comment 5

[Thomas D. (:thomas8)]

(In reply to Thomas D. from comment #3)
> > For ==Writing Messages==, I suggest we remove documentation for "Restore
> > Text Size: Ctrl+0" until it is fixed and/or verified for other OS.
> removed. Needs further verification for Unix/MAC, and followup bug.

Verification still needed for Linux/MAC (see STR in comment 4), but otherwise sreepriya and I have fixed the respective documentation.

I filed followup bug 738194 to make the zoom behaviour in composition complete, accessible and bug-free (esp. bug 512968), and consistent with msg reader zoom behaviour, especially after bug 449299 (compose in tab).

So the job here is done -> Fixed.

(1) https://support.mozillamessaging.com/en-US/kb/keyboard-shortcuts