78734 - Address Book Menu: Add/Change/Move/Delete menu items

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

Description

[Ninoschka Baca]

Overview: This bug summarizes the changes that should be made to the Address 
Book menus. It includes mnemonic and accelerator issues as well. 

Note: I initially logged Bugscape bug# 4773 because many of the issues were 
Netscape specific. I have now copied only the Mozilla issues here. 

1. Add
a. Menu item
- File|Work Offline. Should this be added?
- View|Card Summary (bug# 77379)
- View|Sort by|Ascending (bug# 77263)
- View|Sort by|Descending (bug# 77263)

b. Accelerator
- File|New|Blank Page to Edit needs "Ctrl+Shift+N"

Comment 1

[Ninoschka Baca]

*** Bug 41970 has been marked as a duplicate of this bug. ***

Comment 2

[Ninoschka Baca]

*** Bug 42091 has been marked as a duplicate of this bug. ***

Comment 3

[Ninoschka Baca]

*** Bug 15108 has been marked as a duplicate of this bug. ***

Comment 4

[Gervase Markham [:gerv]]

It's not really worth me writing a patch for one tiny thing :-) I'll let the 
person who deals with the other issues clean that up.

Gerv

Comment 5

[Gervase Markham [:gerv]]

Oops - reassigning.

Gerv

Comment 6

[scottputterman]

As I mentioned in the bugscape bug, nsbeta1+, 0.9.2 for 1b. cc'ing Sean who I
think has a similar bug for the 3pane.

Comment 7

[scottputterman]

moving to 0.9.3

Comment 8

[scottputterman]

moving to 0.9.4

Comment 9

[Andreas Premstaller]

The following menu items found in the spec at
http://www.mozilla.org/mailnews/specs/addressbook/AB_Menus.html (last touched
taday) are missing:
Edit->Undo/Redo
Edit->Cut/Copy/Paste

Comment 10

[scottputterman]

moving to 0.9.5

Comment 11

[Olga]

Build 2001-09-13-0.9.4

Latest update:

1. Add 
   a. Accelerator for menu item and sub-menu items:
      - File|Print Plus, need "L"
      - File|Print Plus|Print Central, need "C"
      - File|Print Plus|Printer Supplies, need "S"
      - File|Print Plus|Printing Services, need "e" 

   b. Ellipsis after Menu Item
    - File|New|Address Book Card, need "..." since it brings another 
 dialog.

Comment 12

[Scott MacGregor]

not an emojo stopper.

Comment 13

[scottputterman]

reassigning to racham

Comment 14

[scottputterman]

moving to mozilla1.0

Comment 15

[Andreas Premstaller]

Build 2002-03-14-03:
File->Print Address Book needs mnemonic A, according to spec.

Comment 16

[Olga]

I remove nsbeta1- keyword - it was for MachV.

Comment 17

[Olga]

Now I add 'nsbeta1' keyword for Buffy. Sorry, it's faster to edit multiple bugs
at once than manually go to each and remove minus.

Comment 18

[Ninoschka Baca]

Trunk build 2002-12-23: Winme

1. File menu
a. Move Print Plus after Print Address book (currently it displays Print Card,
Print Plus then Print Address Book)

b. Print Plus needs mnemonic "i"

c. File|New|Compose Page needs accelerator "Ctrl+Shift+N

2.View menu
a. Sort by should display Organization with an "O" mnemonic.

b. Sort by, the order of the items doesn't match the order in the columns or a
card. What order should it be? Why not match the order of the columns?

Comment 19

[jglick]

See bugscape bug 14365 for Print Plus issue.

Comment 20

[Ninoschka Baca]

Trunk build 2002-12-23: Winme
Here are the updated changes required:

1. File menu
a.Top level menu item order should match the spec

The current order is:

New
Close
------
Page Setup...
Print Card...
Print Plus
Print Address Book...
----------------------
Print Preview Card
Print Preview Address Book
----------------------
Exit

The order should actually be:

New
Close
--------
Page Setup
Print Preview (Card/Mailing List)
Print Preview Address Book
Print (Card/Mailing List)
Print Address Book
Print Plus
----------
Exit

In general the Print Preview items should be first, followed by the Print menu
items and then the Print Plus menu item.

b. File|New

Actual: The Message menu item is listed before the Navigator menu item.
Expected: To match the UI Spec, Navigator should be listed before the Message
menu item.

c. File|New|Compose Page needs accelerator "Ctrl+Shift+N


2.View menu

a. Sort by, the order of the items doesn't match the order in the columns or a
card. What order should it be? Why not match the order of the columns?

Comment 21

[jglick]

>2.View menu
>a. Sort by, the order of the items doesn't match the order in the columns or a
>card. What order should it be? Why not match the order of the columns?

Order of the columns can be changed by the user (so the menu and columns won't
match if the user reordered the columns). We could order the menu alphabetically.

Comment 22

[Ninoschka Baca]

2. View menu
a. Sort by: In comment# 20 when I referred to placing them in column order I was
actually thinking about the order in the column widget, not necessarily the
order that the user created by moving columns around. I think alphabetical order
would be fine.

Comment 23

[Samir Gehani]

Mail triage team: nsbeta1+/adt3

Comment 24

[Cavin Song]

Reassigning.

Comment 25

[jglick]

Attachment: example

Re comment #22.
Ah, ok. I get it. :-)
I'd make them both match the "Sort by" fly out order. (Items ordered by
relevance, and phone #s grouped).

Comment 26

[shliang]

Attachment: patch

patch for changes in comment #20

(diff for results pane overlay has changes from the dirTree conversion in it)

Comment 27

[(not reading, please use [e-mail] instead)]

Comment on attachment 115573 [details] [diff] [review]
patch

r/sr=sspitzer

contains some parts of bug #135877, but shuehan explained what was what.

Comment 28

[shliang]

marking fixed.

Comment 29

[Ninoschka Baca]

Trunk build 2003-03-03: WinXP, Linux RH 8
Verified Fixed.