799769 - GCLI screenshot syntax changed / is confusing

Status: RESOLVED INVALID

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Reuben Morais [:reuben]]

The screenshot command doesn't work when any optional parameter is specified: http://cl.ly/image/423d1q253M30

Comment 1

[Girish Sharma [:Optimizer]]

(In reply to Reuben Morais [:reuben] from comment #0)
> The screenshot command doesn't work when any optional parameter is
> specified: http://cl.ly/image/423d1q253M30

Hi, If you are on Aurora and above, the syntax of the commands has changed. Please use "help screenshot" to know more

In short:

screenshot --filename <name> --delay <delay seconds> --selector <selector> --clipboard --chrome --fullscreen

In most general use, you only want the screenshot of what you re seeing, which as become really easy to do now. Just type:

screenshot

and your screenshot preview will also be shown.

Refer to bug 788890, bug 790294 for more information.

Comment 2

[Girish Sharma [:Optimizer]]

Also, all the other options than the filename have been moved to optional options, so you will have to provide the "--<option name>" to use them

For example

screenshot bug.png --delay 5

Comment 3

[Reuben Morais [:reuben]]

(In reply to Girish Sharma [:Optimizer] from comment #2)
> Also, all the other options than the filename have been moved to optional
> options, so you will have to provide the "--<option name>" to use them

Oh, interesting… I should have investigated further before filing this bug, thanks for the information.

Comment 11

[Artem Kuroptev]

I submitted 832902 bug, which now marked as duplicate of this one. 
Indid, "screenshot" works with new syntax, thanks. But how users should know about this changes? I have checked "help screenshot" before submitting the bug, and it has no mention of "--" with arguments. Nor FF18 release notes. Is that a documentation bug?

Comment 12

[Joe Walker [:jwalker]]

(In reply to Artem Kuroptev from comment #11)
> I submitted 832902 bug, which now marked as duplicate of this one. 
> Indid, "screenshot" works with new syntax, thanks. But how users should know
> about this changes? I have checked "help screenshot" before submitting the
> bug, and it has no mention of "--" with arguments. Nor FF18 release notes.
> Is that a documentation bug?

There are 3 things that we've got wrong, I think:
* The original video was quickly out of date. The plan was always to use the traditional unix style (and indeed it's always worked) but various changes made the style used in the video not sustainable. Although the video is very good, the original syntax of the command was always somewhat awkward.
* The hints as to the right thing are not good enough yet. We can and should make them better. We are working on that in several strands but I've just created bug 833092 so we can think about (and maybe solve them) in one go.
* We don't yet have a way to forward people that have seen the old way to the new way. The real solution is for #2 to be good enough that no-one needs to ask, but perhaps we need to be more proactive than that.

Does that make sense?

Comment 13

[Joe Walker [:jwalker]]

In addition I've re-opened this bug, we can consider it fixed when either bug 833092 is done enough that it's no longer confusing, or when #3 above is done.

Comment 14

[Brian Moore]

--fullpage is not working in Firefox 19...

this: screenshot list --delay 0 --fullpage 
and this: screenshot list --delay 0

produce the exact same capture.

Comment 15

[Girish Sharma [:Optimizer]]

Just tested on 19. Works for me.

Comment 16

[Brian Moore]

OK I did some more testing.

Looks like its the page I am viewing (admin page of listrak) that is causing the problem. Is that even possible?

No matter what page I am on in the listrak admin it will only capture the viewport and no more.

ugg.

Comment 17

[Joe Walker [:jwalker]]

Can you give us a link to test?

Comment 18

[Girish Sharma [:Optimizer]]

I think the particular site that he is testing is embedded in an iframe. The whole content is in an iframe and thus the fullpage window is still limited to the viewport.

Comment 19

[Brian Moore]

(In reply to Joe Walker [:jwalker] from comment #17)
> Can you give us a link to test?

I can't since its our private account with listrak.com

I can put you in contact with their support team and hopefully they have a dummy account they can provide to help fix this problem.

(In reply to Girish Sharma [:Optimizer] from comment #18)
> I think the particular site that he is testing is embedded in an iframe. The
> whole content is in an iframe and thus the fullpage window is still limited
> to the viewport.

looking at the source I don't see any iframes.

anything else to look for that might cause this?

Comment 20

[Joe Walker [:jwalker]]

Triage. Filter on Lobster Thermidor.
This bug is confusing - it's about several things, so I'm going to close it after 3 years with no activity. If there is anything here that is important, feel free to raise a new bug with clearer goals!