831913 - Story - Use the Firefox app bar in snapped view

Status: VERIFIED FIXED

(Tracking Graveyard :: Metro Operations, defect, P2)

Description

[Asa Dotzler [:asa]]

Attachment: UC-33 Use the navigation app bar in snapped view

Comment 1

[Matt Brubeck (:mbrubeck)]

This is currently implemented as described, but we expect it will need some updates when we change the appbar(s) in bug 835622.

Comment 2

[Allison Naaktgeboren :ally]

taking to figure out whats going on here

Comment 3

[Allison Naaktgeboren :ally]

This looks fits the description of the user story on today's mozilla-central.

Note, I do see a very brief flicker of the tab strip if I try to swipe down twice really fast while the machine is under heavy load. I have to work at it to get it though, so this may not be worth a v1 fix.

Comment 4

[Marco Mucci [:MarcoM]]

For Kamil to test and verify.

Comment 5

[Kamil Jozwiak [:kjozwiak]]

Went through the following Story and found a Defect when going through iteration #6 testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-24-03-09-17-mozilla-central/

- As mentioned in Comment 3, the tab stripe will flicker very quickly when swiping from either the top or the bottom (using Windows + Z also works). I've reproduced this 100% of the time on both the about:start screen or the auto complete screen (when you start typing something in the URL bar). This happens even when the load is very light and no tabs are opened.

Comment 6

[Marco Mucci [:MarcoM]]

Hi Asa,
Ally would like to confirm if you want the related Defect (Bug 865567) fixed for V1.  If you don't, the Story can be resolved.

Comment 7

[Asa Dotzler [:asa]]

(In reply to Marco Mucci [:MarcoM] from comment #6)
> Hi Asa,
> Ally would like to confirm if you want the related Defect (Bug 865567) fixed
> for V1.  If you don't, the Story can be resolved.

That seems like a good defect to to add to our defects backlog and try to get fixed for v1 but I wouldn't hold the story open for it if that's not necessary.

Comment 8

[Marco Mucci [:MarcoM]]

Thanks Asa.  We'll try to close it out this iteration to clear it out of the backlog.

Comment 9

[Allison Naaktgeboren :ally]

Marco, are we good to close this & the Epic now?

Comment 10

[Marco Mucci [:MarcoM]]

Hi Ally, thanks for the update.  The dependency is resolved so this story can be resolved as well.

Comment 11

[Allison Naaktgeboren :ally]

and stay dead! (no illuminati card required[1])

[1] http://www.illuminatigamerevealed.com/012-and-stay-dead.html

Comment 12

[Marco Mucci [:MarcoM]]

For testing and verification.

Comment 13

[Kamil Jozwiak [:kjozwiak]]

Went through the following Story and found a Defect while Testing/Verification. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-05-07-03-09-48-mozilla-central/

Found a small issue when going through the "Story", when you dismiss the navigation bar in snapped view more then once, you will notice that it will not be smooth and is a little choppy compared to sliding in the navigation bar.

Sliding in the Navigation Bar - Very smooth and looks great
Dismissing the Navigation Bar - You will notice there's a few "jumps" making it look a little choppy

Other then that, everything is looking great! The issue in Comment 5 has been fixed!

Comment 14

[Marco Mucci [:MarcoM]]

For testing and verification.

Comment 15

[juan becerra [:juanb]]

Tested on 21013-05-16 using latest nightly built from http://hg.mozilla.org/mozilla-central/rev/cc139752bed4

- Tested basic scenario and that works. However I filed three bugs related to this story: bug 873276, bug 873272, and bug 873266 which deal with Settings flyout, screen orientation while it is in snapped view, and software keyboard.

Comment 16

[Marco Mucci [:MarcoM]]

Hi Frank, can you let me know if Bug 831913 will be landing today?

Comment 17

[Frank Yan (:fryn)]

The only thing keeping this bug open is bug 857437, and I'll have a patch up for that this week.

Comment 18

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130806104538
Built from http://hg.mozilla.org/mozilla-central/rev/1e381c91885d

WFM
Tested on windows 8 using latest nightly. 
Followed steps given in success scenario and got expected result.

Comment 19

[Samvedana (:Samvedana)]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130815030203
Built from http://hg.mozilla.org/mozilla-central/rev/a8daa428ccbc

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps given in success scenario and got expected result.

Comment 20

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Story" for iteration #15 without any issues (touch device verification). Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-10-15-03-03-19-mozilla-central/

- Went through the original story from comment #0 without any issues
- Went through the test case(s) in comment # 13 without any issues
- Ensured that I can insert a URL into the "Navigation App Bar" without any issues
- Ensured that I can refresh the webite using the "Navigation App Bar" without any issues
- Ensured that I can use both the back & forward buttons using the "Navigation App Bar" without any issues
- Went through all the test cases while snapped on both the right & left side of the screen without any issues