84272 - UI needed for bookmarks.import_system_favorites preference (Import IE favorites)

Status: RESOLVED EXPIRED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Matthew Wilson]

From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0b; Windows NT 4.0)
BuildID:    2001060320

Bug 22642 added functionality for the user to choose whether to import their 
system favourites with the browser.bookmarks.import_system_favorites 
preference. This needs a UI.

In 22642 Ben said:

"Here's the solution I want: 

No preferences panel UI. This is more of a view option than a checkbox in 
prefs. 

Show the folder by default. Allow the user to delete it, perform a delete and 
then update the pref. Have a menu item in the view menu maybe, with platform 
text:

[x] Internet Explorer Favorites (Windows and Mac). 
[ ] NetPositive Favorites (BeOS)"

Comment 1

[Chris Lyon]

*** Bug 84281 has been marked as a duplicate of this bug. ***

Comment 2

[Peter Lairo]

Show/hide IE favs is something a given user with likely "fundamentally" want or
"fundamentally" not want.

Therefore, I'm not sure it makes sense to clutter up the menu (high traffic
area) with a selection that will rarely be used. It might be more suitable in
the prefs (low traffic area) since this setting is likely to be made only once
per user.

If it must be in the menu, I suggest to put it under:
View -> Show/Hide -> Internet Explorer Favorites

Comment 3

[Matthew Wilson]

My understanding is that this would be in the Bookmarks Manager View menu, not 
the main browser view menu.

(Patch to follow.)

Comment 4

[Matthew Wilson]

Attachment: Sets up overlays for a new item in the Bookmark Manager View menu; also enables Delete for the system favorites

Comment 5

[Matthew Wilson]

Attachment: New file bookmarks/resources/win/bookmarksImportOverlay.xul

Comment 6

[Matthew Wilson]

Attachment: New file bookmarks/resources/win/jar.mn

Comment 7

[Matthew Wilson]

Attachment: New file bookmarks/resources/win/makefile.win

Comment 8

[Matthew Wilson]

The above patches allow for platform-specific overlays in order to create an 
option View -> [whatever] Favorites in Bookmarks Manager. I have attached 
Windows versions of the new files.

Comment 9

[Jacek Piskozub]

*** Bug 85201 has been marked as a duplicate of this bug. ***

Comment 10

[David Hallowell]

Adding that bit to the end of the summary because I searched for IE in the
component 'bookmarks' to see if this bug was already filed and because it didn't
show up I filed a duplicate, so this may stop other people doing the same. 

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter 
email notifications caused by this by searching for 'ilikegoats'.

Comment 12

[Peter Trudelle]

mass reassign of pchen bookmark bugs to ben

Comment 13

[Jonas Jørgensen]

Matthew, does your patch still work? Why is this bug futured when it has a patch?

Comment 14

[Chris Gushue]

Does this pref even work now? I have it in my prefs.js, but it seems to have
stopped working with the 2002-02-21 Win32 build...

Comment 15

[Alfonso Martinez]

*** Bug 152106 has been marked as a duplicate of this bug. ***

Comment 16

[Chris Lyon]

*** Bug 171360 has been marked as a duplicate of this bug. ***

Comment 17

[Tony Tovar]

suggest renaming this so that it is distinct from bug 59636.  For instance, how
about: "Need UI to update 'Imported IE Favorites' bookmarks
[import_system_favorites preference]"?
___________________________________________

Also, I have also made comments on the other bug (which I think is about
permanent conversion of IE Favorites) and on bug 56765 about the continuing
confusion in goals for Mozilla's IE/Windows integration.  For instance, in the
current Phoenix 2002-10-28 (which I assume it working the same as Mozilla's
bookmarks?) the 'Imported IE Favorites' bookmarks are now editable ... but still
don't "push" their changes back to IE.  I want to be able to switch
back-and-forth between IE and Mozilla without losing the ability to share IE
Favorites.  So, making the imported bookmarks permanent is a setback to me.  See
my comments on bug 56765 for more specific comments.

Comment 18

[Christopher Hoess (gone)]

*** Bug 197104 has been marked as a duplicate of this bug. ***

Comment 19

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 20

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 21

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 22

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 23

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 24

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 25

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 26

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420