854070 - Defect - Caret selection initiated from the end of a text input is buggy

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Input, defect, P1)

Description

[Jim Mathies [:jimm]]

str

- visit google.com
- enter some text into the search edit
- tap off the edit
- tap at the end of the entered text
(a monocle should appear)
- drag monocle to the left

result: monocle is hidden, no text is selected
expected: text is selected

Comment 1

[Jim Mathies [:jimm]]

Interacting with google's auto-complete / search edit is buggy. This might be more specific to the google search page.

Comment 2

[Marco Mucci [:MarcoM]]

Hey Jim, would this bug be a Defect for Iteration #5?

Comment 3

[Jim Mathies [:jimm]]

This bug should probably sit until more people have a chance to play with selection giving us the chance to better diagnose any odd behavior.

Comment 4

[Brian R. Bondy [:bbondy]]

Jim are you taking this one?

Comment 5

[Marco Mucci [:MarcoM]]

See question from Brian in Comment 4.

Comment 6

[Jim Mathies [:jimm]]

No, I explained this in comment 3. What I would appreciate is some help in diagnosing if there's an issue, and if so, what the steps are to reproduce, side effects, etc.. I see odd behavior *sometimes*, but I'm not sure if it's the caret work or maybe something to do with all our form positioning issues, or maybe just site related.

Comment 7

[Brian R. Bondy [:bbondy]]

Oops k I moved to needs to be planned for now until we get the extra info and then we can move back.

Comment 8

[Jim Mathies [:jimm]]

Attachment: testcase

Comment 9

[Marco Mucci [:MarcoM]]

Jim's point estimate=3

Comment 10

[Jim Mathies [:jimm]]

This should be too hard to fix, we need to add a bit of hysteresis in the initial drag calculations to better detect which direction the user is trying to expand selection. 

http://mxr.mozilla.org/mozilla-central/source/browser/metro/base/content/helperui/SelectionHelperUI.js#976

Comment 11

[Jim Mathies [:jimm]]

Attachment: fix

Comment 12

[Jim Mathies [:jimm]]

Attachment: fix

Another smallish selection fix - don't assume a direction unless the user has dragged past a 10px threshold.

Comment 13

[Jim Mathies [:jimm]]

Bah - ignore this:

> pref("metro.debug.selection.dumpEvents", true);

removed from my local patch.

Comment 14

[Marco Mucci [:MarcoM]]

Jim's point estimate = 1

Comment 15

[Brian R. Bondy [:bbondy]]

Comment on attachment 737923 [details] [diff] [review]
fix

Review of attachment 737923 [details] [diff] [review]:
-----------------------------------------------------------------

as you mentioned without pref.

Comment 16

[Marco Mucci [:MarcoM]]

Point Estimate = 3.

Comment 17

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2476ca81c62

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a2476ca81c62

Comment 19

[Marco Mucci [:MarcoM]]

For Raymond to test and verify.

Comment 20

[raymond [:retornam] (inactive)]

verified fixed using build http://hg.mozilla.org/mozilla-central/rev/fef5f202b2dc

Comment 21

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Verified for it8 but filed the following related bugs:
  bug 881940
  bug 881938
  bug 881932
  bug 881928

Comment 22

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #10 testing and found any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-07-17-03-02-07-mozilla-central/

- Went through the original test case that has been added in comment 0 and ran into issues. Created a new defect and attached it to this ticket.

Comment 23

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130806104538
Built from http://hg.mozilla.org/mozilla-central/rev/1e381c91885d

Didn't work for me.
Tested on windows 8 using latest nightly  for iteration-11. 

STR
- visit google.com
- enter some text into the search edit
- tap off the edit
- tap at the end of the entered text
(a monocle should appear)
- drag monocle to the left

result: monocle was hidden, no text was selected
expected: text must be selected

Comment 24

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130826074752
Built from http://hg.mozilla.org/mozilla-central/rev/14b1e8c2957e

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and got expected result.